[SRU] alsa-lib: ucm: Regex returns correct value without matching a string

Bug #1949329 reported by Hui Wang
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
New
Undecided
Unassigned
alsa-lib (Ubuntu)
Fix Released
High
Hui Wang
Focal
Fix Released
High
Unassigned
Hirsute
Fix Released
High
Unassigned
Impish
Fix Released
High
Unassigned
Jammy
Fix Released
High
Hui Wang

Bug Description

[Impact]
In the Dell project, we tried to enable the audio on a machine, the machine has the soundwire audio design, it needs to load the ucm correctly, then users could see the audio devices from gnome. But on this machine, the ucm can't be loaded, through debugging, we found this machine has no headset, the Regex returns a wrong value when matching "Regex " hs:([a-z0-9]+(-sdca)?)". If let Regex returns a correct value, the ucm could be loaded successfully.

[Fix]
Backport a commit from upstream, this commit is merged to upstream from v1.2.5

[Test]
After installed the patched libasound2, reboot, we could see the ucm is loaded succesfully on this machine, and open the gnome-sound-setting, we could see the internal mic and internal speaker, and all of them could work normally.

[Where problems will occur]
This change affect the Regex parser in the ucm, so if it could introduce regression, it will be on the ucm. It could make the audio not work (fail to load ucm and users can't see any audio devices from gnome) on the machines which need ucm. But this possibility is very low, since this commit is backported from upstream and we already tested this backporting on 2 lenovo machines and 2 Dell machines which all need ucm to work.

Hui Wang (hui.wang)
Changed in alsa-lib (Ubuntu Focal):
importance: Undecided → High
Changed in alsa-lib (Ubuntu Hirsute):
importance: Undecided → High
Changed in alsa-lib (Ubuntu Impish):
importance: Undecided → High
Changed in alsa-lib (Ubuntu Jammy):
importance: Undecided → High
Changed in alsa-lib (Ubuntu Focal):
status: New → In Progress
Changed in alsa-lib (Ubuntu Hirsute):
status: New → In Progress
Changed in alsa-lib (Ubuntu Impish):
status: New → In Progress
Changed in alsa-lib (Ubuntu Jammy):
status: New → In Progress
tags: added: oem-priority originate-from-1943203 somerville
Revision history for this message
Hui Wang (hui.wang) wrote :

This is the debdiff for focal.

Thanks.

Revision history for this message
Hui Wang (hui.wang) wrote :

This is the debdiff for hirsute.

Thanks.

Revision history for this message
Hui Wang (hui.wang) wrote :

This is the debdiff for impish

Thanks.

Revision history for this message
Hui Wang (hui.wang) wrote :

And I can't download the docker image of Jammy, Maybe the Jammy share the same libasound2 with Impish?

Hui Wang (hui.wang)
description: updated
Changed in alsa-lib (Ubuntu Jammy):
status: In Progress → Fix Committed
Changed in alsa-lib (Ubuntu Impish):
status: In Progress → Fix Committed
Changed in alsa-lib (Ubuntu Hirsute):
status: In Progress → Fix Committed
Changed in alsa-lib (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :

Yes, there was no change in the J serie yet. Uploaded now to current and stables

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Hui, or anyone else affected,

Accepted alsa-lib into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-lib/1.2.4-1.1ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-impish
tags: added: verification-needed-hirsute
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Hui, or anyone else affected,

Accepted alsa-lib into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-lib/1.2.4-1.1ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-focal
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Hui, or anyone else affected,

Accepted alsa-lib into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-lib/1.2.2-2.1ubuntu2.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Hui Wang (hui.wang) wrote :

Impish:

Install the impish on that Dell machine (sdw audio without headset), enable the impish-proposed ppa in the /etc/apt/sources.list, sudo apt-get update, sudo apt install libasound2, reboot, check the gnome-sound-setting, the speaker and internal digital mic show in the UI, this means the pulseaudio loads the correct UCM for this machine. And test playback and recording, all worked well.

Verification done on impish.

tags: added: verification-done-impish
removed: verification-needed-impish
Revision history for this message
Hui Wang (hui.wang) wrote :

Hirsute:

Install the Hirsute on that Dell machine (sdw audio without headset), enable the hirsute-proposed ppa in the /etc/apt/sources.list, sudo apt-get update, sudo apt install libasound2, the libaousnd2 1.2.4-1.1ubuntu2.1 is installed, reboot, check the gnome-sound-setting, the speaker and internal digital mic show in the UI, this means the pulseaudio loads the correct UCM for this machine. And test playback and recording, all worked well.

Verification done on hirsute.

tags: added: verification-done-hirsute
removed: verification-needed-hirsute
Revision history for this message
Hui Wang (hui.wang) wrote :

Focal:

Install the Focal on that Dell machine (sdw audio without headset), enable the focal-proposed ppa in the /etc/apt/sources.list, sudo apt-get update, sudo apt install libasound2, the libaousnd2 1.2.2-2.1ubuntu2.5 is installed, reboot, check the gnome-sound-setting, the speaker and internal digital mic show in the UI, this means the pulseaudio loads the correct UCM for this machine. And test playback and recording, all worked well.

Verification done on focal.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (alsa-lib/1.2.4-1.1ubuntu2.1)

All autopkgtests for the newly accepted alsa-lib (1.2.4-1.1ubuntu2.1) for hirsute have finished running.
The following regressions have been reported in tests triggered by the package:

osmid/0.8.0~repack-2 (amd64)
cmake/3.18.4-2ubuntu1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/hirsute/update_excuses.html#alsa-lib

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-lib - 1.2.4-1.1ubuntu4

---------------
alsa-lib (1.2.4-1.1ubuntu4) jammy; urgency=medium

  * d/p/0001-ucm-fix-regexec-REG_NOMATCH-state-handling-for-defin.patch
    - ucm: Fix a Regex parser bug, when there is no match, need to
      set err to 0, otherwise, the caller will get a wrong match instead of
      no match. (LP: #1949329)

 -- Hui Wang <email address hidden> Mon, 01 Nov 2021 15:05:47 +0800

Changed in alsa-lib (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-lib - 1.2.4-1.1ubuntu3.1

---------------
alsa-lib (1.2.4-1.1ubuntu3.1) impish; urgency=medium

  * d/p/0001-ucm-fix-regexec-REG_NOMATCH-state-handling-for-defin.patch
    - ucm: Fix a Regex parser bug, when there is no match, need to
      set err to 0, otherwise, the caller will get a wrong match instead of
      no match. (LP: #1949329)

 -- Hui Wang <email address hidden> Mon, 01 Nov 2021 15:05:47 +0800

Changed in alsa-lib (Ubuntu Impish):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Update Released

The verification of the Stable Release Update for alsa-lib has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-lib - 1.2.4-1.1ubuntu2.1

---------------
alsa-lib (1.2.4-1.1ubuntu2.1) hirsute; urgency=medium

  * d/p/0001-ucm-fix-regexec-REG_NOMATCH-state-handling-for-defin.patch
    - ucm: Fix a Regex parser bug, when there is no match, need to
    set err to 0, otherwise, the caller will get a wrong match instead of
    no match. (LP: #1949329)

 -- Hui Wang <email address hidden> Mon, 01 Nov 2021 15:17:07 +0800

Changed in alsa-lib (Ubuntu Hirsute):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-lib - 1.2.2-2.1ubuntu2.5

---------------
alsa-lib (1.2.2-2.1ubuntu2.5) focal; urgency=medium

  * d/p/0001-ucm-fix-regexec-REG_NOMATCH-state-handling-for-defin.patch
    - ucm: Fix a Regex parser bug, when there is no match, need to
    set err to 0, otherwise, the caller will get a wrong match instead of
    no match. (LP: #1949329)

 -- Hui Wang <email address hidden> Mon, 01 Nov 2021 15:25:07 +0800

Changed in alsa-lib (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers