alsa-lib package needs a compile/link/run test

[Rafał Cieślak]

This bug represents the lack of conpile/link/run test for jenkins for package `alsa-lib`.

[Rafał Cieślak (rafalcieslak256)]

I cannot manage to make a correct MP, looks like I am picking wrong branches to work on. Attaching a patch instead.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "build_test.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Daniel Holbach (dholbach)]

You might have to add XS-Testsuite: autopkgtest to debian/control.

[Luke Yelavich (themuso)]

I must admit I do not see the point of this test. If the package fails to build, this will be known before the autopkg tests are run. The building of the package could also be a test in of itself.

[Luke Yelavich (themuso)]

Oh sorry, I misread the patch, thats probably not a bad start for such a test, and can be further expanded in the future.

Thanks.

[Martin Pitt (pitti)]

Luke, we don't always rebuild packages if any of their dependencies, tool chain, multi-arch configuration etc. change, and tests during the package build won't help you to verify that your debian/ bits install all the required header, pkg-config etc. files.

[Martin Pitt (pitti)]

Confirmed to work with:

$ run-adt-test -r quantal -a amd64 -b lp:~rafalcieslak256/ubuntu/quantal/alsa-lib/build-test alsa-lib

But please commit the "XS-Testsuite: autopkgtest" header (or whoever merges this), as otherwise we can't run it automatically.

[Luke Yelavich (themuso)]

On Wed, Oct 31, 2012 at 09:24:09AM CET, Martin Pitt wrote:
> Luke, we don't always rebuild packages if any of their dependencies,
> tool chain, multi-arch configuration etc. change, and tests during the
> package build won't help you to verify that your debian/ bits install
> all the required header, pkg-config etc. files.

Yeah I realized that not long after I wrote my first comment.

[Rafał Cieślak (rafalcieslak256)]

Thanks for verifying that.
I have added XS-Testsuite entries and committed changes to lp:~rafalcieslak256/ubuntu/quantal/alsa-lib/build-test
I am unsure if this is correct though, requesting merge back to the branch I started with results in a diff of lots of changes, apparently including changes that were introduced before my commits.
I am attaching a patch as it does not have such problems.

[David Henningsson (diwic)]

The branch you're looking for is probably https://code.launchpad.net/~ubuntu-audio-dev/alsa-lib/ubuntu.quantal - as we also advertise when running "apt-get source alsa-lib"

However I guess Luke or Martin will pick it up anyway. Thanks for your contribution!

[Launchpad Janitor (janitor)]

This bug was fixed in the package alsa-lib - 1.0.25-3ubuntu5

---------------
alsa-lib (1.0.25-3ubuntu5) raring-proposed; urgency=low

  * Add a compile/run autopkg test, thanks to Rafał Cieślak. (LP: #1073346)
 -- Luke Yelavich <email address hidden> Wed, 31 Oct 2012 13:49:43 +0100