undo does not work on deleted items

Bug #225941 reported by Travis Watkins on 2008-05-02
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Alacarte Menu Editor
Fix Released
Medium
alacarte (Ubuntu)
High
Unassigned
Hardy
High
Unassigned
Intrepid
High
Unassigned

Bug Description

Binary package hint: alacarte

When you delete an item from alacarte the undo functionality does not work so the item is lost. This is because in deleteItem the copy for undoing is saved _after_ the change has been made to "delete" the item instead of before. James Westby noticed this and provided a simple fix that moves the undo checkpoint before the file modification. This is a very simple and obviously correct fix and I cannot see any way for it to cause regressions. Note that this does not fix bug 118936, that bug is for revert not restoring deleted items and there is no clear way to fix it.

TEST CASE:
1. Highlight an item in alacarte
2. Press the delete key on your keyboard
3. Press Ctrl-Z to undo the change

Travis Watkins (amaranth) wrote :
Changed in alacarte:
importance: Undecided → High
milestone: none → ubuntu-8.04.1
status: New → In Progress
Steve Langasek (vorlon) on 2008-05-02
Changed in alacarte:
importance: Undecided → High
milestone: none → ubuntu-8.04.1
status: New → In Progress
milestone: ubuntu-8.04.1 → none
Steve Langasek (vorlon) on 2008-06-30
Changed in alacarte:
milestone: ubuntu-8.04.1 → ubuntu-8.04.2
James Westby (james-w) wrote :

Hi Travis,

Is this not fixed in Intrepid? If not it should be fixed there before
hardy-proposed.

Thanks,

James

Steve Langasek (vorlon) wrote :

Is this still unfixed in intrepid? If this is going to be fixed for hardy it needs to be fixed for later releases as well.

James Westby (james-w) wrote :

Hi,

Here's a tested patch against the Intrepid version.

Please sponsor in to Intrepid.

Thanks,

James

Martin Pitt (pitti) wrote :

Sponsored.

Changed in alacarte:
status: In Progress → Fix Committed
Martin Pitt (pitti) wrote :

Uploaded hardy patch as well, added missing bug # in changelog.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alacarte - 0.11.6-0ubuntu2

---------------
alacarte (0.11.6-0ubuntu2) intrepid; urgency=low

  * Make undo work on deleted items. (LP: #225941)
    - Thanks to Travis Watkins.

 -- James Westby <email address hidden> Wed, 15 Oct 2008 19:23:57 +0100

Changed in alacarte:
status: Fix Committed → Fix Released
Martin Pitt (pitti) wrote :

Accepted into hardy-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in alacarte:
milestone: ubuntu-8.04.2 → none
status: In Progress → Fix Committed
Steve Beattie (sbeattie) wrote :

I am able to reproduce the problem with alacarte 0.11.5-0ubuntu1 in 8.04 and can confirm that alacarte 0.11.5-0ubuntu1.1 in hardy-proposed has a working undo function. Other functionality appears to still work properly, though it might be nice for alacarte to jump to the menu entry that it just reverted via the undo (particularly in multiple undo operations).

Martin Pitt (pitti) wrote :

Copied to hardy-updates.

Changed in alacarte:
status: Fix Committed → Fix Released
rarr (gordis-2004-891) on 2008-11-13
Changed in alacarte:
assignee: nobody → gordis-2004-891
status: Fix Released → Confirmed
assignee: gordis-2004-891 → nobody
James Westby (james-w) on 2008-11-13
Changed in alacarte:
status: Confirmed → Fix Released
Changed in alacarte:
status: Unknown → New
Changed in alacarte:
importance: Unknown → Medium
Changed in alacarte:
status: New → Fix Released

Hello Customer

A wide selection of brands is available to choose from.
The perfect place to buy watches as we offer best quality, excellent service, money back guarantee in case you are not satisfied and have many other strong points, such as fast delivery, helpful and caring customer service.

******************************************************
Today I received my two watches. Both watches were spectacular, you guys did a wonderful job and I will definitely recommend you to all my friends!
Thank you!
                     Will Rangel
******************************************************

Click here ---> http://penio.ru

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.