Ignore casing in domain/ section of sssd.conf

[Jean-Baptiste Lallement]

Upstream issues: https://github.com/ubuntu/adsys/issues/1054
tracking bug https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/2078245

[ Impact ]

adsys does not accept uppercase domainnames and lowercase ones mixed like this:

[sssd]
domains = domain.tld
config_file_version = 2
services = nss, pam, ifp
default_domain_suffix = domain.tld

[domain/DOMAIN.TLD]
default_shell = /bin/bash

This imposed to set all the domains to lower cases.
This has been introduced by the support for Winbind.

[ Test Plan ]

1. In sssd.conf set the value of the key "domains" and the correponding section to the same domain but with different casing
2. Log in

without the patch, the user cannot log in and the following error is displayed in the logs:
Jul 17 15:06:09 HOSTNAME systemd[1]: Starting ADSys daemon service...
Jul 17 15:06:09 HOSTNAME adsysd[35284]: level=error msg="couldn't create adsys service: could not initialize AD backend: can't get domain configuration from {Conf:/etc/sssd/sssd.conf CacheDir:/var/lib/sss/db}:could not find AD domain section corresponding to "domain.tld">

with the patch the user can log in

[ Where problems could occur ]

Worst case, the user still cannot log in

[ Other Info ]

[Launchpad Janitor (janitor)]

This bug was fixed in the package adsys - 0.15.1

---------------
adsys (0.15.1) oracular; urgency=medium

  * Fix version based tests on released version

adsys (0.15) oracular; urgency=medium

  * Fix DCONF policy manager removing user DB on empty policy (LP: #2078245)
  * Ignore casing in domain/ section of sssd.conf (LP: #2078246)
  * Fix parsing of slash usernames (i.e. domain\user) (LP: #2078247)
  * Fix errno in get_ticket_path(LP: #2078473)
  * Remove XML declaration from glib schemas
  * Bump Go version to 1.23
  * CI and quality of life changes not impacting package functionality:
    - Integrate repo with TiCS quality assessment
    - Switch documentation spellchecking to en-GB
    - Add text version of certificates tutorial
    - Additional code coverage through more testing
    - Improvements to the e2e test environment
  * Bump dependencies to latest:
    - jidicula/clang-format-action
    - github.com/charmbracelet/bubbles
    - github.com/charmbracelet/bubbletea
    - github.com/charmbracelet/glamour
    - github.com/charmbracelet/lipgloss
    - github.com/fatih/color
    - github.com/leonelquinteros/gotext
    - github.com/spf13/cobra
    - github.com/spf13/viper
    - golang.org/x/crypto
    - golang.org/x/net
    - golang.org/x/sync
    - golang.org/x/sys
    - golang.org/x/text
    - google.golang.org/grpc/cmd/protoc-gen-go-grpc
    - google.golang.org/grpc
    - google.golang.org/protobuf
    - github.com/golangci/golangci-lint

 -- Didier Roche-Tolomelli <email address hidden> Mon, 02 Sep 2024 14:05:22 +0200

[Łukasz Zemczak (sil2100)]

Hello Jean-Baptiste, or anyone else affected,

Accepted adsys into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/adsys/0.14.2~24.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Jean-Baptiste, or anyone else affected,

Accepted adsys into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/adsys/0.14.2~22.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Hasenack (ahasenack)]

Please follow the instructions from https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/2078246/comments/2 and only change the verification tags to done after successfully completing the test plan with the package in proposed for the affected ubuntu releases.

[Denison Barbosa (justdenis)]

I'm sorry for not commenting about the executed test plan. Let's fix this!

The test plan was executed for Jammy (22.04) and I confirm it was successful. The package version used for the tests is the one proposed, as can be seen by the output of apt-cache policy:
adsys:
  Installed: 0.14.2~22.04
  Candidate: 0.14.2~22.04
  Version table:
 *** 0.14.2~22.04 500
        500 http://archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages

The following steps were executed:

1) Create a fresh VM with Ubuntu 22.04;
2) Join an active directory domain (created for test purposes);
3) Edit the SSSD configuration file (/etc/sssd/sssd.conf), ensure that the domain string under "domains" in the SSSD section and that the domain-related section have mismatched casing (e.g. domains=domain.com and [domain/DOMAIN.COM]) and restart the SSSD service;
4) Install adsys;
5) Authenticate with an AD user that belongs to the domain;

After step 5, the user was authenticated and the domain-related settings were applied.

[Denison Barbosa (justdenis)]

The test plan was executed for Noble (24.04) and I confirm it was successful. The package version used for the tests is the one proposed, as can be seen by the output of apt-cache policy:
adsys:
  Installed: 0.14.2~24.04
  Candidate: 0.14.2~24.04
  Version table:
 *** 0.14.2~24.04 500
        500 http://archive.ubuntu.com/ubuntu noble-proposed/main amd64 Packages

The following steps were executed:

1) Create a fresh VM with Ubuntu 24.04;
2) Join an active directory domain (created for test purposes);
3) Edit the SSSD configuration file (/etc/sssd/sssd.conf), ensure that the domain string under "domains" in the SSSD section and that the domain-related section have mismatched casing (e.g. domains=domain.com and [domain/DOMAIN.COM]) and restart the SSSD service;
4) Install adsys;
5) Authenticate with an AD user that belongs to the domain;

After step 5, the user was authenticated and the domain-related settings were applied.

[Launchpad Janitor (janitor)]

This bug was fixed in the package adsys - 0.14.2~24.04

---------------
adsys (0.14.2~24.04) noble; urgency=medium

  * Fix DCONF policy manager removing user DB on empty policy (LP: #2078245)
  * Ignore casing in domain/ section of sssd.conf (LP: #2078246)
  * Fix parsing of slash usernames (i.e. domain\user) (LP: #2078247)
  * Fix errno in get_ticket_path() (LP: #2078473)

 -- Denison Barbosa <email address hidden> Fri, 30 Aug 2024 10:28:07 -0400

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for adsys has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package adsys - 0.14.2~22.04

---------------
adsys (0.14.2~22.04) jammy; urgency=medium

  * Fix DCONF policy manager removing user DB on empty policy (LP: #2078245)
  * Ignore casing in domain/ section of sssd.conf (LP: #2078246)
  * Fix parsing of slash usernames (i.e. domain\user) (LP: #2078247)
  * Fix errno in get_ticket_path() (LP: #2078473)

 -- Denison Barbosa <email address hidden> Fri, 30 Aug 2024 10:33:56 -0400