[SRU] Backport to 20.04 LTS

[Didier Roche-Tolomelli]

As part of our entreprise desktop offering, there is the request to backport ADSys to 20.04 LTS.
The package is in universe for now.

ADSys is our Active Directory GPO integration. It’s available starting Ubuntu 21.04.

[Impact]

 * ADSys is a new package. Impacts is thus only for people installing.
 * It depends on a recent Golang (1.16). We thus needs to backport this package from Ubuntu 21.04/21.10 (1.16.2-0ubuntu1 at the time of this writing) by introducing a versioned separate package (each Go version is a separate package already in the distribution). It is similar to what has been done for snaps in previous LTS.
 * This is a entreprise feature requested by desktop customers running LTS.

[Test Plan for Golang 1.16]

 1. Ensure Golang 1.16 is published in -proposed
 2. Start a build with a package, requiring Golang 1.16 (dependency + PATH set to Golang 1.16 go binary).
 3. Ensure the package builds successfully.
 4. Run go version <your binary> which should display: "go1.16.x" (x being the version uploaded).

[Test Plan for ADSys]

 1. Configure your machine with AD, with a correctly configured SSSD and KRB5 (AD user should be able to log in). Instructions can be found on https://github.com/ubuntu/adsys/wiki/2.-Prerequisites
 2. Install admx and adml files on your AD controller: https://github.com/ubuntu/adsys/wiki/3.-AD-Setup
 3. Configure some values in AD (https://github.com/ubuntu/adsys/wiki/4.-Using-GPO), for instance:
  * GDM login screen background
  * User favorites apps
 4. Install ADSys, reboot the machine and login in as an AD user
 5. Ensure both GDM background and user favorites apps follows what you set in AD

[Where problems could occur]

For Go 1.16:

 * Package depending on this Go version would not be able to compile.
 * As this is a separate, versionned, new package, no impact on existing ones.
 * FYI, we already built ADSys against this Go version in our ppa: https://launchpad.net/~didrocks/+archive/ubuntu/adsys

For ADSys:

 * Machine will fail booting if ADSys can’t connect to AD on first boot.
 * AD User will fail logging if ADSys can’t connect to AD on first boot.
 * As this is a separate, versionned, new package, no impact on existing installations.

[Other Info]

 * ADSys (built against Go 1.16 in the same PPA) is battle-tested from our PPA.
 * We will first upload Go 1.16 and let it migrate before uploading ADSys itself.
 * Of course, ADSys new version (the one we will backport) will be first uploaded in Impish.

[Łukasz Zemczak (sil2100)]

Hello Didier, or anyone else affected,

Accepted golang-1.16 into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-1.16/1.16.2-0ubuntu1~20.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Jean-Baptiste Lallement (jibel)]

I've installed golang-1.16 from proposed and successfully performed a build of adsys and of a simple sample source code. The "go version" command returned 1.16.2 on both.

Marking as verification done.

[Launchpad Janitor (janitor)]

This bug was fixed in the package golang-1.16 - 1.16.2-0ubuntu1~20.04

---------------
golang-1.16 (1.16.2-0ubuntu1~20.04) focal; urgency=medium

  * Backport to focal (LP: #1929038)

 -- Didier Roche <email address hidden> Mon, 10 May 2021 13:41:08 +0200

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for golang-1.16 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Łukasz Zemczak (sil2100)]

I assume this is blocked due to LP: #1936907 (probably not to have to backport it twice in case changes are needed). I'm thinking if maybe we could get this uploaded to focal already and keep it in -proposed in the meantime while the MIR is still in progress?

[Didier Roche-Tolomelli (didrocks)]

Thanks Łukasz! This is now in focal NEW. I think this could be accepted, migrate to update even and then, we can think about promoting it to main once #1936907 is approved. What do you think?

[Łukasz Zemczak (sil2100)]

Hello Didier, or anyone else affected,

Accepted adsys into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/adsys/0.8~22.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Thank you! Accepted into focal-proposed. I think your proposition makes sense! Also, the bug description mentions updating adsys in impish as well - could someone prepare the SRU for that series and upload? It's not as important, but I think we should still not leave out impish users.

[Didier Roche-Tolomelli (didrocks)]

Hey Łukasz! Thanks for accepting it!
impish has a version of adsys. This is an entreprise feature and I doubt we have users there, as by default, this is hilighted for LTSes only. Functionality-wise, as there is no ubuntu-advantage-desktop-daemon, this is equivalent to the version already present there (apart from one bug fix).

We can prepare the SRU if you feel this is a deal-breaker, but I think this is more for paperwork than having a real rationale. What’s your opinion on this?

[Łukasz Zemczak (sil2100)]

Thanks for the explaination. I think in this case we can conditionally skip it (since we don't encourage LTS-to-non-LTS upgrades anyway), but please keep an eye out for any requests for having this update in impish.

[Brian Murray (brian-murray)]

The fix for this bug has been awaiting testing feedback in the -proposed repository for focal for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

[Jean-Baptiste Lallement (jibel)]

This has been verified a while ago and already deployed in production for customers.
Marking as verification-done.

[Brian Murray (brian-murray)]

The version of adsys in -proposed for Focal (Ubuntu 20.04) failed to build from source for RISCV64. Since this isn't a regression it isn't necessarily a blocker but I'd like confirmation from the uploaders that they don't need / want it on riscv64.

[Jean-Baptiste Lallement (jibel)]

It's a desktop package that we do not need on riscv64

[Launchpad Janitor (janitor)]

This bug was fixed in the package adsys - 0.8~22.04

---------------
adsys (0.8~22.04) focal; urgency=medium

  * Backport to focal: (LP: #1929038)
    - Build with Go 1.16
    - Move debhelper compat to 12
    - Do not recommends ubuntu-advantage-desktop-daemon as it’s not available
      on focal yet.

 -- Didier Roche <email address hidden> Mon, 07 Feb 2022 17:18:20 +0100