History shown in Empathy chat window should be different from new messages

[Nicolò Chieffo]

Binary package hint: adium-theme-ubuntu

The history messages are currently too similar to normal messages.

[Nicolò Chieffo (yelo3)]

I thought of 2 changes:
1) first of all change the context color to gray (I think gray is something that reminds history)
2) then we could use an icon (similar to "document-open-recent") next to the timestamp, or the nickname (this involves a change in Context.html and NextContext.html in both Incoming and Outgoing folders)

Have a look at the attached debdiff.
NOTE: it requires a new icon (history.png) in the Resources directory

[Nicolò Chieffo (yelo3)]

I've got a better patch with text color back to normal, but opacity set to 50% (instead of 80 which is almost indistinguishable from 100%).
Can someone tell me how to attach a .png icon to the diff?

[Nicolò Chieffo (yelo3)]

I used uuencode, I don't know if it's correct or not, but nevermind.

[Nicolò Chieffo (yelo3)]

Well, maybe the history messages should have %time% replaced in a more complex way, also including the date.

[Nicolò Chieffo (yelo3)]

This patch adds the date to the timestamp

[Omer Akram (om26er)]

will this patch also do the job for bug 566473 ?

[Nicolò Chieffo (yelo3)]

Actually yes, I filed the bug 2 times, sorry.
Anyway this patch is more complete than the other!

[Omer Akram (om26er)]

the patch should not contain debian/changelog stuff I think.

[Nicolò Chieffo (yelo3)]

You are right. The debdiff tool also generates it, but you have to
manually change it using your informations

[Nicolò Chieffo (yelo3)]

I'm going to change the patch because it contains an error

[Nicolò Chieffo (yelo3)]

I splitted the patches and removed the date (which is now in a different bug, since it's a different issue)

[Nicolò Chieffo (yelo3)]

Of course this does not contain the icon itself, which can be copied from the ubuntu theme

[Sense Egbert Hofstede (sense)]

Thank you for helping with making Ubuntu better by reporting this bug.

I'm confirming this bug and am accepting it as a paper cut since it is an issue that could confuse users when chatting.

[iTorrey (rice)]

Confirmed. Making the opacity 0.5 rather than 0.8 looks very nice.

[Nicolò Chieffo (yelo3)]

And what about the "history" icon?

[Vish (vish)]

Nicolo , what is the icon size?

[Nicolò Chieffo (yelo3)]

I think the 24px version of document-open-recent from the humanity theme

[Ken VanDine (ken-vandine)]

I added the icon in the Resources directory, but I am not seeing the icon. Can you attach a screenshot to make sure I understand where/what it should render?

[Nicolò Chieffo (yelo3)]

I'm very sorry, I forgot to say that you should rename it as
"history.png" and locate it in the Resources directory (as you've
already done)
Now I'm not in my PC so I can't attache the screenshot

[Vish (vish)]

@Nicolò Chieffo : whats up with this bug? can we get a screenshot, so Ken can make an upload with the right placement?

[Nicolò Chieffo (yelo3)]

I'm very very sorry, I completely forgot this bug.

Here's 2 screenshots with history_icon.patch and the file
/usr/share/adium/message-styles/ubuntu.AdiumMessageStyle/Contents/Resources/history.png
the first one is the 22x22 actions/document-open-recent image
(converted to png) from the humanity theme, the second one uses the
16x16 icon from gnome theme, because humanity does not have 16x16
document-open-recent.

What about the patch history_more_transparent.patch? Do you think it's
worth to apply it?

[Vish (vish)]

Nicolo , that seems too overloaded! Why an icon in every bubble?

Lets just reduce the opacity of the history and be done with it. ;-)

[Nicolò Chieffo (yelo3)]

as you like. Can the opacity patch be committed?

On Mon, Aug 9, 2010 at 4:40 PM, Vish <email address hidden> wrote:
> Nicolo , that seems too overloaded! Why an icon in every bubble?
>
> Lets just reduce the opacity of the history and be done with it. ;-)
>
> --
> History shown in Empathy chat window should be different from new messages
> https://bugs.launchpad.net/bugs/531811
> You received this bug notification because you are a direct subscriber
> of the bug.
>

[Vish (vish)]

Nicolò Chieffo, Ken will upload your patch soon.

[Launchpad Janitor (janitor)]

This bug was fixed in the package adium-theme-ubuntu - 0.3-0ubuntu1

---------------
adium-theme-ubuntu (0.3-0ubuntu1) maverick; urgency=low

  * New upstream release.
    - History shown in Empathy chat window should be different
      from new messages (LP: #531811)
    - In chat rooms, empathy should not scroll to the bottom whenever
      a new message is received. (LP: #542806)
    - Merged patch from Omer Akram, we shouldn't hard code font
      sizes (LP: #531835)
  * debian/control
    - Set Vcs-Bzr
  * debian/copyright
    - Dropped reference to the deprecated BSD license file, the contents are
      included in the copyright file
 -- Ken VanDine <email address hidden> Wed, 11 Aug 2010 19:04:05 -0400