Ubuntu
address-book-app package

[Dialer and Messaging] should be able to edit a contact without switching to address book

Bug #1456782 reported by Bill Filler on 2015-05-19

This bug affects 2 people

	Status	Importance	Assigned to	Milestone
Canonical System Image	Fix Released	High	Bill Filler	Canonical System Image ww28-2015 "ota5"
Ubuntu UX	Fix Released	High	Olga Kemmet
address-book-app (Ubuntu)	Fix Released	High	Unassigned
Vivid	Confirmed	Undecided	Unassigned
dialer-app (Ubuntu)	Fix Released	High	Unassigned
Vivid	Confirmed	Undecided	Unassigned
messaging-app (Ubuntu)	Fix Released	High	Unassigned
Vivid	Confirmed	Undecided	Unassigned

Bug Description

per design, users of dialer and messaging-app should be able to open a contact directly from within those apps and edit it. Currently it launches address book app and then the user's context is switched.

Desired behavior:
Dialer app:
- from dialer screen click the contacts icon on header
- contact list should be shown in the dialer app
- click on contact to open it
- should be able to edit contact from that screen and interact without switching to address book app

Messaging app:
- create new message
- click contacts icon on header
- contact list should be shown in the messaaging app
- can edit or interact without switching to address book app

Related branches

lp:~renatofilho/dialer-app/addressbook-components

Merged into lp:dialer-app at revision 410

Ricardo Salveti (community): Approve (packaging) on 2015-06-04

PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-05-15

Gustavo Pichorim Boiko (community): Approve on 2015-05-14

lp:~renatofilho/messaging-app/messaging-addressbook

Merged into lp:messaging-app at revision 372

Ricardo Salveti (community): Approve (packaging) on 2015-06-04

PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-05-18

Gustavo Pichorim Boiko (community): Approve on 2015-05-14

lp:~renatofilho/address-book-app/split-app

Merged into lp:address-book-app at revision 436

Ricardo Salveti (community): Approve (packaging) on 2015-06-04

Sebastien Bacher: Needs Fixing on 2015-05-29

Gustavo Pichorim Boiko (community): Approve on 2015-05-14

PS Jenkins bot: Approve (continuous-integration) on 2015-05-14

Diff: 8831 lines (+3920/-3613)

134 files modified

CMakeLists.txt (+1/-0)
debian/control (+13/-2)
debian/qtdeclarative5-ubuntu-addressbook0.1.install (+4/-0)
src/app/CMakeLists.txt (+0/-2)
src/app/addressbookapp.cpp (+1/-24)
src/app/addressbookapp.h (+1/-2)
src/app/main.cpp (+1/-1)
src/imports/ABContactEditorPage.qml (+56/-0)
src/imports/ABContactListPage.qml (+530/-0)
src/imports/ABContactViewPage.qml (+87/-0)
src/imports/CMakeLists.txt (+3/-5)
src/imports/Common/CMakeLists.txt (+0/-15)
src/imports/Common/ContactDetailItem.qml (+0/-62)
src/imports/Common/ContactExporter.qml (+0/-167)
src/imports/Common/KeyboardRectangle.qml (+0/-74)
src/imports/Common/RemoveContactsDialog.qml (+0/-78)
src/imports/Common/StandardAnimation.qml (+0/-22)
src/imports/ContactEdit/ContactEditor.qml (+0/-461)
src/imports/ContactList/CMakeLists.txt (+0/-11)
src/imports/ContactList/ContactListPage.qml (+0/-554)
src/imports/ContactList/VCardImportDialog.qml (+0/-94)
src/imports/ContactShare/CMakeLists.txt (+0/-10)
src/imports/ContactShare/ContactSharePage.qml (+0/-56)
src/imports/ContactView/ContactView.qml (+0/-123)
src/imports/ContentHubProxy.qml (+1/-1)
src/imports/MainWindow.qml (+1/-2)
src/imports/Ubuntu/AddressBook/Base/CMakeLists.txt (+30/-0)
src/imports/Ubuntu/AddressBook/Base/ContactDetailBase.qml (+112/-0)
src/imports/Ubuntu/AddressBook/Base/ContactDetailGroupBase.qml (+159/-0)
src/imports/Ubuntu/AddressBook/Base/ContactDetailGroupWithTypeBase.qml (+132/-0)
src/imports/Ubuntu/AddressBook/Base/ContactDetailItem.qml (+62/-0)
src/imports/Ubuntu/AddressBook/Base/ContactExporter.qml (+167/-0)
src/imports/Ubuntu/AddressBook/Base/KeyboardRectangle.qml (+70/-0)
src/imports/Ubuntu/AddressBook/Base/RemoveContactsDialog.qml (+78/-0)
src/imports/Ubuntu/AddressBook/Base/qmldir (+9/-0)
src/imports/Ubuntu/AddressBook/CMakeLists.txt (+4/-0)
src/imports/Ubuntu/AddressBook/ContactEditor/CMakeLists.txt (+20/-7)
src/imports/Ubuntu/AddressBook/ContactEditor/ComboButtonAddField.qml (+5/-5)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailAddressesEditor.qml (+7/-7)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailAvatarEditor.qml (+7/-1)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailEmailsEditor.qml (+3/-3)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailGroupWithTypeEditor.qml (+3/-1)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailNameEditor.qml (+4/-3)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailOnlineAccountsEditor.qml (+3/-3)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailOrganizationsEditor.qml (+5/-5)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailPhoneNumbersEditor.qml (+3/-3)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailSyncTargetEditor.qml (+4/-2)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailWithTypeEditor.qml (+3/-1)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditorPage.qml (+444/-0)
src/imports/Ubuntu/AddressBook/ContactEditor/TextInputDetail.qml (+2/-2)
src/imports/Ubuntu/AddressBook/ContactEditor/ValueSelector.qml (+1/-1)
src/imports/Ubuntu/AddressBook/ContactEditor/qmldir (+18/-0)
src/imports/Ubuntu/AddressBook/ContactShare/CMakeLists.txt (+26/-0)
src/imports/Ubuntu/AddressBook/ContactShare/ContactSharePage.qml (+60/-0)
src/imports/Ubuntu/AddressBook/ContactShare/qmldir (+3/-0)
src/imports/Ubuntu/AddressBook/ContactView/ActionButton.qml (+34/-0)
src/imports/Ubuntu/AddressBook/ContactView/BasicFieldView.qml (+85/-0)
src/imports/Ubuntu/AddressBook/ContactView/CMakeLists.txt (+32/-7)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailAddressesView.qml (+32/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailAvatarView.qml (+89/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailEmailsView.qml (+29/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailGroupWithTypeView.qml (+66/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailNameView.qml (+2/-2)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailOnlineAccountsView.qml (+31/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailOrganizationsView.qml (+32/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailPhoneNumberView.qml (+94/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailPhoneNumbersView.qml (+41/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailSyncTargetView.qml (+1/-1)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailWithTypeView.qml (+62/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactFetchError.qml (+5/-8)
src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml (+198/-0)
src/imports/Ubuntu/AddressBook/ContactView/qmldir (+19/-0)
src/imports/Ubuntu/CMakeLists.txt (+3/-1)
src/imports/Ubuntu/Contacts/ActionButton.qml (+1/-1)
src/imports/Ubuntu/Contacts/BasicFieldView.qml (+0/-85)
src/imports/Ubuntu/Contacts/CMakeLists.txt (+4/-18)
src/imports/Ubuntu/Contacts/ContactDelegate.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactDetailAddressesView.qml (+0/-32)
src/imports/Ubuntu/Contacts/ContactDetailAvatarView.qml (+0/-86)
src/imports/Ubuntu/Contacts/ContactDetailBase.qml (+0/-110)
src/imports/Ubuntu/Contacts/ContactDetailEmailsView.qml (+0/-29)
src/imports/Ubuntu/Contacts/ContactDetailGroupBase.qml (+0/-159)
src/imports/Ubuntu/Contacts/ContactDetailGroupWithTypeBase.qml (+0/-126)
src/imports/Ubuntu/Contacts/ContactDetailGroupWithTypeView.qml (+0/-63)
src/imports/Ubuntu/Contacts/ContactDetailOnlineAccountTypeModel.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactDetailOnlineAccountsView.qml (+0/-29)
src/imports/Ubuntu/Contacts/ContactDetailOrganizationsView.qml (+0/-32)
src/imports/Ubuntu/Contacts/ContactDetailPhoneNumberTypeModel.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactDetailPhoneNumberView.qml (+0/-90)
src/imports/Ubuntu/Contacts/ContactDetailPhoneNumbersView.qml (+0/-38)
src/imports/Ubuntu/Contacts/ContactDetailPickerPhoneNumberDelegate.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactDetailWithTypeView.qml (+0/-60)
src/imports/Ubuntu/Contacts/ContactFetch.qml (+2/-2)
src/imports/Ubuntu/Contacts/ContactList.js (+1/-1)
src/imports/Ubuntu/Contacts/ContactListModel.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactListView.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactPreviewPage.qml (+0/-131)
src/imports/Ubuntu/Contacts/ContactSimpleListView.qml (+1/-1)
src/imports/Ubuntu/Contacts/Contacts.js (+24/-0)
src/imports/Ubuntu/Contacts/MostCalledModel.qml (+4/-3)
src/imports/Ubuntu/Contacts/MultipleSelectionVisualModel.qml (+1/-1)
src/imports/Ubuntu/Contacts/contacts.cpp (+25/-0)
src/imports/Ubuntu/Contacts/contacts.h (+2/-1)
src/imports/Ubuntu/Contacts/imagescalethread.cpp (+1/-1)
src/imports/Ubuntu/Contacts/imagescalethread.h (+1/-1)
src/imports/Ubuntu/Contacts/mostcalledproxymodel.cpp (+1/-1)
src/imports/Ubuntu/Contacts/mostcalledproxymodel.h (+1/-1)
src/imports/Ubuntu/Contacts/plugin.cpp (+1/-1)
src/imports/Ubuntu/Contacts/plugin.h (+1/-1)
src/imports/Ubuntu/Contacts/qmldir (+1/-16)
src/imports/VCardImportDialog.qml (+94/-0)
tests/autopilot/address_book_app/__init__.py (+6/-5)
tests/autopilot/address_book_app/address_book/__init__.py (+34/-0)
tests/autopilot/address_book_app/address_book/_common.py (+52/-0)
tests/autopilot/address_book_app/address_book/_contact_editor_page.py (+303/-0)
tests/autopilot/address_book_app/address_book/_contact_view_page.py (+28/-0)
tests/autopilot/address_book_app/address_book/_remove_contact_dialog.py (+36/-0)
tests/autopilot/address_book_app/address_book/_sim_card_import_page.py (+101/-0)
tests/autopilot/address_book_app/pages/__init__.py (+7/-8)
tests/autopilot/address_book_app/pages/_ab_contact_list_page.py (+142/-0)
tests/autopilot/address_book_app/pages/_ab_contact_view_page.py (+28/-0)
tests/autopilot/address_book_app/pages/_common.py (+0/-52)
tests/autopilot/address_book_app/pages/_contact_editor.py (+0/-299)
tests/autopilot/address_book_app/pages/_contact_list_page.py (+0/-152)
tests/autopilot/address_book_app/pages/_contact_view.py (+0/-28)
tests/autopilot/address_book_app/pages/_sim_card_import_page.py (+0/-103)
tests/autopilot/address_book_app/tests/test_add_contact.py (+2/-2)
tests/autopilot/address_book_app/tests/test_custom_proxy_objects.py (+2/-1)
tests/autopilot/address_book_app/tests/test_data.py (+1/-1)
tests/autopilot/address_book_app/tests/test_edit_contact.py (+1/-1)
tests/qml/tst_ContactEditor.qml (+2/-2)
tests/qml/tst_ContactList.qml (+2/-2)
tests/qml/tst_ContactListView.qml (+0/-1)
tests/qml/tst_ContactPreviewPage.qml (+3/-1)

Bill Filler (bfiller) on 2015-05-19

Changed in canonical-devices-system-image:
milestone:	none → ww22-2015
assignee:	nobody → Bill Filler (bfiller)
importance:	Undecided → High
status:	New → Confirmed
Changed in address-book-app (Ubuntu):
importance:	Undecided → High
Changed in dialer-app (Ubuntu):
importance:	Undecided → High
Changed in messaging-app (Ubuntu):
importance:	Undecided → High
Changed in address-book-app (Ubuntu):
status:	New → In Progress
Changed in dialer-app (Ubuntu):
status:	New → In Progress
Changed in messaging-app (Ubuntu):
status:	New → In Progress
Changed in canonical-devices-system-image:
status:	Confirmed → In Progress

Magdalena Mirowicz (magdalena-mirowicz) on 2015-05-21

summary:	- should be able to edit a contact without switching to address book + [Dialler and Messaging] should be able to edit a contact without + switching to address book
Changed in ubuntu-ux:
importance:	Undecided → High
status:	New → Triaged
assignee:	nobody → Olga Kemmet (olga-kemmet)

Sebastien Bacher (seb128) on 2015-05-21

summary:

- [Dialler and Messaging] should be able to edit a contact without
+ [Dialer and Messaging] should be able to edit a contact without
switching to address book

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-05-26:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in address-book-app (Ubuntu Vivid):
status:	New → Confirmed
Changed in dialer-app (Ubuntu Vivid):
status:	New → Confirmed
Changed in messaging-app (Ubuntu Vivid):
status:	New → Confirmed

Pat McGowan (pat-mcgowan) on 2015-06-02

Changed in canonical-devices-system-image:
milestone:	ww22-2015 → ww24-2015

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-06-04:

This bug was fixed in the package address-book-app - 0.2+15.10.20150601.2-0ubuntu1

---------------
address-book-app (0.2+15.10.20150601.2-0ubuntu1) wily; urgency=medium

[ Gustavo Pichorim Boiko ]
* Fix loading the settings page

  [ Renato Araujo Oliveira Filho ]
  * Add 'mailto' url call when clicking on e-mail field. (LP: #1378345)
  * Does not expand contact item when clicked. (LP: #1368671)
  * Split the app in modules to be used by dialer and messaging app.
    (LP: #1456782)
  * Updated autopilot test: (LP: #1444115)

-- CI Train Bot <email address hidden> Mon, 01 Jun 2015 22:14:02 +0000

Changed in address-book-app (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-06-04:

This bug was fixed in the package dialer-app - 0.1+15.10.20150601.1-0ubuntu1

---------------
dialer-app (0.1+15.10.20150601.1-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
* Resync trunk.

[ Gustavo Pichorim Boiko ]
* Fix contact share.

  [ Renato Araujo Oliveira Filho ]
  * Implement support for no-expandable contacts list (LP: #1368671)
  * Make use of the new address book components instead of launch the
    address-book-app. (LP: #1456782)

[ Sebastien Bacher ]
* Update the translations template so new strings can be translated

-- CI Train Bot <email address hidden> Mon, 01 Jun 2015 20:14:38 +0000

Changed in dialer-app (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-06-04:

This bug was fixed in the package messaging-app - 0.1+15.10.20150601.1-0ubuntu1

---------------
messaging-app (0.1+15.10.20150601.1-0ubuntu1) wily; urgency=medium

[ Gustavo Pichorim Boiko ]
* Fix contact share.

  [ Renato Araujo Oliveira Filho ]
  * Implement address book interaction using the address book library
    instead of calling the app. (LP: #1456782)
  * Removed contact expansion. (LP: #1368671)

[ Sebastien Bacher ]
* Update the translations template so new strings can be translated

-- CI Train Bot <email address hidden> Mon, 01 Jun 2015 20:15:14 +0000

Changed in messaging-app (Ubuntu):
status:	In Progress → Fix Released

Olga Kemmet (olga-kemmet) on 2015-06-12

Changed in ubuntu-ux:
status:	Triaged → Fix Released

Pat McGowan (pat-mcgowan) on 2015-07-07

Changed in canonical-devices-system-image:
status:	In Progress → Fix Released
milestone:	ww24-2015 → ww28-2015

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntuaddress-book-app package

[Dialer and Messaging] should be able to edit a contact without switching to address book

Bug Description

Related branches

Other bug subscribers

Remote bug watches

Ubuntu
address-book-app package