privacy settings: remove history datetimepicker not working

Bug #1303508 reported by Vincent Thiele on 2014-04-06
26
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Activity Log Manager
Medium
Unassigned
activity-log-manager (Ubuntu)
Medium
Unassigned
Trusty
Medium
Unassigned
Xenial
Medium
Unassigned
Yakkety
Medium
Unassigned

Bug Description

[Impact]
User is unable to use calendar widgets when clearing history - they do not respond to mouse clicks.

[Test Case]
1. Open System Settings.
2. Select "Security & Privacy"
3. Select "Files & Applications" tab
4. Select "Clear Usage Data..."
5. Click dropdown beside one of the date widgets

Expected result:
A calendar is shown and a date can be selected.

Observed result:
The calendar is shown, but is greyed out and doesn't respond to clicks. The calendar doesn't disappear until System Settings is closed.

[Regression Potential]
Low. Fix makes widgets work correctly with modal dialogs. Regressions are likely to be contained to these widgets which are not working correctly currently.

Related branches

Vincent Thiele (vincentthiele) wrote :
Changed in unity-control-center (Ubuntu):
status: New → Triaged
importance: Undecided → High
tags: added: ubuntu-desktop-trusty
Robert Ancell (robert-ancell) wrote :

The panel is provided by activity-log-manager

affects: unity-control-center (Ubuntu) → activity-log-manager (Ubuntu)
Changed in activity-log-manager (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Robert Ancell (robert-ancell)
Robert Ancell (robert-ancell) wrote :

The problem seems to be that the custom calendar widget doesn't correctly do input grabs and this means it doesn't get input when the dialog is modal. If the dialog is set to non-modal it works fine but the dialog can remain even once the panel is closed.

I've been trying to make the calendar widget work correctly by copying GtkComboBox and GtkPopover but haven't got it to work.

Vincent Thiele (vincentthiele) wrote :

Any updates? How about removing calendar widget an allowing manual input via textbox?

tags: removed: saucy ubuntu-desktop-trusty
tags: added: vivid
tags: added: wily
Vincent Thiele (vincentthiele) wrote :

Issue is still there on xenial...

tags: added: xenial
Vincent Thiele (vincentthiele) wrote :

I've attached a patch, which I tested on ubuntu 14.04. Please review and add!

The attachment "activity-log-manager.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch

I confirm that the issue affects Ubuntu 16.04. Dear Ubuntu maintainers, please review the patch above.

Changed in activity-log-manager (Ubuntu):
importance: High → Medium
Łukasz Zemczak (sil2100) wrote :

Hello! I would first like someone with proper activity-log-manager experience to review the change before sponsoring - Robert, could you maybe check the patch on comment #6 ? Also, could we get this change proposed as a merge-request against lp:activity-log-manager ? This way we'll be sure this doesn't get lost upstream and will give us proper options to get the change reviewed before release.

Robert Ancell (robert-ancell) wrote :

Thanks Vincent for the work!

This patch contained three fixes:
1. Fix the calendars not being selectable.
2. Fix the location of the warning label on invalid range.
3. Change the selection of a date from a double click to a single click.

I've pushed changes for the first two to lp:activity-log-manager. The change from a double click to a single click is a matter of opinion that is probably better tracked in a separate bug (the whole dialog could do with some UI love).

Changed in activity-log-manager:
status: New → Fix Committed
description: updated
Changed in activity-log-manager (Ubuntu):
status: In Progress → Fix Committed
Changed in activity-log-manager (Ubuntu Trusty):
status: New → Fix Committed
Changed in activity-log-manager (Ubuntu Xenial):
status: New → Fix Committed
Changed in activity-log-manager (Ubuntu Yakkety):
status: New → Fix Committed
importance: Undecided → Medium
Changed in activity-log-manager (Ubuntu Xenial):
importance: Undecided → Medium
Changed in activity-log-manager (Ubuntu Trusty):
importance: Undecided → Medium
Changed in activity-log-manager:
importance: Undecided → Medium
Changed in activity-log-manager (Ubuntu):
assignee: Robert Ancell (robert-ancell) → nobody
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package activity-log-manager - 0.9.7-0ubuntu25

---------------
activity-log-manager (0.9.7-0ubuntu25) zesty; urgency=medium

  * debian/patches/21_clear_history_calendars.patch:
    - Fix calendars not working when selecting date range to clear
      (LP: #1303508)

 -- Robert Ancell <email address hidden> Fri, 24 Mar 2017 10:56:02 +1300

Changed in activity-log-manager (Ubuntu):
status: Fix Committed → Fix Released
Łukasz Zemczak (sil2100) wrote :

Hello Robert! Thanks for reviewing the patches! I'll be accepting your SRU uploads for this change but with a small difference - I'll be changing the versioning a bit as I prefer the usual .1/.16.10.1 scheme instead. No worries, I'll handle this on my side.

Hello Vincent, or anyone else affected,

Accepted activity-log-manager into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/activity-log-manager/0.9.7-0ubuntu23.16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Łukasz Zemczak (sil2100) wrote :

Hello Vincent, or anyone else affected,

Accepted activity-log-manager into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/activity-log-manager/0.9.7-0ubuntu23.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Łukasz Zemczak (sil2100) wrote :

Hello Vincent, or anyone else affected,

Accepted activity-log-manager into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/activity-log-manager/0.9.7-0ubuntu14.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments