acpid's script "lid.sh" should *source* lid.sh.pre and lid.sh.post

Bug #902473 reported by Riccardo Murri
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
acpid (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

As of acpid 1:2.0.10-1ubuntu2.3, the support script "/etc/acpi/lid.sh" allows users to define hooks "/etc/acpi/local/lid.sh.pre" and "lid.sh.post".

However, these hooks are executed as shell commands, instead of being sourced by the current shell. Thus, the environment and the ACPI functions is lost in the hook scripts, and one must set it up again.

Sourcing the hook scripts makes them more useful.

Trivial patch attached.

Revision history for this message
Riccardo Murri (rmurri) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "source lid.sh.{pre,post} from lid.sh (patch against acpid 1:2.0.10-1ubuntu2.3)" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in acpid (Ubuntu):
status: New → Confirmed
Revision history for this message
dino99 (9d9) wrote :

This version has expired long ago

Changed in acpid (Ubuntu):
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.