regression in /etc/acpi/powerbtn.sh causes it to fail entirely on Ubuntu servers

Bug #570450 reported by Dustin Kirkland 
86
This bug affects 22 people
Affects Status Importance Assigned to Milestone
acpid (Ubuntu)
High
roberta
Lucid
High
Dustin Kirkland 

Bug Description

Binary package hint: acpi

The last upload of acpid causes a problem on systems which do not have the acpi-support package installed:

acpid (1.0.10-5ubuntu2) lucid; urgency=low

  * Source /usr/share/acpi-support/power-funcs in powerbtn.sh (LP: #508073)

 -- Jonathan Thomas <email address hidden> Fri, 15 Jan 2010 19:59:47 -0500

The sourcing of the file happens unconditionally, and the acpid package does not depend on acpi-support, which provides that file.

This could be solved by adding acpi-support to acpid's depends, however, this isn't desirable because it pulls in several X related packages which we would not want on a server.

Instead, let's only source that file if it exists. If it doesn't, then there is a foolproof failure case handling at the bottom of that script.

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Trivial debdiff attached.

Proposing for Lucid. Might have to be in an SRU, if the release team decides against accepting this for Lucid release.

Changed in acpi (Ubuntu):
status: New → In Progress
importance: Undecided → High
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

With attachment this time.

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Ubuntu-release, what do you think?

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

<persia> kirkland: release team is reviewing each upload in the queue (using queuediff). You may as well upload and get feedback that way if you're definitely SRUing it anyway

Uploaded to queue.

Changed in acpi (Ubuntu Lucid):
status: In Progress → Fix Committed
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

<slangasek> kirkland: so, rejecting from the queue, this touches all images and is much too late for us to respin everything for anything short of dataloss or a zero-day security hole; please reupload to lucid-proposed, and please adjust the patch to not silently ignore, e.g., getXconsole not existing

Changed in acpi (Ubuntu Lucid):
milestone: none → lucid-updates
status: Fix Committed → In Progress
assignee: nobody → Dustin Kirkland (kirkland)
Revision history for this message
Martin Pitt (pitti) wrote :

SRU ack, please upload to lucid-proposed

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Done. Uploaded to lucid-proposed. Debdiff attached.

Changed in acpi (Ubuntu Lucid):
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted acpid into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Revision history for this message
Gerben (gerbgeus) wrote :

Hi,

Looks OK to me:

Added to /etc/apt/sources.list
deb http://nl.archive.ubuntu.com/ubuntu/ lucid-proposed restricted main multiverse universe
and performed
apt-get -t lucid-proposed update
apt-get -t lucid-proposed upgrade

It showed acpid as one of the upgrades.
The machine halts as expected.

Revision history for this message
Benjamin Kay (benkay) wrote :

Upgraded to acpid 1.0.10-5ubuntu2.1 from lucid-proposed. The power button on my x86_64 server now works.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Martin Pitt (pitti)
affects: acpi (Ubuntu) → acpid (Ubuntu)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package acpid - 1.0.10-5ubuntu2.1

---------------
acpid (1.0.10-5ubuntu2.1) lucid-proposed; urgency=low

  * debian/powerbtn.sh: ensure that /usr/share/acpi-support/power-funcs
    exists before sourcing it; note that acpid does not depend on
    acpi-support (which is fine, as it brings in lots of X dependencies
    not appropriate for servers); this fix will allow Ubuntu servers
    (especially those in VMs) to run acpid and catch and handle power
    button events again; LP: #570450
 -- Dustin Kirkland <email address hidden> Mon, 26 Apr 2010 17:25:02 -0500

Changed in acpid (Ubuntu Lucid):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Copied lucid-proposed to maverick.

Changed in acpid (Ubuntu):
status: Fix Committed → Fix Released
Changed in acpid (Ubuntu Lucid):
status: Fix Released → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package acpid - 1.0.10-5ubuntu2.1

---------------
acpid (1.0.10-5ubuntu2.1) lucid-proposed; urgency=low

  * debian/powerbtn.sh: ensure that /usr/share/acpi-support/power-funcs
    exists before sourcing it; note that acpid does not depend on
    acpi-support (which is fine, as it brings in lots of X dependencies
    not appropriate for servers); this fix will allow Ubuntu servers
    (especially those in VMs) to run acpid and catch and handle power
    button events again; LP: #570450
 -- Dustin Kirkland <email address hidden> Mon, 26 Apr 2010 17:25:02 -0500

Changed in acpid (Ubuntu Lucid):
status: Fix Committed → Fix Released
vetedson (vetedson)
Changed in acpid (Ubuntu):
status: Fix Released → Incomplete
status: Incomplete → In Progress
status: In Progress → Invalid
Martin Pitt (pitti)
Changed in acpid (Ubuntu):
status: Invalid → Fix Released
roberta (crowntowndiva)
Changed in acpid (Ubuntu):
assignee: Dustin Kirkland (kirkland) → roberta (crowntowndiva)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Patches