acpi-support should use ck-list-sessions to determine active X display and X user
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
acpi-support (Ubuntu) |
Fix Released
|
High
|
Steve Langasek | ||
Oneiric |
Fix Released
|
Undecided
|
Unassigned | ||
Precise |
Fix Released
|
High
|
Steve Langasek |
Bug Description
SRU Justificaiton
-----------------
Impact:
This bug impacts all Oneiric systems which use LightDM and are affected by lp870297 (Lightdm logins not being logged in wtmp).
In Oneiric, acpi-support depends on wtmp entries to determine the active console with getXconsole and getXuser. Since LightDM doesn't write to wtmp, this affects all systems that use acpi-support scripts to handle ACPI hotkey events -- including yet to be released hardware in the enablement/
Fix:
The fix is to backport the changes made in Precise to Oneiric. This includes implementing getXuser and getXconsole with ConsoleKit (ck-list-sessions).
Patch:
This change is already in acpi-support .139:
http://
I've attached a debdiff that backports that change to acpi-support .139 in Oneiric.
Regression Potential:
There should be very little potential for regression. In fact, this should fix machines affected by lp87029, including OEM systems.
This has been tested using the following PPA:
https:/
-------
The acpi-support scripts use 'ps' and 'who' output to determine the current active X display and X user (in getXconsole and getXuser). Currently, LightDM does not write to utmp so 'who' does not output the correct information breaking getXconsole and getXuser.
ConsoleKit properly maintains the state of the console and probably should be used instead.
I've attached a patch that re-implements getXconsole and getXuser by calling ck-list-sessions.
Changed in acpi-support (Ubuntu): | |
assignee: | nobody → Steve Langasek (vorlon) |
tags: | added: blocks-hwcert-enablement |
Changed in acpi-support (Ubuntu): | |
milestone: | none → oneiric-updates |
description: | updated |
tags: |
added: verification-done removed: verification-needed |
The attachment "power-funcs.diff" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.
[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]