asus-wireless-2.sh lacks of led support

Bug #207871 reported by Nicolò Chieffo
2
Affects Status Importance Assigned to Milestone
acpi-support (Ubuntu)
Medium
Unassigned

Bug Description

Binary package hint: acpi-support

asus-wireless-2.sh that was recently added, lacks of asus led support. this patch will enable it

Revision history for this message
Nicolò Chieffo (yelo3) wrote :
Revision history for this message
Daniel Hahler (blueyed) wrote :

This should be fixed already in my branch with another bunch of fixes:
it drops (events/)asus-wireless-2(.sh) again and uses asus-wireless-on and asus-wireless-off events instead, which call the previous asus-wireless.sh script, which still supports led.
Can you please test, if it works for you?

There either the branch or a package in my PPA, see my comment [1] on bug 204378.
[1]: https://bugs.edge.launchpad.net/ubuntu/+source/acpi-support/+bug/204378/comments/36

Changed in acpi-support:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Nicolò Chieffo (yelo3) wrote : Re: [Bug 207871] Re: asus-wireless-2.sh lacks of led support

I can't sorry. I don't have a laptop wich uses asus-wireless-2. I have
the old model which uses asus-wireless

Revision history for this message
Steve Langasek (vorlon) wrote :

The asus-wireless scripts are a right mess in acpi-support. asus-wireless-2 should never have been added, the events it matches on were *already* matched by asus-wireless-{on,off}. Yes, dropping this script again is the right fix.

Daniel, I tried to merge directly from your branch, but ran into this error:

$ bzr merge lp:~blueyed/acpi-support/cherry-pick
bzr: ERROR: Branches have no common ancestor, and no merge base revision was specified.
$

So I'll knock out asus-wireless-2 by hand here.

If you have other acpi-support fixes that you need merged, could you please rebase a branch against lp:~ubuntu-core-dev/acpi-support/trunk/ and submit merge proposals for them?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package acpi-support - 0.132

---------------
acpi-support (0.132) lucid; urgency=low

  * lib/state-funcs, start.d/60-asus-wireless-led.sh, asus-wireless.sh:
    eliminate setLEDAsusWireless altogether; this needs to be handled
    directly by the kernel when the kill switch is toggled, not in a racy
    and inconsistently-applied manner by acpi-support; and in at least some
    cases we know this already *does* happen because of reports that
    /sys/devices/platform/asus-laptop/wlan, used for toggling "the LED" with
    the current kernel module, is actually an interface for toggling *the
    antenna* that happens to also toggle the LED. Likewise, we should not
    be responsible for bringing up the antenna at boot, so get rid of the
    file in the start.d directory. LP: #293943, #204378, #334368.
  * Now that the last script is gone from start.d, kill off the directory
    and the init script handling too.
  * Remove the asus-wireless-2 event handler, which is completely redundant
    with the pre-existing asus-wireless-{off,on} handlers. LP: #207871.

  [ Erik Andrén ]
  * Add support for ATKD 00000037 to events/asus-touchpad.
    This makes the disable touchpad buttons (!) on the EeePc 1005HA work as
    intended. LP: #502720.
 -- Steve Langasek <email address hidden> Mon, 04 Jan 2010 15:52:56 -0800

Changed in acpi-support (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers