Comment 3 for bug 119052

Revision history for this message
Roland Dreier (roland.dreier) wrote :

I think the title of this bug is a little deceptive -- the thinkpad-acpi change is definitely causing a regression, since some of the things like bluetooth enable/disable that used to be available in feisty are not available in gutsy without manually loading the thinkpad-acpi module.

Anyway, I ran into this too on my X60s, and it took a little time to work out how ibm-acpi used to be loaded and why thinkpad-acpi isn't loaded any more. It turns out that the modules are loaded in /etc/init.d/acpid by the shell function load_modules(). That function essentially loads everything in /lib/modules/`uname -r`/kernel/drivers/acpi and /lib/modules/`uname -r`/kernel/ubuntu/acpi. However, thinkpad-acpi is under kernel/drivers/misc/ now (ever since the kernel change 3ede41c7, "ACPI: ibm-acpi: move driver to drivers/misc hierarchy", in 2.6.21).

It seems we probably need an explicit list of modules from drivers/misc to load in the acpi startup script. For example, msi-laptop and sony-laptop at least look useful in addition to thinkpad-acpi. But we definitely do *NOT* want to load all the modules from drivers/misc, since eg blink is a debugging only module that confuses some keyboard controllers. So I think the only solution for gutsy is just to list exactly which misc drivers should be loaded.

BTW there is a modalias of ibm-acpi for thinkpad-acpi, so modprobe ibm-acpi still works, although it is probably better in gutsy to use the real thinkpad-acpi name.