User Accounts reports wrong "Automatic Login" status when upgading from 12.04

Bug #1043349 reported by Albert Astals Cid on 2012-08-29
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
accountsservice (Ubuntu)
Undecided
Michael Terry
Quantal
Undecided
Michael Terry

Bug Description

[Impact]
A lightdm user in Ubuntu 12.10 and 13.04 will always see automatic login as turned off, even when it is currently enabled for that user. This does not affect the functioning of autologin itself, just whether it appears enabled or not. This may lead to user confusion, and is a regression from 12.04.

[Reproduction steps]
0) Be on Ubuntu 12.10
1) Go to System Settings -> Users
2) Unlock the pane
3) Toggle "Automatic login" on for a given user
4) Reboot
5) Go back to System Settings -> Users
6) Note the value of "Automatic login"

[Regression Potential]
Low. Only affects a code path that decides whether to check the gdm value or the lightdm value for autologin. Previously, a logic bug meant that we always checked the gdm value.

Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-control-center (Ubuntu):
status: New → Confirmed
Albert Astals Cid (aacid) wrote :

It's actually an accountsservice bug

Changed in gnome-control-center (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Albert Astals Cid (aacid)
status: In Progress → Invalid
Changed in accountsservice (Ubuntu):
status: New → In Progress
assignee: nobody → Albert Astals Cid (aacid)
Changed in gnome-control-center (Ubuntu):
assignee: Albert Astals Cid (aacid) → nobody
Albert Astals Cid (aacid) wrote :

Diff over the existing 0007-add-lightdm-support.patch

You can create almost any dbus proxy and it will be non null even if there is nothing there, that's why i added the check that there is an owner

Albert Astals Cid (aacid) wrote :

Whole new 0007-add-lightdm-support.patch (result of applying the patch in the previous comment to the existing 0007-add-lightdm-support.patch)

The attachment "DIFF" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Albert Astals Cid (aacid) wrote :

New partial diff, old one is wrong

Albert Astals Cid (aacid) wrote :

New full diff, the old one was wrong

Michael Terry (mterry) wrote :

Thanks, Albert! I'll assign to me for an SRU.

no longer affects: gnome-control-center (Ubuntu)
Changed in accountsservice (Ubuntu Quantal):
milestone: none → quantal-updates
assignee: Albert Astals Cid (aacid) → Michael Terry (mterry)
Michael Terry (mterry) wrote :

Got back to looking at this, and I'm confused. Albert, that patch is already in 12.10...

Michael Terry (mterry) wrote :

(Just want to be sure I'm grabbing the right diff). The latest one you said was the full diff is the same as what's in quantal. Can you upload the correct patch again?

Albert Astals Cid (aacid) wrote :

Sigh, patches of patches are a pain :-/

Albert Astals Cid (aacid) wrote :
Albert Astals Cid (aacid) wrote :

New patches attached, they should be the correct ones now, sorry for the mess :-/

Alistair Buxton (a-j-buxton) wrote :

This doesn't just affect upgrade installs. It affects completely fresh installs too. All you have to do is enable automatic login, restart the computer, and open User Accounts, and the setting is wrong.

Michael Terry (mterry) on 2013-01-22
description: updated
description: updated
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package accountsservice - 0.6.29-1ubuntu3

---------------
accountsservice (0.6.29-1ubuntu3) raring; urgency=low

  [ Albert Astals Cid ]
  * debian/patches/0007-add-lightdm-support.patch:
    - Fix reporting of autologin setting for users when using lightdm
      (LP: #1043349)
 -- Michael Terry <email address hidden> Tue, 22 Jan 2013 14:11:08 -0500

Changed in accountsservice (Ubuntu):
status: In Progress → Fix Released

Hello Albert, or anyone else affected,

Accepted accountsservice into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/accountsservice/0.6.21-6ubuntu5.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in accountsservice (Ubuntu Quantal):
status: In Progress → Fix Committed
tags: added: verification-needed
Sebastien Bacher (seb128) wrote :

confirmed, the status is the right one after the update

tags: added: verification-done
removed: verification-needed

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package accountsservice - 0.6.21-6ubuntu5.1

---------------
accountsservice (0.6.21-6ubuntu5.1) quantal-proposed; urgency=low

  [ Albert Astals Cid ]
  * debian/patches/0007-add-lightdm-support.patch:
    - Fix reporting of autologin setting for users when using lightdm
      (LP: #1043349)
 -- Michael Terry <email address hidden> Tue, 22 Jan 2013 15:02:52 -0500

Changed in accountsservice (Ubuntu Quantal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers