account-polld is writing Received Poll() periodically to the log

[Colin Ian King]

I was trying to figure out where excessive file system writes were coming from (to try to reduce flash writes and hence reduce power consumption) and I spotted that /home/phablet/.cache/upstart/account-polld.log is being written to periodically with a rather pointless message:

2014/10/01 14:59:12 Received Poll()
2014/10/01 15:04:17 Received Poll()
2014/10/01 15:09:22 Received Poll()
2014/10/01 15:14:27 Received Poll()

which is from:

func (p *PollBus) watchMethodCalls() {
        for msg := range p.msgChan {
                var reply *dbus.Message
                switch {
                case msg.Interface == busInterface && msg.Member == "Poll":
                        log.Println("Received Poll()")
                        p.PollChan <- true
                        reply = dbus.NewMethodReturnMessage(msg)
                default:
                        log.Println("Received unkown method call on", msg.Interface, msg.Member)
                        reply = dbus.NewErrorMessage(msg, "org.freedesktop.DBus.Error.UnknownMethod", "Unknown method")
                }
                if err := p.conn.Send(reply); err != nil {
                        log.Println("Could not send reply:", err)
                }
        }
}

Although it is nice to know it has received a Poll message, is this kind of logging a little excessive? (it's not like it is an error condition) We're trying to reduce power utilisation so unncessary file I/O to logs should be reduced where possible since writes to flash based file system logs every few minutes is a little wasteful.