[system settings] OAuth based plug-ins appear to crash under poor network connectivity

[dobey]

When going to the Accounts page of System Settings, and attempting to add a Google/Twitter/etc… OAuth based account on my Nexus 4, the plug-ins are appearing to crash, and I get sent back to the accounts list. This appears to be due to poor network connectivity, as I'm on wifi, but the AP is at the other end of my house, resulting in poor connection which often drops. If I move the phone close to the AP, the pages then load and do not seem to crash, as the connectivity is greatly improved.

Instead of crashing/exiting/whatever is happening, I think these plug-ins need to show an error or something, to tell the user something is wrong. Otherwise, it simply appears the software is very crashy.

<https://wiki.ubuntu.com/OnlineAccounts#phone-settings>: "If there is a networking or HTTP error in loading the page, or in submitting the form, the contents of the Web frame should be replaced by the text “This service is not available right now. Try again later.” and a “Try Again” button."

[David Barth (dbarth)]

Could be due to: https://bugs.launchpad.net/ubuntu/+source/signon/+bug/1349983

[dobey (dobey)]

Why was this changed to Incomplete status? No additional information has been asked for.

[David Barth (dbarth)]

hmm, right, NEW was fine actually. This bug and the other one are the same I'm pretty sure.

[David Barth (dbarth)]

Further to that issue, as which may be a separate issue, the account creation process sometimes fails just after the app approval step (ie you approve app Ubuntu to use your identity with provider Evernote say), and just before the account can be created in OA.

davmor2 recently experienced the issue from within the reminder-apps, and then separately from USS and creating an Evernote account. Logs and traces available.

[Alberto Mardegan (mardy)]

I also saw something weird, with the Evernote login page appearing for a fraction of a second and then the whole page turning completely white. After rebooting, the problem was gone. However, in that case we didn't get a network error from the webview, so I'm afraid there's nothing we can do in such a situation.

[David Barth (dbarth)]

@mardy: I think that loops to the need to have a clear error indication
when the account creation process fails, for various reasons, including
poor network connectivity.

On Thu, Sep 25, 2014 at 7:36 PM, Jean-Baptiste Lallement <
<email address hidden>> wrote:

> ** Tags added: beta qa-daily-testing
>
> --
> You received this bug notification because you are a member of Ubuntu
> Online Accounts, which is subscribed to Online Accounts: Account
> plugins.
> https://bugs.launchpad.net/bugs/1349975
>
> Title:
> OAuth based plug-ins appear to crash under poor network connectivity
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/account-plugins/+bug/1349975/+subscriptions
>

[Alberto Mardegan (mardy)]

Adding ubuntu-ux, as we need input from design about whether we need to show an error message in such cases.

[David Barth (dbarth)]

Meanwhile, can you try to reproduce the issue by stopping the network,
using cellular data only, or switching to a misconfigured wifi network to
simulate the conditons?

On Tue, Oct 7, 2014 at 3:17 PM, Alberto Mardegan <<email address hidden>
> wrote:

> Adding ubuntu-ux, as we need input from design about whether we need to
> show an error message in such cases.
>
> ** Also affects: ubuntu-ux
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are a member of Ubuntu
> Online Accounts, which is subscribed to Online Accounts: Account
> plugins.
> https://bugs.launchpad.net/bugs/1349975
>
> Title:
> OAuth based plug-ins appear to crash under poor network connectivity
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/account-plugins/+bug/1349975/+subscriptions
>

[Dave Morley (davmor2)]

This seems to effect oauth in evernote and fitbit which both seem to be oauth1.0a

[Selene ToyKeeper (toykeeper)]

FWIW, even though dbarth's silo rtm-003 today lists this bug as something it fixes, it doesn't. Doesn't look like the silo even attempted to do so. Will need another landing for that.

[David Barth (dbarth)]

@Selene: correct, the other branch helped in case of poor network connectivity, but the real fix for that crash will be not to crash...

[Matthew Paul Thomas (mpt)]

Specification updated. <https://wiki.ubuntu.com/OnlineAccounts?action=diff&rev2=23&rev1=22>

[Launchpad Janitor (janitor)]

This bug was fixed in the package signon-plugin-oauth2 - 0.23+16.04.20151028-0ubuntu1

---------------
signon-plugin-oauth2 (0.23+16.04.20151028-0ubuntu1) xenial; urgency=medium

  [ Alberto Mardegan ]
  * New upstream release
    - OAuth: propagate network and SSL errors from SignOnUI (LP: #1349975)
    - Build: remove unused dependency on xmlpatterns, remove unused variables

  [ CI Train Bot ]
  * New rebuild forced.

 -- David Barth <email address hidden> Wed, 28 Oct 2015 15:59:52 +0000

[Matthew Paul Thomas (mpt)]

Verified fixed in Ubuntu 15.04 r224. The "Try Again" button is present and works.