2ping crashes on non-encrypted session
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
2ping (Ubuntu) |
Fix Released
|
High
|
Ryan Finnie | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
* When 2ping is being run as a non-encrypted session between two affected 4.1 releases, within a few minutes the client and/or server will crash with "TypeError: 'NoneType' object is not subscriptable" in scheduled_
* Clients cannot sustain a 2ping session for more than a few minutes.
* When configured as a daemon without respawn, this results in a denial of service. (Not default in bionic.)
* SRU fix adds a type check for the encrypted_sessions peer table, which is not initialized if no encrypted packets have been received.
* Fixed in commit 4a636763850bcea
[Test Case]
* In one windows, run `2ping --listen`
* In another, run `2ping 127.0.0.1`
* Wait up to 5 minutes for TypeError.
[Regression Potential]
* SRU might not fix issue.
* SRU fix might break scheduled cleanup of sessions when encryption *is* activated, leading to resource exhaustion.
* SRU fix might break scheduled cleanup of other data unrelated to encryption.
* Patch author has tested these scenarios and cannot reproduce any of them.
[Other Info]
* Originally reported by Github user joe1981alAPR (https:/
tags: | added: bionic |
Changed in 2ping (Ubuntu): | |
assignee: | nobody → Ryan Finnie (fo0bar) |
importance: | Undecided → High |
Changed in 2ping (Ubuntu): | |
status: | Confirmed → In Progress |
tags: |
added: verification-done removed: verification-needed |
[ubuntu/ bionic- proposed] 2ping 4.1-1ubuntu1 (Waiting for approval)
> Redirecting ubuntu bionic to ubuntu bionic-proposed.
> This upload awaits approval by a distro manager