application window class should be in a separate file

[Bryce Harrington]

Binary package hint: quickly

Quickly creates a Window class for the application, and defines it in bin/<program>.
It would be better to place this class in the same directory as the dialog files.

[Bryce Harrington (bryce)]

Actually nevermind; poking around in the latest codebase I see this has already been done!

[Michael Terry (mterry)]

Well, sort of. The latest code has moved most of the code to a BaseProjectWindow class. But there is still a bit of the class in the main script, for the user to modify and customize.

But I'm actually thinking now that I'm not sure why we have any widgets in the main script. That it should be reserved for initialization code (which is getting larger all the time as we add more features and the ability to launch from /usr, /opt, or bzr). That way, the python module would hold all the widgets.

I'm re-opening with that intention. Maybe we can rename BaseProjectWindow to just ProjectWindow and move the last bits of code into it.

[Bryce Harrington (bryce)]

On Mon, Dec 20, 2010 at 02:28:56PM -0000, Michael Terry wrote:
> Well, sort of. The latest code has moved most of the code to a
> BaseProjectWindow class. But there is still a bit of the class in the
> main script, for the user to modify and customize.
>
> But I'm actually thinking now that I'm not sure why we have any widgets
> in the main script. That it should be reserved for initialization code
> (which is getting larger all the time as we add more features and the
> ability to launch from /usr, /opt, or bzr). That way, the python module
> would hold all the widgets.
>
> I'm re-opening with that intention. Maybe we can rename
> BaseProjectWindow to just ProjectWindow and move the last bits of code
> into it.

Yeah, a pattern a lot of python applications seem to follow is to have a
relatively minimal exec script, and nearly all the real logic in module
files. For some, the only logic in the exec script is option handling
(which quickly moves to other files).

[Bryce Harrington (bryce)]

Heru, please do not randomly change bug statuses.

[Michael Terry (mterry)]

Actually, this was done for 11.04.