should build without GTK deprecations

[Sebastien Bacher]

Binary package hint: indicator-applet

Ubuntu will start using GTK3 in its default installation next cycle, as a first step to be ready for that your sources should build on GTK 2.22 with GTK deprecations disabled which is not the case for indicator-applet

You can set CFLAGS='-DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGSEAL_ENABLE -DG_DISABLE_DEPRECATED' to testbuild it.

You can also find documentation on how to port code on http://library.gnome.org/devel/gtk/2.91/gtk-migrating-2-to-3.html

[Michael Terry (mterry)]

I have a branch for this (linked to this bug), but there was a problem with the hotkey handling. It used some secret attributes of a GtkMenuShell that aren't there with deprecated API disabled. I couldn't figure out how to get the same result using published API (except perhaps to fake a keyboard press?).

 if (!GTK_MENU_SHELL(data)->active) {
  gtk_grab_add (GTK_WIDGET(data));
  GTK_MENU_SHELL(data)->have_grab = TRUE;
  GTK_MENU_SHELL(data)->active = TRUE;
 }

You'll see this in hotkey_filter(). Ted, any ideas on how to do that bit the right way? For now I've commented it out in my branch, but it isn't recommended for merging because of this issue.

[Sebastien Bacher (seb128)]

Ted, could you reply to the previous comment?

[Ted Gould (ted)]

So, this bug needs more comments :-)

I'm not sure exactly what to do with that code. It's needed to handle the case where the menu is open and has grabs so that they get closed properly on exit. It'll cause the grabs to remain even when the menus are closed. That's a bad thing.

I think we might need to propose a function in GTK for the menu code to do the proper display (the code was inspired by code in GTK Menu) but I don't believe the function was exposed properly.