[PATCH] Cache ordering is not stable in Python 2.7

[Michel Lind]

Fedora is switching to Python 2.7 for the next release, and one of the unit tests in Storm (tested with versions 0.15-0.17) fails because ordering inside a cache is not stable.

This patch sorts the initial objects and the cached ones before asserting that the two lists are equal.

[Toshio (toshio-redhat-bugs)]

Description of problem:
a unittest fails when rebuilding with python-2.7. Looks like the ordering inside of a cache is not stable but storm's test suite doesn't recognize that.

I'm fixing the test suite with the attached patch and rebuilding for f15 and f14. Please submit the patch upstream.

[Toshio (toshio-redhat-bugs)]

Created attachment 435718
fix ordering assumption in test suite

[Michel (michel-redhat-bugs)]

Reported; leaving this open until upstream makes a decision.

[Jamu Kakar (jkakar)]

Hi Michel,

Thanks for the patch. Have you signed the Canonical Contributors
Agreement? We'll need to to sign it before we can accept your patch:

http://www.canonical.com/contributors

[Michel Lind (michel-slm)]

Hi Jamu,

The patch actually comes from Toshio Kuratomi; I'm Cc: ing him.
Toshio, have you signed Canonical contributor agreement?

Alternatively, would it be fine to just declare the contribution
public domain? It's quite a small and, in this case, obvious fix.

On Fri, Sep 17, 2010 at 4:31 PM, Jamu Kakar <email address hidden> wrote:
> Hi Michel,
>
> Thanks for the patch.  Have you signed the Canonical Contributors
> Agreement?  We'll need to to sign it before we can accept your patch:
>
> http://www.canonical.com/contributors
>
>
> ** Changed in: storm
>    Milestone: None => 0.18
>
> --
> [PATCH] Cache ordering is not stable in Python 2.7
> https://bugs.launchpad.net/bugs/641326
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in Storm: New
> Status in Fedora: Unknown
>
> Bug description:
> Fedora is switching to Python 2.7 for the next release, and one of the unit tests in Storm (tested with versions 0.15-0.17) fails because ordering inside a cache is not stable.
>
> This patch sorts the initial objects and the cached ones before asserting that the two lists are equal.
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/storm/+bug/641326/+subscribe
>

[Toshio Kuratomi (toshio)]

I have signed the agreement and I'm on the list: https://launchpad.net/~contributor-agreement-canonical/+members#active

I confirm that I wrote the patch in question.

[Fedora (fedora-redhat-bugs)]

python-storm-0.18-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/python-storm-0.18-1.fc14

[Fedora (fedora-redhat-bugs)]

python-storm-0.18-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/python-storm-0.18-1.fc15

[Fedora (fedora-redhat-bugs)]

python-storm-0.18-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/python-storm-0.18-1.fc13

[Fedora (fedora-redhat-bugs)]

python-storm-0.18-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-storm-0.18-1.el6

[Fedora (fedora-redhat-bugs)]

python-storm-0.18-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.

[Fedora (fedora-redhat-bugs)]

python-storm-0.18-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.

[Fedora (fedora-redhat-bugs)]

python-storm-0.18-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.

[Fedora (fedora-redhat-bugs)]

python-storm-0.18-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

[Michel Lind (michel-slm)]

Could someone mark this bug closed? Storm 0.19 actually includes the patch (modulo some indentation changes)

[Barry Warsaw (barry)]

Unfortunately, milestone 0.19 is closed so this bug can't be targeted to it, but I changed the status to Fixed Release. Thanks for the update.