[needs-packaging] nvidia-container-toolkit

[Antoine Lassagne]

URL: https://github.com/NVIDIA/nvidia-container-toolkit
License: Apache-2.0
Notes: The NVIDIA Container Toolkit allows users to build and run GPU-accelerated containers. The toolkit includes a container runtime library and utilities to automatically configure containers to leverage NVIDIA GPUs.

I wish to package nvidia-container-toolkit for Ubuntu.

[Antoine Lassagne (antoinelassagne)]

An upload is available here:
https://launchpad.net/~antoinelassagne/+archive/ubuntu/nvidia-container-toolkit-2138390/+packages

And the code is available here:
https://code.launchpad.net/~antoinelassagne/+git/nvidia-container-toolkit/+ref/ubuntu/devel

Please note that this package Depends on libnvidia-container, which is also being submitted as NEW here: https://bugs.launchpad.net/ubuntu/+bug/2138390

[Brian Murray (brian-murray)]

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

[Andreas Glinserer (aglinserer)]

Hi Antoine,
FWIW here is my review of the packaging.

Copyright:
- vendor/github.com/cyphar/filepath-securejoin is a mixture of BSD-3-clause and MPL-2.0 - BSD-3-clause files are missing, default is MPL-2.0
- pmezard - Should be BSD-3
- urfave - can be more compact - all MIT/Expat
- sirupsen - Copyright 2012, Miki Tebeka <email address hidden> missing

Lintian - I have these lintian errors/warnings when building your linked repository locally and running lintian -EvIL -pedantic on the changes files. Interestingly enough those are not present in your linked ppa build:
- E: nvidia-container-toolkit source: missing-notice-file-for-apache-license [tests/vendor/go.yaml.in/yaml/v3/NOTICE]
- E: nvidia-container-toolkit source: missing-notice-file-for-apache-license [vendor/github.com/opencontainers/runc/NOTICE]
- E: nvidia-container-toolkit source: missing-notice-file-for-apache-license [vendor/gopkg.in/yaml.v3/NOTICE]
- E: nvidia-container-toolkit source: missing-notice-file-for-apache-license [vendor/sigs.k8s.io/yaml/goyaml.v2/NOTICE]
- W: nvidia-container-toolkit-base: mismatched-override spelling-error-in-binary modfied modified [usr/nvidia-cdi-hook] [usr/share/lintian/overrides/nvidia-container-toolkit-base:8]
- unused-override hardening-no-bindnow for all your packages

Rules:
- There is an override for dh_dwz, but no reason why. If this is normal/usual for golang, sorry for the noise.

General:
- nvidia-container-toolkit.{pre,post}inst - is there a need to create the symlink this way? Wouldn't an override in the rules be cleaner, like:
```
override_dh_link:
 dh_link

 dh_link -p nvidia-container-toolkit usr/bin/nvidia-container-runtime-hook usr/bin/nvidia-container-toolkit
```
- There is a changelog.old file in the debian folder. I assume this is a leftover and should be removed?
- Is the debian/prepare intended to stay?
- The d/tests/build is more of a smoke test I'd say, as it only executes --help.
- Both patches are missing the `>` character in your mail address
- The order in d/patches/series is not what you'd expect from the numbering :)

[Antoine Lassagne (antoinelassagne)]

Thank you for the review. I've applied

Copyright:
- mixture of BSD-3-clause and MPL-2.0 --> Done
- pmezard --> Done
- urfave --> Done
- sirupsen --> Done

Lintian
- I've overridden 2 more and remove the unused override. I don't have all your `missing-notice-file-for-apache-license` warnings, nor the `unused override hardening-no-bindnow`. This library is built with lazy loading on purpose so it's pretty certain that this override is required?

General
- dh_dwz fails and it's not a critical step anyway. It sounds like I'm not the only one that has problems with it: https://groups.google.com/g/linux.debian.bugs.dist/c/EuNwwn5TZ0Y
- dh_link: That's a very much nicer way to do it. It's less aligned with upstream but definitely more elegant. Applied and verified.
- removed d/prepare and d/changelog.old
- d/tests/build is indeed superficial, So I added Restrictions: superficial to it.
- '>' added in the email address in the patches
- Order of patches reworked

[Antoine Lassagne (antoinelassagne)]

An new upload is available here:
https://launchpad.net/~antoinelassagne/+archive/ubuntu/nvidia-container-toolkit-2138390/+packages

And the code is updated, still here:
https://code.launchpad.net/~antoinelassagne/+git/nvidia-container-toolkit/+ref/ubuntu/devel