[needs-packaging] libnvidia-container

[Antoine Lassagne]

URL: https://github.com/NVIDIA/libnvidia-container
License: Apache-2.0
Notes: This repository provides a library and a simple CLI utility to automatically configure GNU/Linux containers leveraging NVIDIA hardware.
The implementation relies on kernel primitives and is designed to be agnostic of the container runtime.

I wish to package libnvidia-container for Ubuntu.

[Antoine Lassagne (antoinelassagne)]

An upload is available in here: https://launchpad.net/~antoinelassagne/+archive/ubuntu/libnvidia-container-2138389

And the code is available in here: https://code.launchpad.net/~antoinelassagne/+git/libnvidia-container/+ref/ubuntu/devel

[Brian Murray (brian-murray)]

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

[Andreas Glinserer (aglinserer)]

My review on the packaging FWIW:

- Missing origin for patch 0002-fix-makefile.patch: https://gitlab.archlinux.org/archlinux/packaging/packages/libnvidia-container/-/blob/a642a3cc488862a8483075ee63f8a8c470860149/fix-makefile.patch you do mention you got it from Arch so a concrete link is nicer
- Copyright:
-- src/nvcgo/vendor/github.com/cilium should be Expat/MIT as opposed to Apache-2.0
-- src/nvcgo/vendor/github.com/sirupsen/logrus should be Expat/MIT as opposed to Apache-2.0
-- src/nvcgo/vendor/github.com/google should be BSD-3-Clause as opposed to Apache-2.0
-- From what I understand, the following can be combined into a single stanza:
--- Files: nvidia-modprobe/*
--- Files: nvidia-modprobe/common-utils/{common-utils.c, ….}
--- Files: nvidia-modprobe/modprobe-utils/pci-enum.h
--- Files: nvidia-modprobe/modprobe-utils/pci-sysfs.c
- You have a header file installed in /usr/include as well as a pkg-config and a static lib. Shouldn't those go into a separate libnvidia-container1-dev package?

Just to make sure - I assume both installed libs change their version together so that it's ok to have them in a single package.

[Antoine Lassagne (antoinelassagne)]

Thank you for the review,

- I've fixed the origin in the patch 0002-fix-makefile.patch
- I've fixed the missing copyrights from vendored golang libraries, good catch.

- I wonder if I should combine the file you mention? It sounds like it would lose some details about authors if I do that. Waiting for a second opinion.
- The reason behind the lack of a libnvidia-container1-dev package is because NVIDIA does not do it in their own packaging, and we want to be as close as possible to them to avoid user confusion. Lintian complains about that, but says that it can be overriden for small packages. These lines were in d/libnvidia-container1.lintian-overrides to explain:

```
# https://lintian.debian.org/tags/link-to-shared-library-in-wrong-package
# if this is a small package which includes the runtime and the development libraries, this is not a bug.
# In the latter case, please override this warning.
```