[needs-packaging] libfprint-2-tod1-broadcom

[Yao Wei]

Firmwares and shared libraries for fingerprint support on Dell ControlVault3

URL: https://packages.broadcom.com/artifactory/dell-controlvault-drivers/
License: Proprietary
Note: We will also need this to be backported to noble for OEM support. The upstream release versioning is shared with ControlVault3 Plus, as 6.x.x is for CV3 Plus (for the package libfprint-2-tod1-broadcom-cv3plus, see LP: #2099289), and 5.x.x is for CV3

[Yao Wei (medicalwei)]

This package currently resides in:
https://launchpad.net/~medicalwei/+archive/ubuntu/dell-cv3-cv3plus

Packaging source:
https://git.launchpad.net/libfprint-2-tod1-broadcom

[Brian Murray (brian-murray)]

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

[Vladimir Petko (vpa1977)]

Hi,

Thank you for packaging this!

It seems that some dependencies are missing though, the piuparts test fails with errors in the postinst (see attachment).
Correction: dbus is not started in the piuparts chroot environment failing the test. We probably want some sensible error messages, also may be makes sense to log something if hardware is not available.

We might also want to fix lintian overrides (see pedantic output):
W: libfprint-2-tod1-broadcom changes: package-has-long-file-name libfprint-2-tod1-broadcom_5.14.83-5.14.003.0-0ubuntu1~oem2_amd64.changes
W: libfprint-2-tod1-broadcom buildinfo: package-has-long-file-name libfprint-2-tod1-broadcom_5.14.83-5.14.003.0-0ubuntu1~oem2_amd64.buildinfo
P: libfprint-2-tod1-broadcom source: hyphen-in-upstream-part-of-debian-changelog-version 5.14.83-5.14.003.0 [debian/changelog:1]
P: libfprint-2-tod1-broadcom source: no-homepage-field
P: libfprint-2-tod1-broadcom source: source-contains-prebuilt-binary [usr/lib/x86_64-linux-gnu/libfprint-2/tod-1/libfprint-2-tod-1-broadcom.so]

And reformat the changelog entry as:
  * Initial release (LP: #2099655). [1]

[1] https://wiki.ubuntu.com/UbuntuDevelopment/NewPackages

[Vladimir Petko (vpa1977)]

I am unsubscribing sponsors for the time being, please feel free to resubscribe after the update.

[Yao Wei (medicalwei)]

Updated package to 5.14.83-5.14.003.0-0ubuntu1~oem3

In postinst I added a error handling if connection dbus is not available it will display a message and skip (as the message is in a chroot environment). As well I added a message if there's no device available for the firmware update.

Pednatic lintian messages are all overwritten:

- hyphen-in-upstream-part-of-debian-changelog-version: the upstream version is 5.14.83_5.14.003.0, and Debian Policy allows hyphen being used in the version, as long as the package is non-native [1].

- no-homepage-field: we can only find Windows driver support for the device [2]. As for the repository for this driver in d/watch, OEM team (we) asked Broadcom and Dell to provide a public available repository for this support package.

- source-contains-prebuilt-binary: this package is a proprietary binary and this error is expected.

[1]: https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-version
[2]: https://www.dell.com/support/home/en-us/drivers/driversdetails

[Marco Trevisan (Treviño) (3v1n0)]

One thing to mention here, these drivers are completely fine to be in the archive, but we should make sure that users are using `ubuntu-drivers` to install them.

Since distributing them in an installed OEM machine, may potentially break the fprintd GPL license.

[Dave Jones (waveform)]

Per LP: #2099289 sponsoring for plucky (minus the ~oemN suffix as I'm assuming that was added purely for rebuilds in the PPA).