[needs-packaging] crac-criu

[Pushkar Kulkarni]

Newly proposed packages openjdk-17-crac [1] and openjdk-21-crac [2] need an adapted version of criu [3]. The OpenJDK/crac project maintains its own criu [4] for this purpose.

URL: https://github.com/CRaC/criu

License: GPL 2.0 license

Note: this dependency was initially vendored into the openjdk-17-crac and openjdk-21-crac. We decided to propose a separate package after an initial code review.

[1] https://bugs.launchpad.net/ubuntu/+bug/2073609
[2] https://bugs.launchpad.net/ubuntu/+bug/2073612
[3] https://github.com/checkpoint-restore/criu
[4] https://github.com/CRaC/criu

[Pushkar Kulkarni (pushkarnk)]

The proposed package is uploaded here:
https://launchpad.net/~pushkarnk/+archive/ubuntu/crac

The source package is pushed here for reference:
https://git.launchpad.net/~pushkarnk/+git/crac-criu

[Vladimir Petko (vpa1977)]

Packaging review:
MUST:
- Package must meet Ubuntu versioning & Maintainer requirements [OK]
Version: 1.4.2-0ubuntu1
Maintainer: Pushkar Kulkarni <email address hidden>
- Package must match current Ubuntu (and Debian) packaging policies [Comments]
See lintian clean section, warnings.
- Package must build, install, run, remove, and purge cleanly [OK]

SHOULD:
- Package should be lintian clean [Comments]
```
W: crac-criu source: absolute-symbolic-link-target-in-source /usr/include/google/protobuf/descriptor.proto [images/google/protobuf/descriptor.proto]
W: crac-criu source: build-depends-on-obsolete-package Build-Depends: pkg-config => pkgconf
W: crac-criu: description-synopsis-starts-with-article
W: crac-criu source: globbing-patterns-out-of-order lz4/lib/dll/example/Makefile lz4/lib/* lz4/lib/dll/example/Makefile [debian/copyright:61]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro '"' not defined [usr/share/man/man1/amdgpu_plugin.1.gz:3]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro '"' not defined [usr/share/man/man1/compel.1.gz:3]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro '"' not defined [usr/share/man/man1/crit.1.gz:3]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro '"' not defined [usr/share/man/man1/criu-ns.1.gz:3]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro '"' not defined [usr/share/man/man8/criu.8.gz:3]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'HTML-TAG' not defined [usr/share/man/man1/amdgpu_plugin.1.gz:2]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'HTML-TAG' not defined [usr/share/man/man1/compel.1.gz:2]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'HTML-TAG' not defined [usr/share/man/man1/crit.1.gz:2]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'HTML-TAG' not defined [usr/share/man/man1/criu-ns.1.gz:2]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'HTML-TAG' not defined [usr/share/man/man8/criu.8.gz:2]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'an-trap' not defined [usr/share/man/man1/amdgpu_plugin.1.gz:4]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'an-trap' not defined [usr/share/man/man1/compel.1.gz:4]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'an-trap' not defined [usr/share/man/man1/crit.1.gz:4]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'an-trap' not defined [usr/share/man/man1/criu-ns.1.gz:4]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'an-trap' not defined [usr/share/man/man8/criu.8.gz:4]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'set-an-margin' not defined [usr/share/man/man1/amdgpu_plugin.1.gz:1]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'set-an-margin' not defined [usr/share/man/man1/compel.1.gz:1]
W: crac-criu: groff-message troff:<standard input>:175: warning: macro 'set-an-margin' not defined [usr/share/man/man1/crit.1.gz:1]
W: crac-criu: groff-message...

[Pushkar Kulkarni (pushkarnk)]

Thanks for the review! Here is my response:

> See lintian clean section, warnings
Fixed all the lintian warnings. I had to add a few overrides.

> Contents of debian/ should be sane
Removed override_dh_strip
Build time tests need significant rework (I guess owing to the gcc version on oracular), they are skipped by the criu package too.

> Package must meet copyright / licensing requirements
Added Canonical copyright under debian/*

> Non-native packages must have verifiable cryptographic path to upstream source
Signed the upstream release.
Added cryptographic source verification. See debian/watch, debian/upstream/signing-key.asc

> We may want to provide README.Debian to cover the changes from upstream CRIU.
Added a README.Debian with information about deltas added by the upstream(s), mentioned the rationale for
debian/patches.

Test build: https://launchpad.net/~pushkarnk/+archive/ubuntu/crac-packages-2
Latest source package: git+ssh://git.launchpad.net/~pushkarnk/+git/crac-criu

[Vladimir Petko (vpa1977)]

Packaging review:
MUST:
- Package must meet Ubuntu versioning & Maintainer requirements [OK]
Version: 1.4.3-0ubuntu1
Maintainer: Pushkar Kulkarni <email address hidden>
- Package must match current Ubuntu (and Debian) packaging policies [OK]
- Package must build, install, run, remove, and purge cleanly [OK]

SHOULD:
- Package should be lintian clean [OK]
- Contents of debian/ should be sane [OK]
- Changelog should close a "needs-packaging" bug [OK]
- Package should follow http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html[OK]

Maintenance review:
MUST:
- Package must contain a watch file or get-orig-source rule [OK]
- If upstream is no more, the packager should consider adopting the upstream package somewhere [N/A]
- Packages who implement get-orig-source for packages with watch files get extra points [no extra points]
- Packaged version must not have any known security or critical bugs [OK]
 See https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=criu, no current CVEs

SHOULD:
- Packaging scripts should be readable and readily comprehensible [OK]
- Upstream should be responsive, and maintain a bug tracker [OK]
- Packaged version should be latest upstream [OK]
- Package should not be native without an approved spec [N/A]

Suitability review
MUST:
- Package must meet copyright / licensing requirements [OK]
- Non-native packages must have verifiable cryptographic path to upstream source [OK]
- Package must be advocated by at least two members of ubuntu-dev (the packager may count as one) [OK]
SHOULD:
- Package should work on a standard Ubuntu/Kubuntu/Xubuntu/etc. system [OK]
   - can install and run binary.
- Package should provide hints to system services (app-install-data, menus, etc.) to ease installation and use [N/A]
- Package should provide Ubuntu-specific documentation for variances in behaviour from upstream [OK]
Provided readme.Debian.
- Package should provide a Homepage: header in debian/control [OK]

[Vladimir Petko (vpa1977)]

Uploaded, thank you!!!

NEW: crac-criu_1.4.3.orig-lz4.tar.gz
NEW: crac-criu_1.4.3.orig.tar.gz
NEW: crac-criu_1.4.3.orig.tar.gz.asc
NEW: crac-criu_1.4.3-0ubuntu1.debian.tar.xz
NEW: crac-criu_1.4.3-0ubuntu1.dsc