Please sync signond from Debian

Bug #2046007 reported by Aaron Rainbolt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu
Fix Released
Undecided
Aaron Rainbolt

Bug Description

Filing this against Ubuntu directly since the signond package currently does not exist in Ubuntu.

signond in Debian replaces the signon package in Ubuntu. It builds properly against Noble with some symbols file tweaks. It upgrades properly (I can install the original signon binary packages in Ubuntu, then upgrade them to the newer version without errors).

A debdiff from the Debian version is attached.

Revision history for this message
Aaron Rainbolt (arraybolt3) wrote :

Ubuntu delta needed to make the package build properly. It also includes a couple of updates to the Lintian overrides that aren't necessary but help silence Lintian gripes.

Changed in ubuntu:
assignee: nobody → Aaron Rainbolt (arraybolt3)
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Hello, two things:
1)
from: https://git.launchpad.net/~ubuntu-archive/+git/sync-blocklist/tree/sync-blocklist.txt
# vorlon, 2017-11-09: Ubuntu is upstream, package named differently (signon vs. signond), Debian version is behind
signond

2) dropping symbols is bad, better to mark them as optional, this way you can forward them to Debian.
(please do it, and use submittodebian tool to open a bug)

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

3) while I do like packages to be lintian free, I prefer if the fixes comes from Debian, because they make the delta bigger, and more difficult for subsequent merges.

Revision history for this message
Aaron Rainbolt (arraybolt3) wrote :

Will fix the symbols, thanks.

As for fixes coming from Debian, there are a load of different opinions about this. My opinion is to ensure a delta is Lintian clean, and forward a bug to Debian if an issue is serious enough to make me uncomfortable asking for a sync, or easy to forward. Your opinion is to fix things in Debian first and sync thereafter it appears. Erich Eickmeyer's opinion is to fix Lintian issues in Ubuntu first if it's easy to do so, then go to Debian with the fix. There's no one way of doing this that makes every packager 100% happy, and even now I'm following Eickmeyer's packaging style and not my own. If we could for now just live with the slightly bigger Ubuntu delta, I can forward it to Debian, and then when/if it's accepted, I can sync it myself once I'm a MOTU.

Revision history for this message
Aaron Rainbolt (arraybolt3) wrote :

Here's my second patch. Thanks for your help with this!

Revision history for this message
Aaron Rainbolt (arraybolt3) wrote :
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

It's ok as long as you forward the lintian fixes to Debian too :) I have no strong opinion, what I worry is that after the package is sponsored nobody remembers to forward to Debian.
This is why I prefer the Debian bug to be opened before fixing.

I'm removing the extra space and marking them as (optional=lto), because I checked and they appear to be the same symbols disappearing with lto enabled.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1015658.

To make things faster, I added it myself, and closed the two debian bugs in the merge changelog, this way for future merges we will know that we already have bugs.

Revision history for this message
Erich Eickmeyer (eeickmeyer) wrote :

Aaron,

(responding because I was notified my name was dropped)

There's no hard and fast rule, just preferences. As Gianfranco is a DD, he does have a preference that, if the package exists in Debian, and the bug can be fixed in Debian, then it needs to be fixed there. In order to do that, a bug needs to be filed. Since Gianfranco has the power to sponsor in Ubuntu and Debian, it's very easy for him to upload the fix to both simultaneously if the changelog has the bug entry for both ala (LP: #2046007) and (closes: #1057883).

For me, since I'm only a MOTU, if I'm sponsoring a package normally synced from Debian, I'm happy to upload to Ubuntu as long as the sponsored is also going to file a bug in Debian. If not, then I can do it with a patch, but I can't sponsor in Debian. So there's a slight difference when you have someone like Gianfranco than when you have someone such as myself. That's just my preference. Can I easily get someone like Gianfranco to sponsor for me? Absolutely, but that doesn't mean it always happens.

Anyhow, I just thought I'd give you some context as to why there are different preferences and hope you understand.

Revision history for this message
Aaron Rainbolt (arraybolt3) wrote :

Eickmeyer: That makes perfect sense, and should help me do better work in the future. Thanks!

Changed in ubuntu:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.