[needs-packaging] Package HSS payload generator for Polarfire Icicle board

[Heinrich Schuchardt]

The Polarfire Icicle board is supported by our 5.19 RISC-V kernel. For booting it U-Boot is needed. The U-Boot binary must be encapsulated with a vendor specific tool "HSS payload generator". This report is about packaging this tool

URL: https://github.com/polarfire-soc/hart-software-services
License: BSD-2-clause, MIT
Notes:

Only one of the HSS payload generator contained in the source is needed. I have already packaged the tool in ppa:ubuntu-risc-v-team/develop as hart-software-services - 2022.02-0ubuntu1~ppa8.

Best regards

Heinrich

[Heinrich Schuchardt (xypron)]

hart-software-services - 2022.02-0ubuntu1 is available in ppa:ubuntu-risc-v-team/develop.

[Graham Inggs (ginggs)]

notes:

debian/rules can be greatly simplified by specifying sourcedirectory, and dropping all the override_dh* targets:

%:
 dh $@ --sourcedirectory=tools/hss-payload-generator

There are some Lintian tags to be fixed:

W: hart-payload-generator: undeclared-elf-prerequisites (libc.so.6 libcrypto.so.3 libelf.so.1 libyaml-0.so.2) [usr/bin/hss-payload-generator]

 - I think this is quite serious, caused by missing 'Depends: ${shlibs:Depends}' in debian/control

I: hart-software-services source: debian-watch-file-is-missing

 - see https://wiki.debian.org/debian/watch#GitHub - side note, upstream v2022.03 has been released

P: hart-software-services source: silent-on-rules-requiring-root [debian/control]

 - If the package doesn't need root or fakeroot to build, please add 'Rules-Requires-Root: no' in debian/control

In debian/control, you have Vcs-Git and Vcs-Browser pointing at upstream, these should be the VCS of where the packaging is maintained in Debian or Ubuntu. If the packagaging isn't maintained in a VCS, you can remove these lines.

Some minor Lintian tags that should easy to fix:

I: hart-software-services source: out-of-date-standards-version 4.6.0 (released 2021-08-18) (current is 4.6.1.0)

 - look at the checklist for 4.6.1 https://www.debian.org/doc/debian-policy/upgrading-checklist.html and bump 'Standards-Version: 4.6.1' in debian/control

P: hart-software-services source: trailing-whitespace [debian/control:17]

I: hart-payload-generator: spelling-error-in-binary specifiy specify [usr/bin/hss-payload-generator]

I have not reviewed debian/copyright yet.

[Graham Inggs (ginggs)]

I see no mention in debian/copyright of the files thirdparty/Kconfiglib/* and thirdparty/libecc/*.

Lintian is still quite insistent about baremetal.elf, is the source for it available anywhere? I don't believe we have to build it from source seeing it's a test file, but it would be nice to provide it, even if we just put it in debian/missing-sources/.

E: hart-software-services source: source-is-missing [tools/hss-payload-generator/test/baremetal.elf]
P: hart-software-services source: source-contains-prebuilt-binary [tools/hss-payload-generator/test/baremetal.elf]

[Heinrich Schuchardt (xypron)]

Unfortuantely the source is not available. I have created https://github.com/polarfire-soc/hart-software-services/issues/50.

The source should be trivial. The program is meant to print
"Hello, World from hartid %d\n"
as an S-mode application running instead of U-Boot. It is not usable inside Linux and we will not put it into binary packages.

[Graham Inggs (ginggs)]

I picked up your new version 2022.03-0ubuntu1 from your PPA.
Thanks for addressing my concerns!

I don't believe that lack of source code for the test file baremetal.elf should be a blocker, so uploading with one minor change:
Standards-Version: 4.6.0.1 -> 4.6.1

[Łukasz Zemczak (sil2100)]

Accepted into kinetic-proposed. I tweaked debian/copyright a bit with the ISC license mention for thirdparty/Kconfiglib/*.