[needs-sponsor] Include ignition rendering packages in Ubuntu Jammy

[Jose Luis Rivero]

Please include the ignition rendering stack, composed by three packages ignition-rendering, ignition-gui and ignition-sensors.

It will require ogre-next to work, in https://bugs.launchpad.net/ubuntu/+bug/1960149

* Package name : ignition-rendering
  Version : 6.1.0
  Upstream Author : Open Robotics
* URL : https://github.com/ignitionrobotics/ign-rendering/
* License : Apache2
  Programming Lang: C++
  Description : Ignition Rendering is a C++ library designed to
                provide an abstraction for different rendering
                engines.

* Package name : ignition-gui
  Version : 6.3.0
  Upstream Author : Open Robotics
* URL : https://github.com/ignitionrobotics/ign-gui
* License : Apache2
  Programming Lang: C++,
  Description : Ignition GUI ships with several widgets ready to use
                and offers a plugin interface which can be used to
                add custom widgets.

* Package name : ignition-sensors
  Version : 6.1.0
  Upstream Author : Open Robotics
* URL : https://github.com/ignitionrobotics/ign-sensors/
* License : Apache2
  Programming Lang: C++
  Description : Ignition Sensors, a component of Ignition Robotics,
                provides numerous sensor models designed to generate
                realistic data from simulation environments.

I have done the packaging work for the three of them, they build fine in the PPA https://launchpad.net/~j-rivero/+archive/ubuntu/jammy-packages
for the arches available: amd64, arm64, armhf.

The packages are also available via bzr:
 * https://code.launchpad.net/~j-rivero/+junk/ignition-rendering
 * https://code.launchpad.net/~j-rivero/+junk/ignition-gui
 * https://code.launchpad.net/~j-rivero/+junk/ignition-sensors

Should have no errors or warnings coming from Lintian as far as I can say but count me in for fixing anything needed.

[Brian Murray (brian-murray)]

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

[Jose Luis Rivero (j-rivero)]

Hello Mathew:

Please note that I've already packaged the software and it is ready for review. You can access to via:

PPA:
 * https://launchpad.net/~j-rivero/+archive/ubuntu/jammy-packages
Bzr:
 * https://code.launchpad.net/~j-rivero/+junk/ignition-rendering
 * https://code.launchpad.net/~j-rivero/+junk/ignition-gui
 * https://code.launchpad.net/~j-rivero/+junk/ignition-sensors

Can we please revert the change in the tittle?
Thanks!

[Łukasz Zemczak (sil2100)]

Ok, I had a quick look at the packages and they seem fine. Copyright is fine, licenses seem good from the Ubuntu POV, the packaging is decent. I had to adjust the versioning to be compliant with the state of things (i.e. switch from -1ubuntuX to -0ubuntu1 as this package is not in Debian yet), remove some cruft files. But I think it's good for an include in jammy now. I was only wondering: why is NEWS excluded from the ingnition-rendering tarball? It's just an URL. Basically I'd normally not repack the tarball and exclude sources unless really necessary (like when for instance upstream ships something bad in the tarball, like compiled binaries etc.). Probably something to keep in mind later.

Sponsoring and accepting.

[Łukasz Zemczak (sil2100)]

...oh, and since not all architectures were enabled on the PPA (please be sure to enable as many as possible!), please be sure to check if the packages build successfully on ALL the arches after upload. Thanks.

And I recommend switching the other arches for future builds.

[Jose Luis Rivero (j-rivero)]

Thanks so much Łukasz for reviews and comment.

> why is NEWS excluded from the ingnition-rendering tarball? It's just an URL. Basically I'd normally not repack the tarball and exclude sources unless really necessary (like when for instance upstream ships something bad in the tarball, like compiled binaries etc.).

Not an strong reason for excluding NEWS more than get rid of some not very useful files. I agree, not worth it. I'm using repacking as my normal workflow as Debian maintainer to get rid of embedded libs, copyrighted files and usually include other not so critical files like .github/ or other CI configurations.

> ...oh, and since not all architectures were enabled on the PPA (please be sure to enable as many as possible!), please be sure to check if the packages build successfully on ALL the arches after upload. Thanks. And I recommend switching the other arches for future builds.

Ouch, enabled ARM but forgot the other previously. I've already enabled all to be checked in possible future iterations. I keep an eye on the builds and always available to provide patches as needed.

Thanks again.

[Jose Luis Rivero (j-rivero)]

> keep an eye on the builds and always available to provide patches as needed.

I just checked that ignition-gui, ignition-rendering and ignition-sensors have been built just fine in amd64, arm64, armhf, ppc64el and riscv64. The only remaining problem would be s390x but the issue is the lack of one of the dependencies (ignition-common) which I believe is out of the scope of this request.

I think that we can call it done, thanks for the reviews and fixes Łukasz!