[needs-packaging] lg (lgpio, rgpio, rgpiod, rgs)

Bug #1916901 reported by Dave Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu
Fix Released
Wishlist
Balint Reczey

Bug Description

The lg project provides platform agnostic libraries and tools to query and control local or remote machine's GPIO pins via the kernel's gpiochip devices. It is primarily of interest on the Raspberry Pi (where the "legacy" means of controlling these pins, by banging on the GPIO registers and epolling sysfs file, is deprecated), but is not tied to that particular platform in any way (it should theoretically work on any platform that provides /dev/gpiochip* devices).

URL: http://abyz.me.uk/lg/index.html
License: public-domain
Notes:

Test builds of packages suitable for Ubuntu are available from the following PPA: https://launchpad.net/~waveform/+archive/ubuntu/lg

tags: added: needs-packaging
Revision history for this message
Brian Murray (brian-murray) wrote :

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

Changed in ubuntu:
importance: Undecided → Wishlist
Balint Reczey (rbalint)
Changed in ubuntu:
assignee: nobody → Balint Reczey (rbalint)
Revision history for this message
Balint Reczey (rbalint) wrote :

First round of comments from reviewing the package for sponsoring:

Please set up a DEP-14 compliant git repository for packaging or remove the Vcs-* templates from d/control .
The source name lg is beautifully short but I think something longer would be better, like lg-gpio or lgpio-tools.
Please close this LP bug in d/changelog.

Revision history for this message
Balint Reczey (rbalint) wrote :

Further comments:

Please remove the examples from debian/rules .

Please use an @ubuntu.com email address or set maintainer to Ubuntu Developers <email address hidden> to avoid:

dpkg-source: error: Version number suggests Ubuntu changes, but Maintainer: does not have Ubuntu address
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 255

Otherwise the package looks good and will happily sponsor it after the comments are resolved.

Revision history for this message
Dave Jones (waveform) wrote :

All review points, except one discussed below, now addressed in the new PPA upload (0.1.6.1-0ubuntu1~ppa4) at:

  https://launchpad.net/~waveform/+archive/ubuntu/lg

> The source name lg is beautifully short but I think something longer would be better, like lg-gpio or lgpio-tools.

lg-gpio would probably be okay: it's the "lg" project and it's all about gpio stuff, but I don't think lgpio-tools works (given there's no lgpio-tools package, but it probably should produce an rpgio-tools package).

On the subject of renaming, there's possibly one other bit that might need a rename too. Just to give some quick context, there's three sides to the packages produced by this project:

* liblgpio1, liblgpio-dev, python3-lgpio - A library (and Python 3 bindings) for controlling GPIO pins locally (hence lgpio=local gpio)

* librgpio1, librgpio-dev, python3-rgpio - A library (and Python 3 bindings) for controlling GPIO pins remotely via...

* rgpiod, rgs - A daemon which uses liblgpio to control the local GPIO pins in response to TCP socket requests from librgpio, plus a shell client for this daemon (rgs)

Would it perhaps be wise to rename the "rgs" package (which is also rather short) to "rgpio-tools"?

Revision history for this message
Dave Jones (waveform) wrote :

Renamed packages uploaded to https://launchpad.net/~waveform/+archive/ubuntu/lg/+packages though it seems the amd64 builders are a bit backed up at the moment.

Revision history for this message
Balint Reczey (rbalint) wrote :

Thanks, uploaded!

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, performed a NEW review. There's only one thing I asked Dave to address before accepting:

 * I was discussing this with Dave already, but since there's a new user added during rgpiod installation, I feel that it might be good to remove it during package purge as well (as Dave mentioned, this is the case for packages like sssd). Dave had valid doubts if leaving files (that might be created by rgpiod) with non-existent ownership is nice, but I think the other choice is better. Since yeah, we can't really guarantee we'll handle all the weird stuff the package does during runtime, but maybe we should make sure that at least everything the package system installs is also removed - even if there would be leftover files with a non-existing ownership.

Some other stuff, even more minor, to be considered for some future version of the package (non-blocking):

 * Adding the legacy get-orig-tarball target to debian/rules. It has been obsoleted by debian/watch, but here, since the upstream prepares releases in a very specific way, we can't really use that. Dave prepared a get-orig-tarball script for that, which is good, but I think it would be nice to at least add this legacy target as a fallback for people unable to use uscan.
 * Some of the /etc/ content removal in the .postrm script seems redundant, since dpkg should handle proper conffile removal by itself on purge. Might be good to take a look and see if maybe adding /etc/rgpiod/ to .dirs will help by dpkg handling the removals on its own? Something to look into!

Otherwise I think this is good to go. I can pull the updated package from the PPA directly.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, I see the issues have been addressed - I'll re-upload, re-review and accept.

Changed in ubuntu:
status: New → Fix Committed
Balint Reczey (rbalint)
Changed in ubuntu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers