[needs-packaging] Pulseeffects for eoan

Bug #1832059 reported by Erich Eickmeyer on 2019-06-08
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PulseEffects
New
Undecided
Unassigned
Ubuntu
Wishlist
Unassigned

Bug Description

PulseEffects https://github.com/wwmm/pulseeffects (mirrored at https://launchpad.net/pulseeffects) is an application for real time processing of audio input and output on Linux with PulseAudio.

Basically, it can add a graphic equalizer and other effects to PulseAudio applications without the need for Jack.

With the inclusion of lsp-plugins in eoan, all dependencies for this package to be included have been satisfied.

Upstream author has done their own debian/*, but I will be happy to help with any changes necessary via PRs.

Upstream author currently builds in a ppa at https://launchpad.net/~mikhailnov/+archive/ubuntu/pulseeffects

Mikhail Novosyolov (mikhailnov) wrote :

To clarify a bit, https://launchpad.net/~mikhailnov/+archive/ubuntu/pulseeffects is not maintained by upstream author, I just maintain debian/* in upstream via pull requests from https://github.com/mikhailnov/pulseeffects to https://github.com/wwmm/pulseeffects and maintain that PPA.

I also build PulseAudio in PulseEffects PPA, because newer PulseAudio has some important fixes. As for Ubuntu 19.10 Eoan, it would be good to include this patch https://gitlab.com/nixtux-packaging/pulseaudio-ubuntu/blob/master/pulseaudio-12.2/debian/patches/0001-Backport-add-an-option-that-allows-rewinds-to-be-dis.patch (a backport from git master to v12.2) to fix sound crackling when changing volume level in PulseEffects (https://gitlab.com/nixtux-packaging/pulseaudio-ubuntu/blob/master/pulseaudio-12.2/debian/patches/0001-Backport-add-an-option-that-allows-rewinds-to-be-dis.patch). I've made a seperate bug report: https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1832060

Erich Eickmeyer (eeickmeyer) wrote :
Download full text (12.0 KiB)

lintian has a bit to say about this (used disco just to test):

pulseeffects_4.6.3-1~disco1.dsc
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 10)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 12)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 23)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 25)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 29)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 31)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 43)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 45)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 49)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 51)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 55)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 57)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 61)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 63)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 68)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 70)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 74)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 76)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 80)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 82)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 86)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 88)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 92)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 94)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 98)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 100)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 104)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 106)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 110)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 112)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 118)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 126)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 128)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 132)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 134)
P: pulseeffects source: file-contains-trailing-whitespace debian/changelog (line 138)
P: pulseeffects source: file-cont...

Mikhail Novosyolov (mikhailnov) wrote :

Removed trailing whitespaces: https://github.com/mikhailnov/pulseeffects/commit/30e6480bf2e9c9efe2d74ef5e72251db0b725812

Lintian should not be ran against what is on Launchpad, please run it against what is in git, because the script https://github.com/mikhailnov/pulseeffects/blob/master/debian/build-ppa.sh, which helps to automate maintaining the PPA, makes some changes before uploading to Launchpad, what leads to
"source-contains-empty-directory debian/source/"
"missing-debian-source-format"
"hyphen-in-native-debian-changelog-version 4.6.3-1~disco1"
"debian-watch-file-in-native-package"
to appear in Lintian warnings.
These warnings won't appear if Lintian is ran against debian/* in git.

Changed in ubuntu:
importance: Undecided → Wishlist
Simon Quigley (tsimonq2) wrote :

Hello, thanks for your work on this.

Have you considered getting this uploaded to Debian? I will be happy to sponsor there after the Buster release this weekend.

Additionally, could you please upload to a PPA the exact version you'd like uploaded to the archive, where you close this bug in the changelog?

Thanks, and please re-subscribe sponsors when this is fixed.

Mikhail Novosyolov (mikhailnov) wrote :

Yes, I want to upload it to Debian. I will prepare an upload to mentors.debian.net and write here.

Erich Eickmeyer (eeickmeyer) wrote :

As I understand it, with the lsp-plugins requirement, this will not be accepted into Debian until after lsp-plugins has been accepted (I already wrote an ITP: bug for that). Unfortunately, lsp-plugins does not build for all architectures (per the author), which means that, as I understand it, lsp-plugins will not be accepted into Debian. With that, I doubt PulseEffects would be accepted as well since it requires lsp-plugins to operate.

Unless I'm wrong, I believe the only chance this has to be included in Ubuntu would be the direct route, which yes, means more work for a sponsor.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers