[needs-packaging] kylin-display-switch

Bug #1738366 reported by handsome_feng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Kylin
Fix Released
High
Unassigned
Ubuntu
Fix Released
Wishlist
Unassigned

Bug Description

kylin-display-switch is a gui tool to switch display output,Users can use Super_L + P/F3/F7 to activate display switching.
It also monitors CapsLock and NumLock key, when these buttons are clicked, corresponding reminder will popper up.
It will be installed as default in Ubuntu Kylin, a Chinese flavor of Ubuntu.

Packaging URL: https://github.com/ukui/debian-packages/tree/master/kylin-display-switch/debian
Source URL: https://github.com/ukui/kylin-display-switch
License: GNU GPL v3

PPA: https://launchpad.net/~ubuntukylin-members/+archive/ubuntu/newpackages

tags: added: needs-packaging
Revision history for this message
handsome_feng (feng-kylin) wrote :
Revision history for this message
handsome_feng (feng-kylin) wrote :
Revision history for this message
Brian Murray (brian-murray) wrote :

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

Changed in ubuntu:
importance: Undecided → Wishlist
Changed in ubuntukylin:
status: New → Confirmed
importance: Undecided → High
Changed in ubuntukylin:
status: Confirmed → In Progress
Revision history for this message
Simon Quigley (tsimonq2) wrote :

LGTM, but I'd like a +1 from one other MOTU as per https://wiki.ubuntu.com/UbuntuDevelopment/NewPackages#Going_through_MOTU

Thanks!

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

current compat level is 10, not 9
we are moving away from python2 and qt4, and new packages should not use/provide binding for them anymore

"
Depends: python-qt4,
         gir1.2-glib-2.0,
         python-keybinder,
python-xlib,"

this needs to be expressed in setup.py with install_requires keyword

I didn't do a copyright review, it is a nack from me, basically because of the qt4 removal.

Revision history for this message
handsome_feng (feng-kylin) wrote :

Hi, LocutusOfBorg,
I have updated the package and upload it to the PPA: https://launchpad.net/~ubuntukylin-members/+archive/ubuntu/newpackages

Thanks!

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Hello,

I have no idea where to find the source tarball for this, could you please add a watch file in this and for the other repos you have?

Otherwise as soon as I get that I'll be happy to sponsor it.

Thank you!

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Oh, and also, the current debhelper compat is now 11, please use that.

Thank you!

Revision history for this message
handsome_feng (feng-kylin) wrote :

Hi, Simon,

I have added the watch file and updated the compat version, and because the Launchpad build farm is disabled pending maintenance, I didn't update the PPA, and only update this in github.

Packaging URL: https://github.com/ukui/debian-packages/tree/master/kylin-display-switch/debian
Source URL: https://github.com/ukui/kylin-display-switch
release: https://github.com/ukui/kylin-display-switch/releases/tag/v1.0.1

Thanks.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Hmm, seems to be FTBFS when trying to build it using sbuild:

$ sbuild -d bionic-amd64-shm
dh clean --with python3 --buildsystem=pybuild
   dh_auto_clean -O--buildsystem=pybuild
E: pybuild pybuild:96: cannot detect build system, please use --system option or set PYBUILD_SYSTEM env. variable
dh_auto_clean: pybuild --clean -i python{version} -p 3.6 returned exit code 11
debian/rules:6: recipe for target 'clean' failed
make: *** [clean] Error 25
E: Failed to clean source directory /tmp/tmp.XLBD8XiLTA/debian-packages/kylin-display-switch (/tmp/tmp.XLBD8XiLTA/debian-packages/kylin-display-switch_1.0.1-0ubuntu1.dsc)

Could you fix this please? (Or if it's on my end, tell me what I'm doing wrong?)

Thanks.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Discussed on IRC, all good now, uploaded.

Changed in ubuntu:
status: New → Fix Committed
Revision history for this message
handsome_feng (feng-kylin) wrote :

Hi, Simon

I have updated all packages in the PPA. :)

Thanks.

Changed in ubuntukylin:
status: In Progress → Fix Committed
Changed in ubuntukylin:
status: Fix Committed → Fix Released
Changed in ubuntu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.