[needs-packaging] repowerd needs packaging

[Alexandros Frantzis]

repowerd (https://launchpad.net/repowerd), the next-gen power daemon for ubuntu-touch, needs to be added to universe.

repowerd is in the process of being released through ci-train here:

https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-003/+packages

[Michael Terry (mterry)]

A few minor comments:

- The upstream version is 2016.06. But citrain already appends the date as part of the version. So unless you plan to make a habit of updating the upstream version, you may eventually get to versions like 2016.06+17.10.20180705, which has three different dates in it, all different. This isn't a *problem*, just pointing it out. May become confusing.

- Vcs-Git in debian/control should be "https://git.launchpad.net/repowerd" (or lp:repowerd, if git understands that?)

- It is more proper for the powerd dummy package to be "Arch: any" since it points at an "any" package.

- I see REPOWERD_DISABLE_TIME_SENSITIVE_TESTS=ON in debian/rules. Is there something that does run the time sensitive tests? CI Jenkins maybe? This might be a good spot to suggest adding a dep8 test that runs the full test suite.

- dh_installinit seems to be a little confused? It inserts code into postinst and prerm to stop and start the init.d job. But repowerd only installs an upstart job and a systemd job...

Otherwise the packaging seems fine.

[Brian Murray (brian-murray)]

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

[Alexandros Frantzis (afrantzis)]

Thanks for reviewing!

> - The upstream version is 2016.06. But citrain already appends the date as part of the version.
> So unless you plan to make a habit of updating the upstream version, you may eventually get to
> versions like 2016.06+17.10.20180705, which has three different dates in it, all different. This
> isn't a *problem*, just pointing it out. May become confusing.

The plan is to update the version string when releasing a new version. In this case the package has been sitting in ci-train for long, and I have been making only small packaging improvements, not enough for a version bump, that's why there is a "mismatch".

> - Vcs-Git in debian/control should be "https://git.launchpad.net/repowerd" (or lp:repowerd, if git understands that?)

Thanks, changed to https://git.launchpad.net/repowerd

> - It is more proper for the powerd dummy package to be "Arch: any" since it points at an "any" package.

I followed the instructions at https://wiki.debian.org/Renaming_a_Package , which note for the dummy package: "Note that the package does not contain any architecture specific files anymore and therefore the Architecture is set to "All", even if it was "Any" before."

> - I see REPOWERD_DISABLE_TIME_SENSITIVE_TESTS=ON in debian/rules. Is there something that does run the time sensitive tests? CI Jenkins maybe? This might be a good spot to suggest adding a dep8 test that runs the full test suite.

The time sensitive tests (will) run in repowerd CI jenkins. Initial I had them enabled for ci-train too, but encountered spurious failures when building in ci-train due to high builder load.

> - dh_installinit seems to be a little confused? It inserts code into postinst and prerm to stop and start the init.d job. But repowerd only installs an upstart job and a systemd job...

Is there something I can do to change this? I don't reference init.d at all in my debian config files.

[Michael Terry (mterry)]

OK, my comments got addressed in latest version. Thanks! I'm +1 on this now.

[Jeremy Bícha (jbicha)]

repowerd is available in Ubuntu 16.10