[needs packaging] arc-firefox-theme

[fossfreedom]

As part of applying for official status for "Ubuntu Budgie", the technical board has requested that the team add our packages to the Ubuntu repos (universe).

"Ubuntu Budgie" will initially consist of eight 17.04 packages - the remaining packages that are not already in the zesty archive are listed here in the PPA description.

 - https://launchpad.net/~budgie-remix/+archive/ubuntu/zesty-proposed

arc-firefox-theme is a key upstream package that forms the visual look of Ubuntu Budgie. We intend to support this package as Ubuntu only. Upstream updates its source following the firefox release cycle.

We intend to update during the development cycle as per upstream. Towards the end of the development cycle we will add a patch to ensure the update of the package during the yakkety release is not needed. Any further updates will follow standard patch update release mechanism

https://launchpad.net/~budgie-remix/+archive/ubuntu/zesty-proposed/+sourcepub/7128916/+listing-archive-extra

[Brian Murray (brian-murray)]

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

[Daniel Holbach (dholbach)]

Here are a few things found by lintian already, I'll take a closer look now too: http://paste.ubuntu.com/19059310/

[Daniel Holbach (dholbach)]

Why is debian/lintian-overrides necessary?

[Daniel Holbach (dholbach)]

./LICENSE is MPL 2.0, still debian/copyright says it's GPL-2.0+.

[fossfreedom (fossfreedom)]

many thanks Daniel for the feedback.

I have re-uploaded the package.

Copyright has been corrected.
linitian-overrides has been removed - rules have been changed to change the permissions of the offending .svg files.

The package description has been improved.

Note - for some reason I couldnt reupload the exact same package name as before - launchpad refused to build. So I suffixed the package version with ".1-0ubuntu1" to allow the build to happen.

[fossfreedom (fossfreedom)]

Latest upstream release has been uploaded.

[Daniel Holbach (dholbach)]

There are a few small things missing:

I: arc-firefox-theme source: binary-control-field-duplicates-source field "section" in package arc-firefox-theme
N:
N: In debian/control, this field for a binary package duplicates the value
N: inherited from the source package paragraph. This doesn't hurt anything,
N: but you may want to take advantage of the inheritance and set the value
N: in only one place. It prevents missing duplicate places that need to be
N: fixed if the value ever changes.
N:
N: Severity: wishlist, Certainty: certain
N:
N: Check: control-file, Type: source
N:
N: ----
N: Processing binary package arc-firefox-theme (version 48.20160802-0ubuntu1, arch amd64) ...
I: arc-firefox-theme: capitalization-error-in-description GTK GTK+
N:
N: Lintian found a possible capitalization error in the package
N: description. Lintian has a list of common capitalization errors,
N: primarily of upstream projects, that it looks for. It does not have a
N: dictionary like a spelling checker does.
N:
N: This is a particularly picky check of capitalization in package
N: descriptions, since they're very visible to end users, but it will have
N: false positives for project names used in a context where they should be
N: lowercase, such as package names or executable names.
N:
N: Severity: minor, Certainty: wild-guess
N:
N: Check: description, Type: binary, udeb
N:
I: arc-firefox-theme: capitalization-error-in-description XFCE Xfce

[Daniel Holbach (dholbach)]

Apart from that it looks good to me.

[fossfreedom (fossfreedom)]

Daniel,

  can I apologise for that - I thought I caught all of those.

I've rebuilt the package with the changes requested.

tested both the .deb and _source.changes file with lintian -i -I and it returns lintian free.

David

[fossfreedom (fossfreedom)]

Hi,
  I have uploaded the latest upstream build into our zesty proposed archive. Please can this be considered for inclusion?

[Daniel Holbach (dholbach)]

This looks good. Just one more small thing:

N: Processing source package arc-firefox-theme (version 49.20160920, arch source) ...
W: arc-firefox-theme source: non-native-package-with-native-version
N:
N: This package has a native version number (a version number without a
N: dash and a Debian portion) but is built as a non-native package. Usually
N: this is an error caused by forgetting the Debian revision for a
N: non-native package. In this case the solution is to add a Debian
N: revision.
N:
N: This error can also happen if the package is a 1.0 source format and
N: there is a stray *.orig.tar.gz file in the parent directory. The file
N: will trick dpkg-source into believing it was supposed to be a non-native
N: package. Here the error can be solved by converting it to 3.0 (native)
N: package or removing/renaming the *.orig.tar.gz file.
N:
N: If you do not know what a "native" or a "non-native" package is, you are
N: very likely working on a non-native package.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: cruft, Type: source

Should this be 49.20160920-0ubuntu1 instead?

[fossfreedom (fossfreedom)]

Hi Daniel,

  apologies for this. Quite correct - it should be as you have stated moving forward through zesty proper so I have reuploaded with the correct version numbering.

I've doubled checked the revised built package (linitian -i -I) as well as the source package and is lintian free.

cheers

David

[fossfreedom (fossfreedom)]

latest upstream version has been uploaded.

[fossfreedom (fossfreedom)]

ok - going to withdraw this request. We are going down a completely different track now via Ubuntu Budgie's budgie-welcome app.

Thanks for your help on this Daniel.

Unsubscribing Ubuntu Sponsors.