[needs-packaging] unity-china-photo-scope
Bug #1203958 reported by
Jack Yu
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Kylin |
Fix Released
|
Critical
|
Jack Yu | ||
Ubuntu |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
"unity-
URL: https:/
License: GPL V3+
Notes: Comes in stable versions (1.1).
Related branches
Changed in ubuntukylin: | |
milestone: | none → alpha-2 |
assignee: | nobody → Jack Yu (yj-1325) |
importance: | Undecided → Critical |
tags: | added: needs-packaging |
Changed in ubuntukylin: | |
status: | New → In Progress |
Changed in ubuntu: | |
status: | New → In Progress |
Changed in ubuntukylin: | |
status: | In Progress → Fix Committed |
milestone: | alpha-2 → beta-1 |
Changed in ubuntu: | |
status: | Fix Committed → Fix Released |
Changed in ubuntukylin: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I see a number of problems with this packaging. Since this is the initial upload, I think it's best to fix this before it gets uploaded.
The d/changelog entry should refer to this bug, e.g.
=== modified file 'debian/changelog' china-photo- scope (1.1-0ubuntu1) saucy; urgency=low
--- debian/changelog 2013-07-23 04:53:42 +0000
+++ debian/changelog 2013-07-23 18:59:51 +0000
@@ -1,6 +1,6 @@
unity-
- * Initial release.
+ * Initial release. (LP: #1203958)
-- Ubuntu daily release <email address hidden> Wed, 05 Jun 2013 06:08:36 +0000
I'm not sure why you should need python- distutils- extra since this is a Python 3 package, but it does seem like you do, otherwise pyversions fails. It would be useful to track this down, but not critical.
The source package stanza in d/control should include
X-Python3-Version: >= 3.2
It would be nice (but not critical) if lines were wrapped to 79 characters and extraneous trailing whitespace were removed.
The d/watch file has an incorrect regexp. Please check that `uscan --report --force` can find your tarball. Here's what I did:
=== modified file 'debian/watch' launchpad. net/unity- china-photo- scope/+ download .*/unity- china-photo- scope-( [0-9.]+ )\.tar\ .gz /launchpad. net/unity- china-photo- scope/+ download https:/ /launchpad. net/unity- china-photo- scope/. */unity- china-photo- scope-( .*)\.tar\.gz
--- debian/watch 2013-07-18 06:31:02 +0000
+++ debian/watch 2013-07-23 20:05:11 +0000
@@ -1,2 +1,2 @@
-version=1
-http://
+version=3
+https:/
You should include a debian/ source/ format file containing:
3.0 (quilt)
Please do a local build with either sbuild or pbuilder and take a look at the lintian warnings both for the source package and binary packages:
Now running lintian... photo-scope source: comma-separated -files- in-dep5- copyright paragraph at line 22 photo-scope source: out-of- date-standards- version 3.9.3 (current is 3.9.4)
W: unity-china-
W: unity-china-
% lintian *.deb photo-scope: package- relation- with-self breaks: unity-china- photo-scope photo-scope: desktop- entry-lacks- main-category usr/share/ applications/ unity-china- photo-scope. desktop
W: unity-china-
W: unity-china-
Your source tarball also has some problems. It includes a pyc file that is properly ignored. (All pyc files get created at install time):
dpkg-source: warning: ignoring deletion of file build_i18n_ext.pyc
The source branch has some other anomalies that should get cleaned up:
* Why is there a debhelper.log, *.debhelper, and *.substvars files in debian/? unity-china- photo-scope directory there?
* Why is the debian/
* Since this is not a native package, nor is this a source branch, you probably don't want to include the upstream files in the branch. You should only need the debian directory, since the upstream tarball will be downloaded from Launchpad.
If you can fix these problems, myself or another patch pilot will gladly sponsor you.