| 2020-04-02 11:19:30 |
bugproxy |
bug |
|
|
added bug |
| 2020-04-02 11:19:32 |
bugproxy |
tags |
|
architecture-s39064 bugnameltc-184736 severity-high targetmilestone-inin1804 |
|
| 2020-04-02 11:19:33 |
bugproxy |
attachment added |
|
s390/pci: Recover handle in clp_set_pci_fn() (backport) https://bugs.launchpad.net/bugs/1870320/+attachment/5344753/+files/0001-s390-pci-Recover-handle-in-clp_set_pci_fn.patch |
|
| 2020-04-02 11:19:35 |
bugproxy |
ubuntu: assignee |
|
Skipper Bug Screeners (skipper-screen-team) |
|
| 2020-04-02 11:19:38 |
bugproxy |
affects |
ubuntu |
linux (Ubuntu) |
|
| 2020-04-02 12:59:03 |
Frank Heimes |
bug task added |
|
ubuntu-z-systems |
|
| 2020-04-02 12:59:16 |
Frank Heimes |
ubuntu-z-systems: status |
New |
Triaged |
|
| 2020-04-02 12:59:51 |
Frank Heimes |
ubuntu-z-systems: assignee |
|
Skipper Bug Screeners (skipper-screen-team) |
|
| 2020-04-02 13:00:09 |
Frank Heimes |
linux (Ubuntu): assignee |
Skipper Bug Screeners (skipper-screen-team) |
Canonical Kernel Team (canonical-kernel-team) |
|
| 2020-04-09 04:09:23 |
Po-Hsu Lin |
nominated for series |
|
Ubuntu Bionic |
|
| 2020-04-09 04:09:23 |
Po-Hsu Lin |
bug task added |
|
linux (Ubuntu Bionic) |
|
| 2020-04-09 04:09:38 |
Po-Hsu Lin |
linux (Ubuntu): status |
New |
Fix Released |
|
| 2020-04-09 04:10:00 |
Po-Hsu Lin |
linux (Ubuntu Bionic): status |
New |
Confirmed |
|
| 2020-04-09 05:22:19 |
Frank Heimes |
ubuntu-z-systems: status |
Triaged |
Confirmed |
|
| 2020-05-06 18:23:21 |
Frank Heimes |
nominated for series |
|
Ubuntu Eoan |
|
| 2020-05-06 18:23:21 |
Frank Heimes |
bug task added |
|
linux (Ubuntu Eoan) |
|
| 2020-05-06 18:23:34 |
Frank Heimes |
linux (Ubuntu Eoan): status |
New |
Fix Released |
|
| 2020-05-06 18:23:51 |
Frank Heimes |
nominated for series |
|
Ubuntu Groovy |
|
| 2020-05-06 18:23:51 |
Frank Heimes |
bug task added |
|
linux (Ubuntu Groovy) |
|
| 2020-05-06 18:23:51 |
Frank Heimes |
nominated for series |
|
Ubuntu Focal |
|
| 2020-05-06 18:23:51 |
Frank Heimes |
bug task added |
|
linux (Ubuntu Focal) |
|
| 2020-05-06 18:24:02 |
Frank Heimes |
linux (Ubuntu Focal): status |
New |
Fix Released |
|
| 2020-05-06 18:34:32 |
Frank Heimes |
linux (Ubuntu Eoan): status |
Fix Released |
New |
|
| 2020-05-07 08:15:35 |
Frank Heimes |
linux (Ubuntu Groovy): assignee |
Canonical Kernel Team (canonical-kernel-team) |
|
|
| 2020-05-07 13:21:54 |
Frank Heimes |
linux (Ubuntu Eoan): status |
New |
Fix Released |
|
| 2020-05-07 18:29:23 |
bugproxy |
attachment added |
|
0001-s390-pci-Fix-possible-deadlock-in-recover_store.patch https://bugs.launchpad.net/bugs/1870320/+attachment/5367946/+files/0001-s390-pci-Fix-possible-deadlock-in-recover_store.patch |
|
| 2020-05-13 12:49:39 |
bugproxy |
attachment added |
|
s390/pci: Recover handle in clp_set_pci_fn() (backport) https://bugs.launchpad.net/bugs/1870320/+attachment/5370907/+files/0001-s390-pci-Recover-handle-in-clp_set_pci_fn.patch |
|
| 2020-05-13 16:16:29 |
Frank Heimes |
description |
This Bug tracks the necessary backport for the Linux Kernel
to enable proper reset/recovery of PCI Functions in the error state.
There is a related fix to s390-tools but the relevant zpcictl command
is not part of Ubuntu 18.04
Upstream this includes the following commits:
In the Kernel:
17cdec960cf776b20b1fb08c622221babe591d51 s390/pci: Recover handle in clp_set_pci_fn()
Backport patch attached.
576c75e36c689bec6a940e807bae27291ab0c0de s390/pci: Fix possible deadlock in recover_store()
applies cleanly but for the second a small backport change is necessary.
These fixes are already in 20.04 but need also be applied to 18.04. |
SRU Justification:
==================
[Impact]
* With zpci_disable() working, 'lockdep' detected a potential deadlock (in the s390x zPCI subsystem).
* The deadlock is between recovering a PCI function via the /sys/bus/pci/devices/<dev>/recover attribute vs powering it off via /sys/bus/pci/slots/<slot>/power.
[Fix]
* Backport 1: https://launchpadlibrarian.net/479554961/0001-s390-pci-Recover-handle-in-clp_set_pci_fn.patch
* Backport 2: https://launchpadlibrarian.net/478714295/0001-s390-pci-Fix-possible-deadlock-in-recover_store.patch
[Test Case]
* It's best to (re-)test using the kernel's locking validator, also known as 'lockdep'.
* Since this potential deadlock was identified by lockdep.
[Regression Potential]
* The regression potential can be considered as moderate, since:
* It is purely s390x specific code (arch/s390/include/asm/pci.h and arch/s390/pci/{pci.c,pci_clp.c,pci_sysfs.c}).
* It only affects the zPCI, the s390x specific PCI code layer.
* PCI cards available for s390x are optional cards (RoCE and zEDC) and not very wide-spread.
* The states between such a deadlock can happen (recover and power off) are non standard and usually undesired states.
* The patches are upstream accepted since 5.6 and already landed in eoan and focal.
[Other Info]
* Patches 17cdec960cf7 "s390/pci: Recover handle in clp_set_pci_fn()" and 576c75e36c68 "s390/pci: Fix possible deadlock in recover_store()" are upstream accepted since kernel 5.6, but they don't apply cleanly on bionic master-next, hence backports are needed:
* 0001-s390-pci-Recover-handle-in-clp_set_pci_fn.patch is a backport of 17cdec960cf776b20b1fb08c622221babe591d51 17cdec960cf7 "s390/pci: Recover handle in clp_set_pci_fn()"
* 0001-s390-pci-Fix-possible-deadlock-in-recover_store.patch is a backport of 576c75e36c689bec6a940e807bae27291ab0c0de 576c75e36c68 "s390/pci: Fix possible deadlock in recover_store()"
* Both patches/commits already landed in focal (with LP 1863768) and in eoan (with LP 1868324).
__________
This Bug tracks the necessary backport for the Linux Kernel
to enable proper reset/recovery of PCI Functions in the error state.
There is a related fix to s390-tools but the relevant zpcictl command
is not part of Ubuntu 18.04
Upstream this includes the following commits:
In the Kernel:
17cdec960cf776b20b1fb08c622221babe591d51 s390/pci: Recover handle in clp_set_pci_fn()
Backport patch attached.
576c75e36c689bec6a940e807bae27291ab0c0de s390/pci: Fix possible deadlock in recover_store()
applies cleanly but for the second a small backport change is necessary.
These fixes are already in 20.04 but need also be applied to 18.04. |
|
| 2020-05-13 16:16:52 |
Frank Heimes |
linux (Ubuntu Bionic): status |
Confirmed |
In Progress |
|
| 2020-05-13 16:16:56 |
Frank Heimes |
ubuntu-z-systems: status |
Confirmed |
In Progress |
|
| 2020-05-15 04:28:53 |
Khaled El Mously |
linux (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2020-05-15 04:52:25 |
Frank Heimes |
ubuntu-z-systems: status |
In Progress |
Fix Committed |
|
| 2020-05-19 18:06:00 |
Ubuntu Kernel Bot |
tags |
architecture-s39064 bugnameltc-184736 severity-high targetmilestone-inin1804 |
architecture-s39064 bugnameltc-184736 severity-high targetmilestone-inin1804 verification-needed-bionic |
|
| 2020-05-20 13:31:24 |
Frank Heimes |
tags |
architecture-s39064 bugnameltc-184736 severity-high targetmilestone-inin1804 verification-needed-bionic |
architecture-s39064 bugnameltc-184736 severity-high targetmilestone-inin1804 verification-done-bionic |
|
| 2020-06-09 21:09:10 |
Launchpad Janitor |
linux (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2020-06-09 21:09:10 |
Launchpad Janitor |
cve linked |
|
2020-0543 |
|
| 2020-06-10 06:18:20 |
Frank Heimes |
ubuntu-z-systems: status |
Fix Committed |
Fix Released |
|
