Distroseries category listing inconsistent

[John Pugh]

The view of https://apps.ubuntu.com/cat/applications/qreator/ and the view of https://apps.ubuntu.com/cat/applications/precise/qreator/ are inconsistent.

The distroseries view is:
 missing screenshots
 has a different download button
 lists the application license different
 is missing the icon
 lists a rating and reviews on the header

[John Pugh (jpugh)]

This issue does appear to be ARB app specific.

[Michael Nelson (michael.nelson)]

Anthony can confirm via the /admin/, but my assumption would be that we've got two separate qreator applications for the same distroseries - one that has been imported from extras.ubuntu.com, the other that has been imported from sca's "for purchase" api (which is really not just apps for purchase anymore).

I'm assuming we should not be creating a new app, but rather updating an existing app with the for-purchase API data (assuming it will be more up-to-date?).

[Anthony Lenton (elachuni)]

Indeed, currently both import_for_purhcase_apps and import_app_install_data are creating Application instances for qreator.

If there is data in MyApps for an app, import_app_install_data should not update this, as we assume MyApps will have more up-to-date information.

Neither commands should create another instance for the same package_name and distroseries if one already exists.

import_app_install_data could check if the app has a non-null "Application id" field, and keep its hands off the app entirely if so.

[Michael Nelson (michael.nelson)]

On Thu, Jun 21, 2012 at 5:55 PM, Anthony Lenton
<email address hidden> wrote:
> If there is data in MyApps for an app, import_app_install_data should
> not update this, as we assume MyApps will have more up-to-date
> information.
>
> Neither commands should create another instance for the same
> package_name and distroseries if one already exists.

Yep, makes sense.

>
> import_app_install_data could check if the app has a non-null
> "Application id" field, and keep its hands off the app entirely if so.

For bug 1015505 I'll be renaming Application.for_purchase to
Application.imported_from_sca which will enable us to know when to
overwrite and when not. I'll fix this at the same time.

[Michael Nelson (michael.nelson)]

Here is the full list of apps on production that have duplicate entries for package_name/distroseries: https://pastebin.canonical.com/69052/