Pep8 test issues
Bug #1007626 reported by
Danny Tamez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Software Center Agent |
Fix Released
|
Low
|
Danny Tamez | ||
| Ubuntu Apps Directory |
Fix Released
|
Medium
|
Natalia Bidart | ||
Bug Description
When running tests in SCA there are two issues. The first is that pep8 failures are no longer captured by the tester and thus no longer cause the test suite to fail. The second is that the recent update (1.2) of the pep8 checker is now reporting copious amounts of E125, E127 and E128 errors (all dealing wiht line continuations). According to the changelog these should be disabled by default. A decision needs to be made as to whether we want to leave these enabled and fix our source code or disable these when the tests are run.
Related branches
lp:~nataliabidart/ubuntu-webcatalog/law-and-order.1
- Anthony Lenton (community): Approve
-
Diff: 511 lines (+78/-72)13 files modifiedsrc/webcatalog/api/forms.py (+2/-2)
src/webcatalog/api/handlers.py (+1/-1)
src/webcatalog/api/urls.py (+5/-4)
src/webcatalog/management/commands/check_all_latest.py (+4/-4)
src/webcatalog/management/commands/cleanup.py (+6/-4)
src/webcatalog/management/commands/import_app_install_data.py (+21/-18)
src/webcatalog/management/commands/import_exhibits.py (+5/-5)
src/webcatalog/management/commands/import_for_purchase_apps.py (+2/-3)
src/webcatalog/management/commands/import_ratings_stats.py (+3/-3)
src/webcatalog/middleware/exception.py (+3/-3)
src/webcatalog/models/applications.py (+19/-17)
src/webcatalog/models/oauthtoken.py (+4/-5)
src/webcatalog/templatetags/webcatalog.py (+3/-3)
lp:~nataliabidart/ubuntu-webcatalog/law-and-order.2
- Anthony Lenton (community): Approve
-
Diff: 671 lines (+111/-103)13 files modifiedsrc/webcatalog/admin.py (+4/-4)
src/webcatalog/auth.py (+18/-17)
src/webcatalog/context_processors.py (+2/-1)
src/webcatalog/department_filters.py (+9/-7)
src/webcatalog/forms.py (+5/-5)
src/webcatalog/hw.py (+12/-12)
src/webcatalog/managers.py (+2/-2)
src/webcatalog/preflight.py (+2/-2)
src/webcatalog/schema.py (+5/-5)
src/webcatalog/urls.py (+7/-7)
src/webcatalog/utilities.py (+13/-12)
src/webcatalog/views.py (+31/-28)
src/webcatalog/wsgi.py (+1/-1)
lp:~nataliabidart/ubuntu-webcatalog/law-and-order.3
- Anthony Lenton (community): Approve
-
Diff: 2711 lines (+567/-540)16 files modifiedsrc/webcatalog/tests/factory.py (+24/-20)
src/webcatalog/tests/helpers.py (+2/-2)
src/webcatalog/tests/test_api.py (+32/-31)
src/webcatalog/tests/test_commands.py (+109/-97)
src/webcatalog/tests/test_context_processors.py (+1/-1)
src/webcatalog/tests/test_department_filters.py (+3/-3)
src/webcatalog/tests/test_forms.py (+42/-43)
src/webcatalog/tests/test_handlers.py (+9/-10)
src/webcatalog/tests/test_managers.py (+9/-9)
src/webcatalog/tests/test_models.py (+75/-65)
src/webcatalog/tests/test_pep8.py (+14/-16)
src/webcatalog/tests/test_preflight.py (+3/-3)
src/webcatalog/tests/test_templatetags.py (+26/-35)
src/webcatalog/tests/test_utilities.py (+27/-28)
src/webcatalog/tests/test_views.py (+189/-175)
src/webcatalog/views.py (+2/-2)
| Changed in ubuntu-webcatalog: | |
| status: | New → In Progress |
| assignee: | nobody → Natalia Bidart (nataliabidart) |
| importance: | Undecided → Medium |
| Changed in ubuntu-webcatalog: | |
| status: | In Progress → Fix Committed |
| Changed in software-center-agent: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in software-center-agent: | |
| assignee: | nobody → Danny Tamez (zematynnad) |
| status: | Confirmed → Fix Committed |
| Changed in ubuntu-webcatalog: | |
| status: | Fix Committed → Fix Released |
| Changed in software-center-agent: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
