Core.js from Assets causes console warning regarding ReferenceError

Bug #1392723 reported by JoshuaStrobl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu web style guide
Triaged
Medium
Unassigned

Bug Description

It really is a minor thing, but in core.js from assets.ubuntu.com, under the core.svgFallback function (like 179), rather than saying if (typeof Modernizr !== "undefined") you directly state if (Modernizr). Changing it to do a comparison between typeof Modernizr and undefined should stop the ReferenceError from showing up in the console.

affects: ubuntu-website → ubuntu-web-style-guide
Changed in ubuntu-web-style-guide:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
JoshuaStrobl (joshua.strobl) wrote :

I filed a merge request, though I am not sure if I did it correctly. Merging on Launchpad isn't as clear of a process as it is on GitHub. https://code.launchpad.net/~canonical-webmonkeys/ubuntu-web-style-guide/trunk/+merge/241844

Revision history for this message
JoshuaStrobl (joshua.strobl) wrote :

So it seems the process is completely backwards from how GitHub does it. I created a new merge request: https://code.launchpad.net/~truthfromlies/ubuntu-web-style-guide/modernizr-fix/+merge/241845

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.