Include the key.js file in the source tree

[Nekhelesh Ramananthan]

Is there any reason why we aren't including the key.js file in the source tree? Either way weather app is an open-source app and thereby anyone can grab the key by looking at the installed files of the weather app. It is just an unnecessary step for developers and is incredibly annoying.

[Victor Thompson (vthompson)]

I agree that it's inconvenient, however, API keys for external services are something that should be managed at configuration/build time of the app. Any subsequent fork of the project shouldn't inherit an API key and should file for their own. One option could be to obfuscate the key--however, I assume this isn't acceptable either.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

We agreed this with the data provider. We can re-visit it, but they were concerned about key leakage, despite it not being hidden particularly well.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-weather-app/reboot at revision 64, scheduled for release in ubuntu-weather-app, milestone 2.0