[reboot] Location names in the LocationsPage should elide
Bug #1469460 reported by
Victor Thompson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Weather App |
Fix Released
|
Low
|
Nekhelesh Ramananthan |
Bug Description
The name of the locations can overlap with the weather icon to the right. The text should elide so it does not overlap.
Related branches
lp:~nik90/ubuntu-weather-app/finish-listitem-migration
Rejected
for merging
into
lp:ubuntu-weather-app
- Nekhelesh Ramananthan (community): Disapprove
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Victor Thompson: Needs Fixing
-
Diff: 1514 lines (+224/-973)15 files modifiedapp/components/CMakeLists.txt (+0/-2)
app/components/FakeHeader.qml (+39/-0)
app/components/ListItemActions/CMakeLists.txt (+0/-5)
app/components/ListItemActions/CheckBox.qml (+0/-25)
app/components/ListItemActions/Remove.qml (+0/-27)
app/components/ListItemReorderComponent.qml (+0/-106)
app/components/ListItemWithActions.qml (+0/-496)
app/components/MultiSelectHeadState.qml (+0/-72)
app/components/MultiSelectListView.qml (+27/-8)
app/components/PageWithBottomEdge.qml (+68/-18)
app/components/WeatherListItem.qml (+0/-137)
app/components/WeatherListView.qml (+1/-2)
app/ui/LocationsPage.qml (+82/-53)
po/com.ubuntu.weather.pot (+6/-22)
ubuntu-weather-app.desktop.in.in (+1/-0)
lp:~vthompson/ubuntu-weather-app/fix-1469460
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Andrew Hayzen: Approve
-
Diff: 76 lines (+8/-1)3 files modifiedapp/ui/AddLocationPage.qml (+2/-0)
app/ui/LocationsPage.qml (+5/-1)
debian/changelog (+1/-0)
Changed in ubuntu-weather-app: | |
milestone: | none → 2.0 |
assignee: | nobody → Nekhelesh Ramananthan (nik90) |
status: | Triaged → In Progress |
Changed in ubuntu-weather-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-weather-app/reboot at revision 123, scheduled for release in ubuntu-weather-app, milestone 2.0