Units settings are not translatable
Bug #1324578 reported by
David Planella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Weather App |
Fix Released
|
Medium
|
Martin Borho | ||
Bug Description
It seems that in the settings page all options appear in English regardless of the locale chosen. They're not marked for translation in the code, and thus they've not been translated.
I realize this is due to bug 1324576, but I'm wondering whether we can use a workaround
Related branches
lp:~martin-borho/ubuntu-weather-app/fix-1324578-optionselectors-xlated
- David Planella: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 434 lines (+164/-125)4 files modifiedcomponents/SettingsSheet.qml (+32/-14)
po/com.ubuntu.weather.pot (+125/-105)
tests/autopilot/ubuntu_weather_app/tests/__init__.py (+4/-3)
tests/autopilot/ubuntu_weather_app/tests/test_locationmanager.py (+3/-3)
| Changed in ubuntu-weather-app: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Martin Borho (martin-borho) wrote | #1 |
| Changed in ubuntu-weather-app: | |
| assignee: | nobody → Martin Borho (martin-borho) |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #2 |
| Changed in ubuntu-weather-app: | |
| status: | Triaged → Fix Committed |
| Changed in ubuntu-weather-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think, it would be ok to define the localized labels as properties in the Sheet, as mentioned elsewhere.