Sometimes, the temperature and conditions are not shown

Bug #1287446 reported by Leo Arias
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu Weather App
Fix Released
Undecided
Martin Borho

Bug Description

If I open the weather app and everything is alright, I get an orange screen for less than a second and then it turns to light blue, showing the temperature. (see first attachment)

Sometimes, it fails and gets stuck on the orange screen. (see second attachment) When that happens, you will get the autopilot error messages we are seeing on the dashboard. This one for example http://ci.ubuntu.com/smokeng/trusty/touch/mako/217:20140303:20140301.1/6943/ubuntu_weather_app/844095/

I could get the error condition one time out of five, more or less. This is with mako, r218.

Tags: elopio qa-new

Related branches

Revision history for this message
Leo Arias (elopio) wrote :
Revision history for this message
Leo Arias (elopio) wrote :
Leo Arias (elopio)
summary: - Sometimes, the weather and conditions are not shown
+ Sometimes, the temperature and conditions are not shown
description: updated
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Leo, do you think this is simply network issues? I was curious I was findings issues with refreshing when I didn't have a solid connection.

Revision history for this message
Martin Borho (martin-borho) wrote :

Hi Leo,

I'll have a look at it. Does this happpens also in this frequency on the device or only in ap tests?

A network issue can be ruled out at that specific test, since it grabs its data from the storage at that point. Which revision of the weather app have you used?

Cheers
Martin

Revision history for this message
Sam Bull (dreamsorcerer) wrote :

I don't know if this is the same thing, but sometimes the networking seems overly finicky on 3G. I've observed this behaviour on both the weather app and on the system settings checking for updates. It seems like the networking is failing to respond and it spins indefinitely, but if I open a browser I can load Google within a few seconds.

I last observed this yesterday, checking for updates on the way home, it wouldn't make it past the spinning activity indicator, even though I was able to switch to the browser and load Google repeatedly. I tried restarting system settings several times, and it didn't help, it refused to work until I was connected to WiFi.

This is on mako running the last promoted image.

Revision history for this message
Victor Thompson (vthompson) wrote :

I only connect via Wifi and can also reproduce this occasionally. When I do, I get the following in the log:

file:///usr/share/click/preinstalled/com.ubuntu.weather/1.1.211/components/LocationTab.qml:56: TypeError: Cannot read property 'year' of undefined.

Revision history for this message
Martin Borho (martin-borho) wrote :

Interesting, Victor. It indicates that certain parts of the data are missing, or the data at all is unavailable at that moment.

Does this happens at the specific AP tests Leo mentioned? (switching from celisus to fahrenheit or vice versa) In that particular case the data is from storage, without any reloading over the network.

Can you reproduce this for both data providers, OWM and TWC?

Haven't any success in reproducing this for now.

Revision history for this message
Martin Borho (martin-borho) wrote :

Worth to mention, that Openweathermap has regularly issues with availability or other bugs. For instance yesterday some tests failed, because of a erroneous responses from their side, which were fixed shortly after.

Revision history for this message
Leo Arias (elopio) wrote :

This happens just upon opening the application, on the phone.
It happens opening it manually, or opening it with the autopilot scripts.

If it's a slow network issue, or a bad response from the remote side, we should still display a message to the user so he knows what's going on. Something like: couldn't connect, try again later clicking the refresh button.

Thanks for looking into this!

Changed in ubuntu-weather-app:
status: New → Confirmed
Revision history for this message
Leo Arias (elopio) wrote :

Oh, and I deployed it from trunk with click buddy to run the tests.

Revision history for this message
Martin Borho (martin-borho) wrote :

I assume you have the TWC keys added. Actually, there should be a message displayed if there is a network issue.

Do you have access to the application logs?

I'll try get this reproduced!

Revision history for this message
Martin Borho (martin-borho) wrote :

I'm still on mako r194 and I cannot reproduce these errors.

I ran the autopilot tests on the device several times. With md5'ing system.img 3x in parallel with a constant load around 6-7 while testing.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Reproduced this simply by running ubuntu_weather_app.tests.test_settings.TestSettings set of 5 tests over and over. They will fail in a few different ways, this being one of them. Both mako and flo exhibit this on r220 image.

Revision history for this message
Martin Borho (martin-borho) wrote :

Yes, installed a rom with rev219 and it's pretty obvious now :)

First guess is, that this perhaps is related to localstorage or something else on the JS side, but will look now deeply.

Revision history for this message
Martin Borho (martin-borho) wrote :

After some investigation, it seems that WorkerScript sometimes strips objects from the data send in.

You can see it in the json files attached. One is the data send to the WorkerScript, the second shows the data as it arrives in the worker script.

What is strange: the same data can work the next time without problem, as it seems.

Revision history for this message
Martin Borho (martin-borho) wrote :

Here is the data as it arrives in the WorkerScript

Changed in ubuntu-weather-app:
assignee: nobody → Martin Borho (martin-borho)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-weather-app at revision 216, scheduled for release in ubuntu-weather-app, milestone alpha-1

Changed in ubuntu-weather-app:
status: Confirmed → Fix Committed
Changed in ubuntu-weather-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.