Binding loop detected when changing backgroundColor of MainView dynamically
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Sudoku App |
Medium
|
Unassigned | ||
| Ubuntu Weather App |
High
|
Martin Borho | ||
| ubuntu-ui-toolkit (Ubuntu) |
Undecided
|
Zsombor Egri | ||
| Vivid |
Undecided
|
Unassigned |
Bug Description
When changing the backgroundColor of MainView programmatically, a binding loop occurs:
file://
file://
file://
file://
file://
file://
file://
file://
file://
file://
file://
file://
Related branches
- Tim Peeters: Approve (quick look) on 2014-11-28
- Christian Dywan: Approve on 2014-11-27
-
Diff: 529 lines (+370/-21)16 files modifiedexamples/customtheme/customtheme.apparmor (+8/-0)
examples/customtheme/customtheme.desktop (+8/-0)
examples/customtheme/customtheme.qmlproject (+59/-0)
examples/customtheme/main.qml (+103/-0)
examples/customtheme/manifest.json (+15/-0)
examples/customtheme/theme/Palette.qml (+24/-0)
examples/customtheme/theme/parent_theme (+1/-0)
modules/Ubuntu/Components/MainView.qml (+16/-0)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+0/-17)
modules/Ubuntu/Components/plugin/uctheme.cpp (+4/-2)
tests/unit_x11/tst_components/tst_theming.qml (+60/-0)
tests/unit_x11/tst_theme_engine/AppTheme/Palette.qml (+24/-0)
tests/unit_x11/tst_theme_engine/AppTheme/parent_theme (+1/-0)
tests/unit_x11/tst_theme_engine/TestApp.qml (+29/-0)
tests/unit_x11/tst_theme_engine/tst_theme_engine.pro (+3/-1)
tests/unit_x11/tst_theme_engine/tst_theme_enginetest.cpp (+15/-1)
- PS Jenkins bot: Approve (continuous-integration) on 2014-12-05
- Christian Dywan: Approve on 2014-12-04
-
Diff: 518 lines (+368/-20)16 files modifiedexamples/customtheme/customtheme.apparmor (+8/-0)
examples/customtheme/customtheme.desktop (+8/-0)
examples/customtheme/customtheme.qmlproject (+59/-0)
examples/customtheme/main.qml (+103/-0)
examples/customtheme/manifest.json (+15/-0)
examples/customtheme/theme/Palette.qml (+24/-0)
examples/customtheme/theme/parent_theme (+1/-0)
modules/Ubuntu/Components/MainView.qml (+16/-0)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+0/-17)
modules/Ubuntu/Components/plugin/uctheme.cpp (+3/-1)
tests/unit_x11/tst_components/tst_theming.qml (+60/-0)
tests/unit_x11/tst_theme_engine/AppTheme/Palette.qml (+24/-0)
tests/unit_x11/tst_theme_engine/AppTheme/parent_theme (+1/-0)
tests/unit_x11/tst_theme_engine/TestApp.qml (+29/-0)
tests/unit_x11/tst_theme_engine/tst_theme_engine.pro (+3/-1)
tests/unit_x11/tst_theme_engine/tst_theme_enginetest.cpp (+14/-1)
Changed in ubuntu-weather-app: | |
importance: | Undecided → High |
Tim Peeters (tpeeters) wrote : | #1 |
Martin Borho (martin-borho) wrote : | #2 |
import QtQuick 2.0
import Ubuntu.Components 0.1
MainView {
// objectName for functional testing purposes (autopilot-qt5)
objectName: "mainView"
// Note! applicationName needs to match the .desktop filename
application
backgroundC
width: units.gu(25)
height: units.gu(25)
Page {
title: i18n.tr("Simple")
Button {
width: parent.width
text: i18n.tr("Tap me!")
}
}
}
}
Martin Borho (martin-borho) wrote : | #3 |
Should just display nice the binding loop errors.
Cheers
Martin
Changed in ubuntu-ui-toolkit: | |
status: | New → Confirmed |
assignee: | nobody → Florian Boucault (fboucault) |
Changed in sudoku-app: | |
importance: | Undecided → Medium |
Changed in ubuntu-weather-app: | |
status: | New → Triaged |
Changed in sudoku-app: | |
status: | New → Triaged |
Changed in ubuntu-ui-toolkit: | |
assignee: | Florian Boucault (fboucault) → Zsombor Egri (zsombi) |
Brad Wells (brad-4) wrote : | #4 |
This bug seems to occur when changing from a dark theme to a light theme. The background color can be changed without errors if isLight of MainViewStyle does not have to toggle.
On devices, there is a bigger issue if the background color change is triggered from a hud action. In this case, going from light to dark causes the app to hang in a transition state.
Martin Borho (martin-borho) wrote : | #5 |
Fixed for weather app, since three different colours are used for the gradient background.
Changed in ubuntu-weather-app: | |
assignee: | nobody → Martin Borho (martin-borho) |
status: | Triaged → Fix Released |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
status: | New → Confirmed |
no longer affects: | ubuntu-ui-toolkit |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
Launchpad Janitor (janitor) wrote : | #6 |
This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1364+
---------------
ubuntu-ui-toolkit (1.1.1364+
[ Zsombor Egri ]
* Theming fixes: application theming, binding loop fix, auto-theming
moved into MainView and it is applicable only on Ambiance and
SuruDark, SuruGradient is no longer auto-themed.
Fixes: LP: #1213043, LP: #1277647, LP: #1330510, LP: #1356779,
LP: #1389792.
* ServiceProperties component to Ubuntu.Components 1.1.
Fixes: LP: #1391877.
* New ListItem component base. Support for leading/trailing actions.
Exported in Ubuntu.Components 1.2 UNSTABLE release.
Fixes: LP: #1097728, LP: #1372592, LP: #1383870.
* removing failing ServiceProperties and app-theming branches
* Application theming ant other theming related binding loop fixes
* ServiceProperties DBus property watcher
[ Christian Dywan ]
* Do the default theme check properly: for non-debug and without
build errors.
* Don't activate the control in ListItem.Standard implicitly.
Fixes: LP: #1372563.
* Improve AutoPilot caret dragging test cases.
* Use new qt_gl_set_
Fixes: LP: #1397979.
* Add sortCaseSensitivity to the SortFilterModel example.
Fixes: LP: #1391034.
* Change offending links into bold font. Fixes: LP: #1395011.
[ Daniel d'Andrada ]
* This is needed by unity8 for the "shell rotation" feature (ie
shell does all the rotation work instead of apps rotating
themselves). unity8's dialogs (like the power dialog when you
long press the power button) should follow its parent item
rotation and size, as one would expect, and not be sneakily
reparented to the scene root item, in which case the shell
UI would be rotated but its dialog would not.
Related bug LP: #1394511. Fixes: LP: #1394511.
[ Tim Peeters ]
* Remove the old header separator style. Fixes: LP: #1372590.
[ Loïc Molinari ]
* Made the UCAlarmPrivate destructor private.
[ Ubuntu daily release ]
* New rebuild forced
-- Ubuntu daily release <email address hidden> Tue, 09 Dec 2014 11:47:33 +0000
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Released |
no longer affects: | ubuntu-ui-toolkit (Ubuntu RTM) |
Could you please include a simple test program that exposes the issue? Thanks!