[Indicators] Volume notification unnecessary when adjusting volume slider
Bug #1484126 reported by
Jouni Helminen
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UX |
Fix Committed
|
Undecided
|
Jouni Helminen | ||
| unity8 (Ubuntu) |
Fix Released
|
Undecided
|
Lukáš Tinkl | ||
Bug Description
Current situation:
Go to Sound section of indicators, drag volume slider. The volume notification pops up, essentially replicating the slider below
Desired solution:
Let's remove the volume notification when sliding the the volume slider
Related branches
lp:~lukas-kde/unity8/volumeSliderNotification
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Albert Astals Cid (community): Approve
-
Diff: 60 lines (+10/-0)4 files modifiedqml/Components/VolumeControl.qml (+7/-0)
qml/Panel/IndicatorsBar.qml (+1/-0)
qml/Panel/IndicatorsMenu.qml (+1/-0)
qml/Shell.qml (+1/-0)
Revision history for this message
| Jouni Helminen (jounihelminen) wrote | #1 |
| Changed in ubuntu-ux: | |
| assignee: | nobody → Jouni Helminen (jounihelminen) |
| status: | New → Fix Committed |
Revision history for this message
| Charles Kerr (charlesk) wrote | #2 |
| affects: | indicator-network (Ubuntu) → indicator-sound (Ubuntu) |
| Changed in unity8 (Ubuntu): | |
| status: | New → Confirmed |
| Changed in indicator-sound (Ubuntu): | |
| status: | New → Invalid |
| Changed in unity8 (Ubuntu): | |
| status: | Confirmed → New |
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Lukáš Tinkl (lukas-kde) |
| Changed in unity8 (Ubuntu): | |
| status: | New → Confirmed |
| Changed in unity8 (Ubuntu): | |
| status: | Confirmed → In Progress |
| Changed in unity8 (Ubuntu): | |
| status: | In Progress → Fix Committed |
| no longer affects: | indicator-sound (Ubuntu) |
| Changed in unity8 (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
indicator-sound already has code to do this.
Unity needs to tell the sound indicator that the menu is visible by setting the "indicator-shown" action state to true.
This is why it works in Unity 7 -- if you go to the Unity 7 desktop, pull down the sound menu, and drag the slider, you don't get an information notification.