ListItem does not swipe with custom MouseAreas

Bug #1479688 reported by Michał Karnicki
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UX
Fix Committed
High
Femma
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Critical
Zsombor Egri

Bug Description

Expected:
ListItem with user avatar an an image/attachment. I want to be able to detect the click on the avatar or the image, so I need to place MouseAreas within the list view. This used to work with the old ListViewItemWithActions.

Actual:
ListItem does not allow a swipe when it starts on one of those mouse areas. Meaning, you have to look for "free" space where you can drag the item, which is not intuitive and clearly a UX annoyance.

UX Fix:

When a mouse is plugged in, the leading and trailing actions should be available in the contextual menu. Please look at https://docs.google.com/document/d/1nFm8xiYhKXXuEO_IvMXoD0lASbYzYXva1BWMVanU3iw/edit#heading=h.y7e1o2x66nvr pages 106-109.

Related branches

Revision history for this message
Zsombor Egri (zsombi) wrote :

Not even with active components, like Buttons.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → Zsombor Egri (zsombi)
Revision history for this message
Zsombor Egri (zsombi) wrote :

Swiping implies the ListItem being highlighted. Should we have the same when the swipe is initiated above an active component placed in the ListItem?

Revision history for this message
Olga Kemmet (olga-kemmet) wrote :

Wouldn't the above stated issue be solved with a right click on the list item, especially in a pointer environment?
We shouldn't have swipe active on pointer anyways.

Changed in ubuntu-ux:
assignee: nobody → Femma (femma)
importance: Undecided → High
status: New → Triaged
Revision history for this message
Zsombor Egri (zsombi) wrote :

So the swipe should only happen with touch?

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Femma (femma) wrote :

Yes, the swipe should only happen with touch. When a mouse is plugged in, the options will be displayed in the contextual menu.

Revision history for this message
Femma (femma) wrote :
Changed in ubuntu-ux:
status: Triaged → Fix Committed
description: updated
Revision history for this message
Zsombor Egri (zsombi) wrote :

Femma, what if I have both touch and mouse?

Revision history for this message
Femma (femma) wrote :

Then if you touch the screen you should be able to get the leading and trailing actions, if you use a mouse you should get the contextual menu. Depends on the input of choice.

Revision history for this message
Zsombor Egri (zsombi) wrote :

I'm sorry to be a pain here, but how about testing it during development? We do not have any ways to run an application on desktop to test touch behaviour, and developers may not have a device on their disposal, and using the emulator is anything but easy... so I'd still like to challenge the idea of not swiping leading/trailing actions using mouse.

Revision history for this message
Femma (femma) wrote :

Zsombor, we aren't swiping leading/trailing actions using a mouse, it will be a right click contextual menu with a mouse.

Revision history for this message
Zsombor Egri (zsombi) wrote :

We don't, but users will! If Joe average will get a phone in his hand first, he will swipe on the lists, right? Then he will see the desktop, the same UI, and will try to swipe as well. That won't work there, but then (s)he will realise it'll be right click... then (s)he will be confused, kicks the whole baggage into the trash bin and will use Mac/Windows/whatever.

Of course user won't swipe with mouse, will drag. And I know it will be a right click, it is already a right click.

Revision history for this message
Femma (femma) wrote :

There aren't many apps on desktop with leading and trailing list items, so I think that situation will be few and far between.

Revision history for this message
Zsombor Egri (zsombi) wrote :

So as of stakeholders meeting clarified, there should be no distinction between touch and mouse handling. Whatever can be done with touch should be doable with mouse. This policy stays the same, therefore the implementation we have is right and will stay as is.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Femma (femma) wrote :

Zsombor, if a mouse is plugged in then a user should be able to perform both swipe on the list item as well as right click for contextual menu. This is what I've been informed from stakeholders.

Revision history for this message
Zsombor Egri (zsombi) wrote :

Yes, and this is what we are aiming for.

Revision history for this message
Femma (femma) wrote : Re: [Bug 1479688] Re: ListItem does not swipe with custom MouseAreas

Great :)

On Fri, Aug 7, 2015 at 10:14 AM, Zsombor Egri <email address hidden>
wrote:

> Yes, and this is what we are aiming for.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1479688
>
> Title:
> ListItem does not swipe with custom MouseAreas
>
> Status in Ubuntu UX:
> Fix Committed
> Status in ubuntu-ui-toolkit package in Ubuntu:
> Fix Committed
>
> Bug description:
> Expected:
> ListItem with user avatar an an image/attachment. I want to be able to
> detect the click on the avatar or the image, so I need to place MouseAreas
> within the list view. This used to work with the old
> ListViewItemWithActions.
>
> Actual:
> ListItem does not allow a swipe when it starts on one of those mouse
> areas. Meaning, you have to look for "free" space where you can drag the
> item, which is not intuitive and clearly a UX annoyance.
>
> UX Fix:
>
> When a mouse is plugged in, the leading and trailing actions should be
> available in the contextual menu. Please look at
>
> https://docs.google.com/document/d/1nFm8xiYhKXXuEO_IvMXoD0lASbYzYXva1BWMVanU3iw/edit#heading=h.y7e1o2x66nvr
> pages 106-109.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu-ux/+bug/1479688/+subscriptions
>

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1603+15.10.20150812-0ubuntu1

---------------
ubuntu-ui-toolkit (1.3.1603+15.10.20150812-0ubuntu1) wily; urgency=medium

  [ Tim Peeters ]
  * Use grid units in Icons in the showcase gallery. Fixes LP: #1481489
  * Disable header buttons when the header is animating. Fixes LP: #1478147
  * Add ActionBar examples to the gallery.
  * Make the default MainView background plain white. Fixes LP: #1481834

  [ Zsombor Egri ]
  * Fixing swiping over active components. Fixes LP: #1479688.
  * Fixing broken BottomEdgeHint gallery page.

  [ Zoltán Balogh ]
  * Fix packaging question marks / issues. Fixes LP: #1481584

  [ Loïc Molinari ]
  * UbuntuShape - Added support drop shadow aspect support to UbuntuShapeOverlay
    Fixes LP: #1480197.
  * UbuntuShape - Removed content orientation work around.
    The shape was using a workaround to make it render correctly when the
    content orientation was not the native one. This was perfect for the
    OrientationHelper shipped with the toolkit but now that the Shell
    implements the rotation, this is not needed anymore and causes some
    rendering issues. Note that the shape will still needs to support
    correct rendering when rotated using the rotation property of the Item,
    but that is a different issue. Fixes LP: #1466656.
  * UbuntuShape - Added a DropShadow aspect. Fixes LP: #1478129.
  * Renamed ShellIcon to ProportionalShape.
  * UbuntuShape - Added an ShellIcon item. Fixes LP: #1478130

  [ Nick Dedekind ]
  * Added LiveTimer.

  [ Christian Dywan ]
  * Grab focus when Dialog is shown.
  * Set Qt.IBeamCursor on text component MouseArea's. Fixes LP: #1483823
  * Make automaticOrientation on MainView a no-op. Fixes LP: #1470258
  * Fix warnings on undefine theme.name in gallery
    examples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml:48:
      TypeError: Cannot read property of null.

  [ Ken VanDine ]
  * Don't fail if MainView doesn't have a useDeprecatedToolbar property
    Fixes LP: #1451243

  [ CI Train Bot ]
  * Resync trunk. added: examples/ubuntu-ui-toolkit-gallery/po/uk.po

 -- CI Train Bot <email address hidden> Wed, 12 Aug 2015 17:31:20 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.