Ubuntu UX

right click menu looks disabled, change the styling

Bug #1477309 reported by Bill Filler on 2015-07-22

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Ubuntu UX	Fix Released	High	Jouni Helminen
	webbrowser-app (Ubuntu)	Fix Released	Medium	Olivier Tilloy

Bug Description

when running webbrowser-app on desktop, the right click menu options all look disabled. The text is quite light and grey which makes it look disabled.

Tags:

Related branches

lp:~osomon/webbrowser-app/oxide-context-menu

Merged into lp:webbrowser-app at revision 1152

Ken VanDine: Approve on 2015-08-27

Ugo Riboni (community): Approve on 2015-08-27

PS Jenkins bot: Approve (continuous-integration) on 2015-08-26

Bill Filler (bfiller) on 2015-07-22

tags:

added: convergence

Magdalena Mirowicz (magdalena-mirowicz) on 2015-07-23

summary:	- [convergence] right click menu looks disabled, change the styling + [SDK] right click menu looks disabled, change the styling
Changed in ubuntu-ux:
assignee:	nobody → Jouni Helminen (jounihelminen)
importance:	Undecided → High
status:	New → Triaged

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-07-27: Re: [SDK] right click menu looks disabled, change the styling

Not sure about standard UITK context menus, but the browser context menu is custom, so that issue can be addressed separately (thus I’m not sure that the bug title update was necessary).

Changed in webbrowser-app (Ubuntu):
status:	New → Confirmed
importance:	Undecided → Medium
assignee:	nobody → Olivier Tilloy (osomon)

Olivier Tilloy (osomon) on 2015-07-30

tags:

added: contextmenu

Revision history for this message

Jouni Helminen (jounihelminen) wrote on 2015-08-03:

Can you please attach a screenshot of how this looks on desktop?

Changed in ubuntu-ux:
status:	Triaged → In Progress

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-08-03:

context-menu.png Edit (40.7 KiB, image/png)

Attaching a screenshot of how the current implementation looks on desktop. This obviously doesn’t match the visual specification at https://docs.google.com/presentation/d/1P6A7ZsI03sPfuI9vzPeC0VcUfIgugxnU4QyObH6UNTs/edit#slide=id.g75d5dd944_021. I’m updating the style together with other related changes.

summary:	- [SDK] right click menu looks disabled, change the styling + right click menu looks disabled, change the styling
Changed in webbrowser-app (Ubuntu):
status:	Confirmed → In Progress

Revision history for this message

Jouni Helminen (jounihelminen) wrote on 2015-08-04:

OK. I'll mark this as fix committed from UX since you have the design spec - let me know if you need anything else!

Jouni Helminen (jounihelminen) on 2015-08-05

Changed in ubuntu-ux:
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-08-31:

This bug was fixed in the package webbrowser-app - 0.23+15.10.20150827.3-0ubuntu1

---------------
webbrowser-app (0.23+15.10.20150827.3-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Olivier Tilloy ]
  * Use the contextMenu API new in oxide 1.8. Update the visuals for the
    context menu in narrow and wide form factors. Add text editing
    commands to the context menu. Add unit and autopilot tests for the
    context menu features. This bumps the runtime dependency of webapp-
    container and qtdeclarative5-ubuntu-web-plugin on liboxideqt-
    qmlplugin to 1.8. This also removes the qtdeclarative5-ubuntu-web-
    plugin-assets binary package, which contained only one PNG asset
    which is not used anywhere any longer. (LP: #1477310, #1477315,
    #1471181, #1264493, #1487090, #1326070, #1477309, #1450430,
    #1438046)