[indicators]/OSD provide no visual clue that they modify bluetooth device volumes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Canonical System Image |
High
|
Alejandro J. Cura | ||
| Ubuntu UX |
High
|
Benjamin Keyser | ||
| indicator-sound (Ubuntu) |
High
|
Xavi Garcia | ||
| indicator-sound (Ubuntu RTM) |
Undecided
|
Unassigned |
Bug Description
Connect a bluetooth audio device (headset, speakers) to the ubuntu phone.
Play music/enter into a call, so that you have active audio to the device.
Adjust the volume, using the UI or keys on the ubuntu phone.
The volume of the bluetooth headset changes (good) but the ui contains no clue that this is what the phone is doing (less good). The standard volume indicator is shown. This can lead to user confusion if they are not currently using the paired bluetooth accessory, and have forgotten it is paired. On other devices the volume indicator changes to provide visual feedback that the bluetooth device volume is being set.
-------
Desired resolution:
Please use this icon to replace the volume icon. The icon is bluetooth volume which we had design already.
https:/
Related branches
- Charles Kerr (community): Approve on 2015-10-08
- PS Jenkins bot (community): Approve (continuous-integration) on 2015-10-05
-
Diff: 614 lines (+437/-40)6 files modifiedsrc/CMakeLists.txt (+1/-0)
src/service.vala (+329/-27)
src/sound-menu.vala (+23/-0)
src/volume-control-pulse.vala (+69/-12)
src/volume-control.vala (+14/-0)
tests/notifications-test.cc (+1/-1)
- Charles Kerr (community): Approve on 2015-10-28
- Pete Woods (community): Approve on 2015-10-27
- PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2015-10-27
-
Diff: 7104 lines (+6292/-177)60 files modifieddebian/control (+11/-0)
include/CMakeLists.txt (+1/-0)
include/unity/CMakeLists.txt (+1/-0)
include/unity/gmenuharness/MatchResult.h (+66/-0)
include/unity/gmenuharness/MatchUtils.h (+42/-0)
include/unity/gmenuharness/MenuItemMatcher.h (+143/-0)
include/unity/gmenuharness/MenuMatcher.h (+95/-0)
src/CMakeLists.txt (+11/-9)
src/gmenuharness/CMakeLists.txt (+17/-0)
src/gmenuharness/MatchResult.cpp (+187/-0)
src/gmenuharness/MatchUtils.cpp (+74/-0)
src/gmenuharness/MenuItemMatcher.cpp (+1011/-0)
src/gmenuharness/MenuMatcher.cpp (+208/-0)
src/service.vala (+354/-46)
src/sound-menu.vala (+38/-0)
src/volume-control-pulse.vala (+69/-14)
src/volume-control.vala (+14/-0)
tests/CMakeLists.txt (+113/-107)
tests/dbus-types/CMakeLists.txt (+53/-0)
tests/dbus-types/com.ubuntu.AccountsService.Sound.xml (+9/-0)
tests/dbus-types/dbus-types.h (+48/-0)
tests/dbus-types/org.PulseAudio.Ext.StreamRestore1.xml (+7/-0)
tests/dbus-types/org.freedesktop.Accounts.xml (+8/-0)
tests/dbus-types/org.freedesktop.DBus.Properties.xml (+22/-0)
tests/dbus-types/org.freedesktop.Notifications.xml (+47/-0)
tests/dbus-types/org.gtk.Actions.xml (+13/-0)
tests/dbus-types/pulseaudio-volume.cpp (+156/-0)
tests/dbus-types/pulseaudio-volume.h (+69/-0)
tests/integration/CMakeLists.txt (+132/-0)
tests/integration/indicator-sound-test-base.cpp (+807/-0)
tests/integration/indicator-sound-test-base.h (+146/-0)
tests/integration/main.cpp (+58/-0)
tests/integration/test-indicator.cpp (+963/-0)
tests/integration/touch-stream-restore.table (+4/-0)
tests/integration/utils/dbus-pulse-volume.cpp (+232/-0)
tests/integration/utils/dbus-pulse-volume.h (+57/-0)
tests/integration/utils/get-volume.cpp (+33/-0)
tests/integration/utils/set-volume.cpp (+36/-0)
tests/notifications-test.cc (+1/-1)
tests/service-mocks/CMakeLists.txt (+2/-0)
tests/service-mocks/DBusPropertiesNotifier.cpp (+41/-0)
tests/service-mocks/DBusPropertiesNotifier.h (+48/-0)
tests/service-mocks/accounts-mock/AccountsDefs.h (+37/-0)
tests/service-mocks/accounts-mock/AccountsMock.cpp (+40/-0)
tests/service-mocks/accounts-mock/AccountsMock.h (+50/-0)
tests/service-mocks/accounts-mock/AccountsServiceSoundMock.cpp (+48/-0)
tests/service-mocks/accounts-mock/AccountsServiceSoundMock.h (+58/-0)
tests/service-mocks/accounts-mock/CMakeLists.txt (+42/-0)
tests/service-mocks/accounts-mock/com.ubuntu.AccountsService.Sound.Mock.xml (+6/-0)
tests/service-mocks/accounts-mock/main.cpp (+63/-0)
tests/service-mocks/accounts-mock/org.freedesktop.Accounts.Mock.xml (+13/-0)
tests/service-mocks/media-player-mpris-mock/CMakeLists.txt (+63/-0)
tests/service-mocks/media-player-mpris-mock/MediaPlayerMprisDefs.h (+37/-0)
tests/service-mocks/media-player-mpris-mock/MediaPlayerMprisMock.cpp (+103/-0)
tests/service-mocks/media-player-mpris-mock/MediaPlayerMprisMock.h (+77/-0)
tests/service-mocks/media-player-mpris-mock/applications/testplayer1.desktop (+21/-0)
tests/service-mocks/media-player-mpris-mock/main.cpp (+64/-0)
tests/service-mocks/media-player-mpris-mock/org.mpris.MediaPlayer2.Player.xml (+24/-0)
tests/service-mocks/media-player-mpris-mock/org.mpris.MediaPlayer2.xml (+6/-0)
tests/service-mocks/media-player-mpris-mock/player-update.cpp (+93/-0)
Noemí (noemi-gallego) wrote : | #1 |
description: | updated |
Changed in ubuntu-ux: | |
status: | New → Fix Committed |
importance: | Undecided → High |
assignee: | nobody → John Lea (johnlea) |
John McAleely (john.mcaleely) wrote : | #2 |
@johnlea - it seems you are not addressing the issue, perhaps because I was unclear. The problem is not that phones don't indicate a change of volume, but rather that they don't indicate they are changing the volume of a paired bluetooth device.
So this bug is a request for a visual differentiation between the UI shown for on-device volume, and off-device-
Changed in ubuntu-ux: | |
status: | Fix Committed → New |
description: | updated |
John McAleely (john.mcaleely) wrote : | #3 |
I have edited the description of the bug
Changed in ubuntu-ux: | |
assignee: | John Lea (johnlea) → nobody |
assignee: | nobody → Paty Davila (dizzypaty) |
Changed in ubuntu-ux: | |
status: | New → Triaged |
John McAleely (john.mcaleely) wrote : | #4 |
When will this bug be worked on? It has been raised by our OEM partners as a priority. I have removed the 'desired resolution' text placed by johnlea, as it was clearly not correct.
description: | updated |
Noemí (noemi-gallego) wrote : | #5 |
Any updates on this bug?
summary: |
- indicators/OSD provide no visual clue that they modify bluetooth device - volumes + [indicators]/OSD provide no visual clue that they modify bluetooth + device volumes |
Noemí (noemi-gallego) wrote : | #6 |
Any updates on this bug?
Changed in ubuntu-ux: | |
assignee: | Paty Davila (dizzypaty) → Alex Milazzo (digitalalex) |
description: | updated |
Changed in ubuntu-ux: | |
status: | Triaged → Fix Committed |
description: | updated |
John McAleely (john.mcaleely) wrote : | #7 |
I can find no mention of volume notifications changing according to the paired accessories. Where is that?
Changed in ubuntu-ux: | |
status: | Fix Committed → Confirmed |
Changed in ubuntu-ux: | |
status: | Confirmed → Triaged |
Alex Milazzo (digitalalex) wrote : | #8 |
Please use this icon to replace the volume icon. The icon is bluetooth volume which we had design already.
https:/
Changed in ubuntu-ux: | |
status: | Triaged → Fix Committed |
description: | updated |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Charles Kerr (charlesk) |
importance: | Undecided → High |
milestone: | none → ww40-2015 |
status: | New → Confirmed |
Changed in indicator-bluetooth (Ubuntu): | |
assignee: | nobody → Charles Kerr (charlesk) |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in canonical-devices-system-image: | |
assignee: | Charles Kerr (charlesk) → Alejandro J. Cura (alecu) |
Changed in indicator-bluetooth (Ubuntu): | |
assignee: | Charles Kerr (charlesk) → Xavi Garcia (xavi-garcia-mena) |
Xavi Garcia (xavi-garcia-mena) wrote : | #9 |
I'm looking at this bug and I have some questions:
I understand that the icon we need to change is the right icon on the volume slider, isn't it?
Changed in ubuntu-ux: | |
assignee: | Alex Milazzo (digitalalex) → Matthew Paul Thomas (mpt) |
status: | Fix Committed → Confirmed |
no longer affects: | indicator-messages (Ubuntu) |
Changed in indicator-bluetooth (Ubuntu): | |
assignee: | Xavi Garcia (xavi-garcia-mena) → nobody |
Changed in indicator-sound (Ubuntu): | |
status: | New → Fix Committed |
assignee: | nobody → Xavi Garcia (xavi-garcia-mena) |
Benjamin Keyser (bjkeyser) wrote : | #10 |
Let's just put a label (rather than an icon for each) up on screen within the overlay to indicate what the user is affecting.
ie:
* ringer
* alarm volume
* bluetooth
* headphone jack
* HDMI Audio
* USB Audio
Alejandro J. Cura (alecu) wrote : | #11 |
Yes, just a label sounds better than having custom icons for each output type.
Changed in ubuntu-ux: | |
assignee: | Matthew Paul Thomas (mpt) → nobody |
assignee: | nobody → Benjamin Keyser (bjkeyser) |
Pat McGowan (pat-mcgowan) wrote : | #12 |
That will need translations so moving to next ilestone
Changed in canonical-devices-system-image: | |
milestone: | ww40-2015 → ww46-2015 |
Changed in ubuntu-ux: | |
assignee: | Benjamin Keyser (bjkeyser) → Paty Davila (dizzypaty) |
status: | Confirmed → Triaged |
assignee: | Paty Davila (dizzypaty) → Benjamin Keyser (bjkeyser) |
Changed in indicator-sound (Ubuntu): | |
importance: | Undecided → High |
Changed in indicator-bluetooth (Ubuntu): | |
status: | Confirmed → Invalid |
Changed in canonical-devices-system-image: | |
status: | Confirmed → In Progress |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Alejandro J. Cura (alecu) wrote : | #13 |
Due to packaging and dependency issues this feature has missed OTA-8.
We'll land it early in the OTA-9 cycle.
Changed in canonical-devices-system-image: | |
status: | Fix Committed → In Progress |
Changed in indicator-sound (Ubuntu): | |
status: | Fix Committed → In Progress |
Changed in canonical-devices-system-image: | |
milestone: | ww46-2015 → ww02-2016 |
Launchpad Janitor (janitor) wrote : | #14 |
This bug was fixed in the package indicator-sound - 12.10.2+
---------------
indicator-sound (12.10.
[ Xavi Garcia ]
* Added OSD notifications to show output source when the volume or
source change (LP: #1382548, LP: #1415480, LP: #1484589)
[ CI Train Bot ]
* New rebuild forced.
-- Xavi Garcia <email address hidden> Tue, 03 Nov 2015 17:47:10 +0000
Changed in indicator-sound (Ubuntu): | |
status: | In Progress → Fix Released |
no longer affects: | indicator-bluetooth (Ubuntu) |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Changed in canonical-devices-system-image: | |
status: | Fix Released → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → In Progress |
Changed in indicator-sound (Ubuntu): | |
status: | Fix Released → In Progress |
Łukasz Zemczak (sil2100) wrote : | #15 |
This bug was fixed in the package indicator-sound 12.10.2+
---------------
indicator-sound (12.10.
[ CI Train Bot ]
* No-change rebuild.
indicator-sound (12.10.
[ Xavi Garcia Mena ]
* Very simple change to make upstart try to respawn the process 30
times (instead of 2). This is a workaround for the case when dbus
session is not ready yet at startup.
[ Timo Jyrinki ]
* Note: this release was reverted on 20151223, ignore this changelog entry.
indicator-sound (12.10.
[ Xavi Garcia ]
* Added OSD notifications to show output source when the volume or
source change (LP: #1382548, LP: #1415480, LP: #1484589)
[ CI Train Bot ]
* New rebuild forced.
[ Timo Jyrinki ]
* Note: this release was reverted on 20151223, ignore this changelog entry.
indicator-sound (12.10.
[ Xavi Garcia Mena ]
* Wily branch for MPRIS controls (LP: #1373313)
indicator-sound (12.10.
[ Sebastien Bacher ]
* under unity8 start system-settings instead unity-control-
#1489427)
[ Xavi Garcia Mena ]
* Merged lp:~xavi-garcia-mena/indicator-sound/icon-volume-zero
indicator-sound (12.10.
[ CI Train Bot ]
* New rebuild forced.
[ Charles Kerr ]
* When showing a "Loud volumes can damage your hearing" confirmation
warning, clamp the volume until the user hits "OK". (LP: #1481913)
indicator-sound (12.10.
[ CI Train Bot ]
* New rebuild forced.
[ Charles Kerr ]
* Revised UI volume warnings to comply with EU requirements. (LP:
#1481913)
indicator-sound (12.10.
*
indicator-sound (12.10.
* Using eventually to avoid arbitrary timeouts in tests
indicator-sound (12.10.
[ Charles Kerr ]
* Use the BusWatcher to look for org.freedesktop
ownership changes on the bus. (LP: #1432446)
-- Xavi Garcia <email address hidden> Wed, 23 Dec 2015 12:54:33 +0000
Changed in indicator-sound (Ubuntu RTM): | |
status: | New → Fix Released |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Alejandro J. Cura (alecu) wrote : | #16 |
This also landed by mistake, and had to be reverted.
The feature is still being tested in silo 51.
Changed in canonical-devices-system-image: | |
status: | Fix Committed → In Progress |
Launchpad Janitor (janitor) wrote : | #17 |
This bug was fixed in the package indicator-sound - 12.10.2+
---------------
indicator-sound (12.10.
[ Xavi Garcia Mena ]
* Adds an action to signal the UI to sync the current volume when we
are waiting for the user to confirm or reject the high volume
notification. (LP: #1520548, #1512798)
* This branch just readds the OSD notifications code, that was
reverted in trunk as the corresponding silo was also rolled back
after landing.
* This branch re-adds the integration tests using gmenuharness. Added
OSD notifications to show output source when the volume or source
change (LP: #1382548, LP: #1415480, LP: #1484589) debian/control:
Added the following build dependencies: cmake-extras (>= 0.4),
google-mock (>= 1.6.0+svn437), libqtdbusmock1-dev (>= 0.3),
libqtdbuste
qtbase5-dev, qtbase5-dev-tools, qtdeclarative5-dev, qtdeclarative5-
dev-tools Added gmenuharness library for integration tests support.
New Files: src/gmenuharnes
src/
src/
src/
include/
include/
include/
include/
using gmenuharness New Files: tests/dbus-
tests/
types/
types/
types/
types/
types/
types/
tests/
tests/
test-base.cpp tests/integrati
tests/
tests/
tests/
tests/
tests/
volume.cpp tests/service-
mocks/
mocks/
mock/
mock/
mock/
mock/
mock/
mock/
mock/
mocks/
mock/
player-
Changed in indicator-sound (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Are there any update on this bug?