[dialer-app] can't unlock phone during an incoming call

[Selene ToyKeeper]

While testing krillin rtm image 142, I noticed that the phone remains locked during an incoming call if the screen was off when the call came in. There is no way to unlock the phone to access other functions until after the call is done.

It seems like a common use case to be able to do other things on the phone during a call, looking up someone's number or checking a map or whatever, but this currently is only possible during outgoing calls.

During an incoming call I can't even access the indicators to change brightness or check today's date or even see what time it is, so it actually ends up being more "locked" than the lock screen.

Could we add the ability to unlock the phone during a call received while locked?

[Michael Terry (mterry)]

This is because we use the same mode as the emergency dialer when an incoming call happens and the user is on the lockscreen.

In emergency dialer mode, we present a very stripped down experience for both no-distraction reasons and avoiding-security-hole reasons -- emergency mode is a kind of controlled exploit because we actually unlock your phone and let you only see your dialer.

Some options to fix this would be to tease apart "incoming call mode" and "emergency dialer mode", which wouldn't be entirely trivial but obviously not impossible. Or maybe add indicators (and launcher?) back to the locked-dialer experience in both cases.

In either case, we would want to lots of testing to make sure you can't break out of the dialer jail.

[Selene ToyKeeper (toykeeper)]

Emergency call mode is a convenient way to implement incoming calls, but at least when an unauthorized user picks up the phone they have the ability to *attempt* to unlock it. On an incoming call, there is no way at all to even attempt an unlock.

We should at least allow the user to try, and if they get the passcode correct, they should be able to use the device in full. Would probably also be a good idea to at least show the indicators, even if they don't respond to input until after unlock. It's important to be able to see what time it is and how much battery is left, regardless of whether the user is authorized.

[Brendan Donegan (brendan-donegan)]

Press back on the dialer, unlock... This is the fix that was implemented in image #149

[Selene ToyKeeper (toykeeper)]

The 'back' button is a good improvement since it makes other features possible to access.

However, could we at least display the indicators during incoming calls, to let the user know the current time and battery charge (even if they're unauthorized)?

Also, it would be nice to have an easier way to unlock the phone during an incoming call, such as swiping from either side to access the passcode screen.

[Sebastien Bacher (seb128)]

is that still an issue?

[Olga Kemmet (olga-kemmet)]

I would agree with mterry, we should have two different modes for the dialer when the device is locked. I can imagine that it would be then easier to make changes/fixes according to the specific use case.
As for the initial bug, it looks like it was fixed. I tested it on vivid r207. The fact that indicators are not shown during the active call, if it was accepted while device is locked, seems to me a separate issue.