Update header divider
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Ubuntu UX |
Critical
|
Jouni Helminen | ||
| ubuntu-ui-toolkit (Ubuntu) |
High
|
Tim Peeters | ||
| Vivid |
Undecided
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu RTM) |
Undecided
|
Unassigned |
Bug Description
Use color: 5% black instead of the current image.
Related branches
- PS Jenkins bot: Approve (continuous-integration) on 2014-10-28
- Zsombor Egri: Approve on 2014-10-28
-
Diff: 324 lines (+178/-21)8 files modifiedmodules/Ubuntu/Components/AppHeader.qml (+5/-0)
modules/Ubuntu/Components/MainView.qml (+1/-0)
modules/Ubuntu/Components/Styles/PageHeadStyle.qml (+5/-1)
modules/Ubuntu/Components/Themes/Ambiance/HeadDividerStyle.qml (+53/-0)
modules/Ubuntu/Components/Themes/Ambiance/HeadSeparatorImageStyle.qml (+36/-0)
modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml (+27/-20)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+2/-0)
tests/resources/header/header.qml (+49/-0)
- PS Jenkins bot: Approve (continuous-integration) on 2014-11-27
- Zsombor Egri: Approve on 2014-11-25
-
Diff: 79 lines (+1/-47)3 files modifiedmodules/Ubuntu/Components/Themes/Ambiance/HeadSeparatorImageStyle.qml (+0/-36)
modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml (+1/-10)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+0/-1)
Changed in ubuntu-ux: | |
assignee: | nobody → Jouni Helminen (jounihelminen) |
status: | New → Triaged |
tags: | added: ota-1 |
Changed in ubuntu-ui-toolkit: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
Tim Peeters (tpeeters) wrote : | #1 |
Changed in ubuntu-ui-toolkit: | |
importance: | Medium → Critical |
assignee: | nobody → Tim Peeters (tpeeters) |
Changed in ubuntu-ux: | |
importance: | Undecided → Critical |
status: | Triaged → Fix Released |
tags: |
added: rtm removed: ota-1 |
Tim Peeters (tpeeters) wrote : | #2 |
11:29:15 < jounih> timp - can you please check how Dash has implemented the suru divider? they just used qml rectangles
11:29:30 < jounih> timp: they also have the right color values. so you could just copy it from there
Jouni Helminen (jounihelminen) wrote : | #3 |
let's use QML rectangles for the top (inner shadow), middle (large divider) and bottom (highlight). The correct implementation is already in the dash divider - can we just copy the solution from there?
Tim Peeters (tpeeters) wrote : | #4 |
not a showstopper, reduced priority
tags: | removed: rtm |
Changed in ubuntu-ui-toolkit: | |
importance: | Critical → High |
Changed in ubuntu-ui-toolkit: | |
status: | Confirmed → In Progress |
Tim Peeters (tpeeters) wrote : | #5 |
dash automatically computes the color of the bottom and top of the divider, but the main divider color is hardcoded as #e0e0e0
PS Jenkins bot (ps-jenkins) wrote : | #6 |
Fix committed into lp:ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown
Changed in ubuntu-ui-toolkit: | |
status: | In Progress → Fix Committed |
Tim Peeters (tpeeters) wrote : | #7 |
I set this back to in progress, because:
158 + // FIXME: After After https:/
159 + // lands, set separatorSource and separatorBottom
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Tim Peeters (tpeeters) |
importance: | Undecided → High |
status: | New → In Progress |
no longer affects: | ubuntu-ui-toolkit |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Fix Committed → Fix Released |
Currently we use two images for the divider. From PageHeadStyle.qml: urce: "artwork/ PageHeaderBaseD ividerLight. sci" ttomSource: "artwork/ PageHeaderBaseD ividerBottom. png"
separatorSo
separatorBo