[SDK] MainView.backgroundColor is not usable any more

Bug #1356779 reported by Michael Zanetti on 2014-08-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UX
High
Jouni Helminen
ubuntu-ui-toolkit (Ubuntu)
High
Zsombor Egri

Bug Description

Since the latest SDK updates, MainView.backgroundColor is not usable any more. It completely messes up the whole theming:

For example setting a dark background causes:

* Text in Dialogs to be unreadable
* Header Popovers (the new ones) to turn purple(!)
* Active ListItem's text color to be unreadable

And the situation seems to get worse with each uitk update... Maybe the *color properties of the MainView should just be removed? If you think that should be kept but all the places that break should be fixed instead to make it work again, please let me know and I'll do my best to collect all the places it broke.

Related branches

summary: - MainView.bacgroundColor is not usable any more
+ MainView.backgroundColor is not usable any more
description: updated
description: updated
Zsombor Egri (zsombi) on 2014-10-01
Changed in ubuntu-ui-toolkit:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Zsombor Egri (zsombi)
Zoltan Balogh (bzoltan) on 2014-10-13
Changed in ubuntu-ui-toolkit:
milestone: none → 11.07

The biggest problem is that it is not possible to know what color should be used in the labels due to the fact that we don't necessarily know what is the color the label is rendered on, unfortunately Text/Label does not support chameleon colors.

OTOH, I would be glad to see those colors which cause trouble, so we can see what luminosity or other color tone we should use to chose the proper theme.

Zsombor Egri (zsombi) on 2014-10-18
Changed in ubuntu-ui-toolkit:
status: Triaged → Incomplete
Zsombor Egri (zsombi) on 2014-10-20
Changed in ubuntu-ui-toolkit:
status: Incomplete → Confirmed
Zsombor Egri (zsombi) on 2014-10-20
Changed in ubuntu-ui-toolkit:
importance: Critical → High
Tim Peeters (tpeeters) wrote :

there is no problem with the backgroundColor.

There are palette issues with certain footer colors. A new bug will be filed.

Changed in ubuntu-ui-toolkit:
status: Confirmed → Invalid
Zsombor Egri (zsombi) wrote :

Actually it was reproduced by bug #1386208. It seams the bug shows up when the MainView uses different colours for backgroundColor and header/footerColor. In this case the theme chosen by MainViewStyle will be the SuruGradient, which is deprecated, however the theme chooser logic wasn't fixed.

Changed in ubuntu-ui-toolkit:
status: Invalid → Confirmed
Tim Peeters (tpeeters) wrote :

We can start to ignore headerColor and footerColor of MainView. Then we never have gradient backgrounds any more (except if apps implement a custom background and don't rely on MainView).

Question for design: Do we need to support gradient backgrounds?

Tim Peeters (tpeeters) wrote :

Instead of deprecating gradient backgrounds, we can simply use either the Ambience or SuruDark theme (no SuruGradient) depending on the headerColor of the gradient.

Zsombor Egri (zsombi) wrote :

It is not about deprecating gradient backgrounds, but getting rid of the automatic SuruGradient theme selection.

However, maybe header colours should be transparent when gradients are used as app background, and should take the theme colours only when solid fill is used. But this is up to the designers.

Zoltan Balogh (bzoltan) on 2014-11-24
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Zsombor Egri (zsombi)
importance: Undecided → High
status: New → Confirmed
Zoltan Balogh (bzoltan) on 2014-11-24
no longer affects: ubuntu-ui-toolkit
Zsombor Egri (zsombi) wrote :

It has been confirmed that this is caused when gradient background is set of the application, which loads SuruGradient theme. The theme is deprecated, and SuruDark or Ambiance theme should be used whenever appropriate.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
Changed in ubuntu-ux:
importance: Undecided → High
status: New → Triaged
assignee: nobody → Giorgio Venturi (giorgio-venturi)
John Lea (johnlea) on 2014-12-05
summary: - MainView.backgroundColor is not usable any more
+ [SDK] MainView.backgroundColor is not usable any more
Changed in ubuntu-ux:
assignee: Giorgio Venturi (giorgio-venturi) → nobody
assignee: nobody → Jouni Helminen (jounihelminen)
Zsombor Egri (zsombi) wrote :

Giorgio, I don' think there is any need to get this bug triaged from your side.. unless you want to have a different solution...

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1364+15.04.20141209-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1364+15.04.20141209-0ubuntu1) vivid; urgency=medium

  [ Zsombor Egri ]
  * Theming fixes: application theming, binding loop fix, auto-theming
    moved into MainView and it is applicable only on Ambiance and
    SuruDark, SuruGradient is no longer auto-themed.
    Fixes: LP: #1213043, LP: #1277647, LP: #1330510, LP: #1356779,
           LP: #1389792.
  * ServiceProperties component to Ubuntu.Components 1.1.
    Fixes: LP: #1391877.
  * New ListItem component base. Support for leading/trailing actions.
    Exported in Ubuntu.Components 1.2 UNSTABLE release.
    Fixes: LP: #1097728, LP: #1372592, LP: #1383870.
  * removing failing ServiceProperties and app-theming branches
  * Application theming ant other theming related binding loop fixes
  * ServiceProperties DBus property watcher

  [ Christian Dywan ]
  * Do the default theme check properly: for non-debug and without
    build errors.
  * Don't activate the control in ListItem.Standard implicitly.
    Fixes: LP: #1372563.
  * Improve AutoPilot caret dragging test cases.
  * Use new qt_gl_set_global_share_context setter with Qt 5.4.
    Fixes: LP: #1397979.
  * Add sortCaseSensitivity to the SortFilterModel example.
    Fixes: LP: #1391034.
  * Change offending links into bold font. Fixes: LP: #1395011.

  [ Daniel d'Andrada ]
  * This is needed by unity8 for the "shell rotation" feature (ie
    shell does all the rotation work instead of apps rotating
    themselves). unity8's dialogs (like the power dialog when you
    long press the power button) should follow its parent item
    rotation and size, as one would expect, and not be sneakily
    reparented to the scene root item, in which case the shell
    UI would be rotated but its dialog would not.
    Related bug LP: #1394511. Fixes: LP: #1394511.

  [ Tim Peeters ]
  * Remove the old header separator style. Fixes: LP: #1372590.

  [ Loïc Molinari ]
  * Made the UCAlarmPrivate destructor private.

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Tue, 09 Dec 2014 11:47:33 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
Changed in ubuntu-ux:
status: Triaged → Fix Released
Zsombor Egri (zsombi) on 2016-03-10
no longer affects: ubuntu-ui-toolkit (Ubuntu Vivid)
no longer affects: ubuntu-ui-toolkit (Ubuntu RTM)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers