[sdk] Colors should have symbolic names
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Canonical System Image |
High
|
Zoltan Balogh | ||
| Ubuntu UX |
Wishlist
|
Jamie Young | ||
| ubuntu-ui-toolkit (Ubuntu) |
High
|
Zsombor Egri |
Bug Description
[Updated description]
Reading http://
–––
Progress update:
We've updated the colour palette with a more useful naming structure:
Related branches
- ubuntu-sdk-build-bot: Approve (continuous-integration) on 2016-01-15
- Timo Jyrinki (community): Approve on 2016-01-15
-
Diff: 4787 lines (+1958/-742)94 files modifiedcomponents.api (+49/-1)
debian/changelog (+40/-0)
documentation/ubuntu-theming.qdoc (+0/-6)
examples/ubuntu-ui-toolkit-gallery/About.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/BottomEdgePage.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/Colors.qml (+39/-9)
examples/ubuntu-ui-toolkit-gallery/NewListItems.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/PageHeaders.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/Popover.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/Template.qml (+2/-0)
examples/ubuntu-ui-toolkit-gallery/gallery-logging.config (+3/-0)
src/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+2/-2)
src/Ubuntu/Components/1.3/Icon.qdoc (+0/-87)
src/Ubuntu/Components/1.3/Icon.qml (+150/-0)
src/Ubuntu/Components/1.3/MainView.qml (+2/-1)
src/Ubuntu/Components/1.3/MainViewBase.qml (+13/-0)
src/Ubuntu/Components/1.3/Page.qml (+19/-4)
src/Ubuntu/Components/1.3/PageHeader.qml (+1/-1)
src/Ubuntu/Components/1.3/TextArea.qml (+1/-2)
src/Ubuntu/Components/1.3/TextField.qml (+1/-2)
src/Ubuntu/Components/1.3/Toolbar.qml (+1/-1)
src/Ubuntu/Components/1.3/UbuntuColors.qml (+65/-16)
src/Ubuntu/Components/ComponentModule.pro (+2/-1)
src/Ubuntu/Components/ListItems/1.3/LabelVisual.qml (+9/-2)
src/Ubuntu/Components/Popups/1.3/Dialog.qml (+9/-2)
src/Ubuntu/Components/Popups/1.3/Popover.qml (+8/-0)
src/Ubuntu/Components/Themes/1.3/Palette.qml (+13/-1)
src/Ubuntu/Components/Themes/1.3/PaletteValues.qml (+77/-2)
src/Ubuntu/Components/Themes/Ambiance/1.3/AmbianceNormal.qml (+47/-0)
src/Ubuntu/Components/Themes/Ambiance/1.3/BottomEdgeHintStyle.qml (+2/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/BottomEdgeStyle.qml (+10/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/BubbleShape.qml (+2/-2)
src/Ubuntu/Components/Themes/Ambiance/1.3/CheckBoxStyle.qml (+10/-12)
src/Ubuntu/Components/Themes/Ambiance/1.3/IconButtonStyle.qml (+3/-3)
src/Ubuntu/Components/Themes/Ambiance/1.3/ListItemStyle.qml (+5/-4)
src/Ubuntu/Components/Themes/Ambiance/1.3/OverflowPanel.qml (+1/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeaderStyle.qml (+3/-2)
src/Ubuntu/Components/Themes/Ambiance/1.3/Palette.qml (+28/-20)
src/Ubuntu/Components/Themes/Ambiance/1.3/PickerStyle.qml (+3/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/ProgressBarStyle.qml (+2/-2)
src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml (+1/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/SliderStyle.qml (+8/-8)
src/Ubuntu/Components/Themes/Ambiance/1.3/SwitchStyle.qml (+26/-156)
src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml (+13/-5)
src/Ubuntu/Components/Themes/Ambiance/1.3/ToolbarButtonStyle.qml (+5/-0)
src/Ubuntu/Components/Themes/Ambiance/Ambiance.pro (+1/-0)
src/Ubuntu/Components/Themes/Ambiance/qmldir (+1/-0)
src/Ubuntu/Components/Themes/SuruDark/1.2/ListItemStyle.qml (+0/-25)
src/Ubuntu/Components/Themes/SuruDark/1.3/ListItemStyle.qml (+0/-26)
src/Ubuntu/Components/Themes/SuruDark/1.3/Palette.qml (+28/-20)
src/Ubuntu/Components/Themes/SuruDark/1.3/SuruDarkNormal.qml (+47/-0)
src/Ubuntu/Components/Themes/SuruDark/SuruDark.pro (+1/-2)
src/Ubuntu/Components/Themes/SuruDark/qmldir (+1/-0)
src/Ubuntu/Components/plugin/adapters/actionsproxy_p.cpp (+73/-63)
src/Ubuntu/Components/plugin/adapters/actionsproxy_p.h (+8/-7)
src/Ubuntu/Components/plugin/plugin.cpp (+5/-7)
src/Ubuntu/Components/plugin/privates/threelabelsslot_p.cpp (+10/-7)
src/Ubuntu/Components/plugin/privates/threelabelsslot_p.h (+3/-1)
src/Ubuntu/Components/plugin/ucaction.cpp (+65/-9)
src/Ubuntu/Components/plugin/ucaction.h (+18/-0)
src/Ubuntu/Components/plugin/ucactioncontext.cpp (+138/-9)
src/Ubuntu/Components/plugin/ucactioncontext.h (+45/-3)
src/Ubuntu/Components/plugin/ucactionitem.cpp (+3/-1)
src/Ubuntu/Components/plugin/ucbottomedge.cpp (+3/-3)
src/Ubuntu/Components/plugin/ucbottomedge_p.h (+0/-1)
src/Ubuntu/Components/plugin/ucdeprecatedtheme.cpp (+29/-16)
src/Ubuntu/Components/plugin/ucdeprecatedtheme.h (+5/-7)
src/Ubuntu/Components/plugin/uclabel.cpp (+6/-3)
src/Ubuntu/Components/plugin/uclistitem.cpp (+35/-22)
src/Ubuntu/Components/plugin/uclistitem_p.h (+1/-1)
src/Ubuntu/Components/plugin/uclistitemlayout.cpp (+80/-4)
src/Ubuntu/Components/plugin/ucstyleditembase.cpp (+3/-2)
src/Ubuntu/Components/plugin/uctheme.cpp (+75/-62)
src/Ubuntu/Components/plugin/uctheme.h (+6/-12)
src/Ubuntu/Components/plugin/ucthemingextension.cpp (+32/-8)
src/Ubuntu/Components/plugin/ucthemingextension.h (+3/-3)
src/Ubuntu/Components/qmldir (+2/-0)
src/Ubuntu/UbuntuGestures/ucswipearea.cpp (+7/-4)
src/src.pro (+1/-0)
tests/unit/tst_components/tst_action.qml (+14/-6)
tests/unit_x11/tst_bottomedge/LeanActiveRegionChange.qml (+1/-1)
tests/unit_x11/tst_components/AppTheme/Palette.qml (+1/-1)
tests/unit_x11/tst_components/MockKeyboard.qml (+1/-1)
tests/unit_x11/tst_components/tst_contextual_actions.qml (+326/-0)
tests/unit_x11/tst_components/tst_listitem.qml (+3/-5)
tests/unit_x11/tst_components/tst_listitem13.qml (+3/-5)
tests/unit_x11/tst_components/tst_pagestack.qml (+6/-0)
tests/unit_x11/tst_components/tst_shortcuts.qml (+32/-8)
tests/unit_x11/tst_components/tst_slotslayout.qml (+47/-2)
tests/unit_x11/tst_deprecated_theme_engine/tst_deprecated_theme_engine.cpp (+24/-16)
tests/unit_x11/tst_deprecated_theme_engine/tst_deprecated_theme_engine.pro (+1/-1)
tests/unit_x11/tst_subtheming/DefaultTheme.qml (+28/-0)
tests/unit_x11/tst_subtheming/tst_subtheming.cpp (+53/-4)
tests/unit_x11/tst_subtheming/tst_subtheming.pro (+3/-0)
- Tim Peeters: Approve on 2016-01-15
- PS Jenkins bot: Approve (continuous-integration) on 2016-01-14
- ubuntu-sdk-build-bot: Needs Fixing (continuous-integration) on 2016-01-07
- Christian Dywan (community): Needs Fixing on 2015-12-10
-
Diff: 2104 lines (+700/-470)57 files modifiedcomponents.api (+46/-1)
documentation/ubuntu-theming.qdoc (+0/-6)
examples/ubuntu-ui-toolkit-gallery/About.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/BottomEdgePage.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/Colors.qml (+39/-9)
examples/ubuntu-ui-toolkit-gallery/NewListItems.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/PageHeaders.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/Popover.qml (+1/-1)
examples/ubuntu-ui-toolkit-gallery/Template.qml (+2/-0)
src/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+2/-2)
src/Ubuntu/Components/1.3/Icon.qdoc (+0/-87)
src/Ubuntu/Components/1.3/Icon.qml (+150/-0)
src/Ubuntu/Components/1.3/PageHeader.qml (+1/-1)
src/Ubuntu/Components/1.3/TextArea.qml (+1/-2)
src/Ubuntu/Components/1.3/TextField.qml (+1/-2)
src/Ubuntu/Components/1.3/Toolbar.qml (+1/-1)
src/Ubuntu/Components/1.3/UbuntuColors.qml (+65/-16)
src/Ubuntu/Components/ComponentModule.pro (+2/-1)
src/Ubuntu/Components/ListItems/1.3/LabelVisual.qml (+9/-2)
src/Ubuntu/Components/Popups/1.3/Dialog.qml (+2/-2)
src/Ubuntu/Components/Themes/1.3/Palette.qml (+13/-1)
src/Ubuntu/Components/Themes/1.3/PaletteValues.qml (+77/-2)
src/Ubuntu/Components/Themes/Ambiance/1.3/AmbianceNormal.qml (+47/-0)
src/Ubuntu/Components/Themes/Ambiance/1.3/BottomEdgeHintStyle.qml (+2/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/BottomEdgeStyle.qml (+10/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/BubbleShape.qml (+2/-2)
src/Ubuntu/Components/Themes/Ambiance/1.3/CheckBoxStyle.qml (+10/-12)
src/Ubuntu/Components/Themes/Ambiance/1.3/IconButtonStyle.qml (+3/-3)
src/Ubuntu/Components/Themes/Ambiance/1.3/ListItemStyle.qml (+5/-4)
src/Ubuntu/Components/Themes/Ambiance/1.3/OverflowPanel.qml (+1/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeaderStyle.qml (+3/-2)
src/Ubuntu/Components/Themes/Ambiance/1.3/Palette.qml (+28/-20)
src/Ubuntu/Components/Themes/Ambiance/1.3/PickerStyle.qml (+3/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/ProgressBarStyle.qml (+2/-2)
src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml (+1/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/SliderStyle.qml (+8/-8)
src/Ubuntu/Components/Themes/Ambiance/1.3/SwitchStyle.qml (+26/-156)
src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml (+13/-5)
src/Ubuntu/Components/Themes/Ambiance/1.3/ToolbarButtonStyle.qml (+5/-0)
src/Ubuntu/Components/Themes/Ambiance/Ambiance.pro (+1/-0)
src/Ubuntu/Components/Themes/Ambiance/qmldir (+1/-0)
src/Ubuntu/Components/Themes/SuruDark/1.2/ListItemStyle.qml (+0/-25)
src/Ubuntu/Components/Themes/SuruDark/1.3/ListItemStyle.qml (+0/-26)
src/Ubuntu/Components/Themes/SuruDark/1.3/Palette.qml (+28/-20)
src/Ubuntu/Components/Themes/SuruDark/1.3/SuruDarkNormal.qml (+47/-0)
src/Ubuntu/Components/Themes/SuruDark/SuruDark.pro (+1/-2)
src/Ubuntu/Components/Themes/SuruDark/qmldir (+1/-0)
src/Ubuntu/Components/plugin/ucbottomedge.cpp (+1/-1)
src/Ubuntu/Components/plugin/uclabel.cpp (+1/-1)
src/Ubuntu/Components/plugin/uclistitem.cpp (+22/-22)
src/Ubuntu/Components/plugin/uclistitem_p.h (+1/-1)
src/Ubuntu/Components/qmldir (+2/-0)
tests/unit_x11/tst_bottomedge/LeanActiveRegionChange.qml (+1/-1)
tests/unit_x11/tst_components/AppTheme/Palette.qml (+1/-1)
tests/unit_x11/tst_components/MockKeyboard.qml (+1/-1)
tests/unit_x11/tst_components/tst_listitem.qml (+3/-5)
tests/unit_x11/tst_components/tst_listitem13.qml (+3/-5)
affects: | ubuntu-ui-toolkit (Ubuntu) → ubuntu-ui-toolkit |
Changed in ubuntu-ui-toolkit: | |
status: | New → Confirmed |
Florian Boucault (fboucault) wrote : | #1 |
Sebastien Bacher (seb128) wrote : | #2 |
the palette seems to have a restricted set of colors though, e.g no color for buttons
Tim Peeters (tpeeters) wrote : | #3 |
Yes, I think we need to extend the palette (also with colors for positiveAction, negativeAction), or think of a different way to do it.
summary: |
- Colors should have symbolic names + [sdk] Colors should have symbolic names |
Changed in ubuntu-ux: | |
assignee: | nobody → Jouni Helminen (jounihelminen) |
Changed in ubuntu-ux: | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → Confirmed |
no longer affects: | ubuntu-ui-toolkit |
Jouni Helminen (jounihelminen) wrote : | #4 |
These should be in the SDK now - https:/
Changed in ubuntu-ux: | |
status: | Triaged → Fix Released |
Jouni Helminen (jounihelminen) wrote : | #5 |
ah, misread.
Semantic colour names would work once we have agreed on the semantics. The current palette implementation links too many things together so are working on a better alternative
Changed in ubuntu-ux: | |
status: | Fix Released → In Progress |
Changed in ubuntu-ux: | |
importance: | Medium → Wishlist |
status: | In Progress → Triaged |
Changed in ubuntu-ux: | |
assignee: | Jouni Helminen (jounihelminen) → Jamie Young (jamiedawsonyoung) |
description: | updated |
Changed in ubuntu-ux: | |
status: | Triaged → Fix Committed |
Jamie Young (jamiedawsonyoung) wrote : | #6 |
The work on the semantic naming has been done and agreed with the teams. It's in the process of being implemented. Thanks!
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → In Progress |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
Launchpad Janitor (janitor) wrote : | #7 |
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1872+
---------------
ubuntu-ui-toolkit (1.3.1872+
[ Timo Jyrinki ]
* Fix gles unit test skipping.
* Add s390x to the unit test skipping architectures
* UITK test plan - wily -> xenial. Fixes LP: #1544490
[ Christian Dywan ]
* Print errors when QuickUtils fails to create a component.
* unit tests shouldn't use deprecated Dialog.callera
* Correctly count only test case results. The result= value is used in suites
and results.
* Skip tst_pagehead_
* Skip flaky tst_mousefilter
* Suppress click signal if releasing outside of ListItem. Fixes LP: #1541148.
* Use gdb in runtest.sh to produce backtraces.
* Arrow keys change value of a Slider. Fixes LP: #1523824.
* Only use Maliit when enabled explicitly in the environment
[ Oliver Tilloy ]
* Do not try to assign to non-existent property "activeFocusOnP
Fixes LP: #1532953
* Bubble up ESC key press event if there is no popover to close.
Fixes LP: #1546627
[ Loïc Molinari ]
* Added private items and nodes for the new component styles.
Fixes LP: #1523836
* Made use of new private Frame item for the focusing.
* Fixed performance monitor crash because of a NULL timer pointer dereference.
Fixes LP: #1546986
* Fixed performance monitor dangling pointer crash. Fixes LP: #1546984
* [ProportionalShape] Ensured width/height ratio is correct with default values.
Fixes LP: #1546546
* Added a workaround to prevent a crash while changing the QPA scale factor.
[ Florian Boucault ]
* Always on performance monitor that logs frames that too long to render.
* MainView: proceed to selecting the theme automatically at startup too.
Fixes LP: #1535819
* MainView: when no gradient color is needed for the background, rely on
QQuickWindow's GL clear color. Lessens overdraw considerably for most
apps. Fixes LP: #1439133.
* Panel: MathUtils used without import prefix was leading to undefined
reference.
* Label: use native rendering on low dpi screens (GRID_UNIT_PX <= 10) for
sharper looking text.
* Gallery: added palette browser to Colors page.
[ Tim Peeters ]
* Support scrolling in ListViews with horizontal orientation to the
qquicklistview CPO.
* Add background to AppHeader and remove contents clipping from MainView.
Fixes LP: #1531016, LP: #1531457.
* Hide AppHeader when using AdaptivePageLayout. Fixes bug 1531871.
Fixes LP: #1531871.
* Implement horizontal flicking in the flickable autopilot CPO.
* Re-order to list of pages in the gallery to be alphabetical.
* Fix the autopilot failures introduced with the horizontal scrolling in
the Flickable CPO.
* Update documentation for MainView, Page, AdaptivePageLayout to use the new
PageHeader in all examples. Deprecate old properties. Fixes LP: #1540574
* Add 'animate' property to new internal AppHeaderBase, and do not show a
header animation when starting an app without header.
Fixes LP: #1518002, LP: #1524901.
...
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → High |
assignee: | nobody → Zoltan Balogh (bzoltan) |
milestone: | none → ww08-2016 |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
There is already Palette for that: http:// developer. ubuntu. com/api/ qml/sdk- 14.10/Ubuntu. Components. Themes. Palette/